breautek commented on code in PR #640:
URL: https://github.com/apache/cordova-cli/pull/640#discussion_r1609854176
##########
bin/cordova:
##########
@@ -29,7 +29,11 @@ cli(process.argv).catch(err => {
const errorOutput = typeof err === 'string' ? err : util.inspect(err);
throw new CordovaError('Promise rejected with non-error: ' +
errorOutput);
}
- process.exitCode = err.code || 1;
+ if (typeof err.code !== "number") {
Review Comment:
I think it's a good change to make a fallback. It just needs to use our code
style, which is to use single quotes for strings.
```suggestion
if (typeof err.code !== 'number') {
```
should satisfy our lint. After applying the change you can do `npm test` to
confirm, or you can commit/push to let the PR checks to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
