Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-14 Thread via GitHub
elecharny commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2658816814 Hi Gary, that would help a lot, especially for projects we don't update frequently. Typically, for FtpServer, it was not released for a couple of years, and I jumped in to get

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-13 Thread via GitHub
garydgregory commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2658113816 Hi E, It should be easy to implement avoiding breaks using the japicmp Maven plugin to avoid issues like this moving forward. We use japicmp in Commons in all active components. A

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-13 Thread via GitHub
elecharny commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-265752 Hi Gary, sorry for the API breakage... I did my best to get this release out, I should have been more careful... -- This is an automated message from the Apache Git Service.

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-13 Thread via GitHub
garydgregory commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2657883774 Closing: I found all the changes to get this update working. I can't get Commons VFS to work yet tough... -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-13 Thread via GitHub
garydgregory closed pull request #327: Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 URL: https://github.com/apache/commons-net/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-13 Thread via GitHub
garydgregory commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2657726063 Hm, if I apply this patch here: ``` diff --git a/pom.xml b/pom.xml index 4a610fc..00f3990 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-13 Thread via GitHub
garydgregory commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2657696672 And a binary break from 1.2.0 :-( ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:testCompile (default-testCompile) on project common

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-13 Thread via GitHub
garydgregory commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2657684514 Ah, I see, this is a behavior break from 1.2.0 where is was `Md5PasswordEncryptor`... -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-12 Thread via GitHub
elecharny commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2655309216 So this is a user/password authentication. I guess you are definting the user and password in a property file. The password should be stored as ftpserver.user..userpassword = in the

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-12 Thread via GitHub
garydgregory commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2654960912 Ty @elecharny looking forward to what you find. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-12 Thread via GitHub
elecharny commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2654245461 I'll have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump org.apache.ftpserver:ftpserver-core from 1.2.0 to 1.2.1 [commons-net]

2025-02-07 Thread via GitHub
raboof commented on PR #327: URL: https://github.com/apache/commons-net/pull/327#issuecomment-2642728678 Authentication in the `FTPSClientTest` appears to have been broken. With `mvn -Pslf4j-simple test -Dtest="FTPSClientTest"`: Before: ``` >>testOpenClose 339023225 >>l