garydgregory commented on PR #327:
URL: https://github.com/apache/commons-net/pull/327#issuecomment-2657726063
Hm, if I apply this patch here:
```
diff --git a/pom.xml b/pom.xml
index 4a610fc..00f3990 100644
--- a/pom.xml
+++ b/pom.xml
@@ -123,7 +123,7 @@
<dependency>
<groupId>org.apache.ftpserver</groupId>
<artifactId>ftpserver-core</artifactId>
- <version>1.2.0</version>
+ <version>1.2.1</version>
<scope>test</scope>
</dependency>
<dependency>
diff --git a/src/test/java/org/apache/commons/net/ftp/AbstractFtpsTest.java
b/src/test/java/org/apache/commons/net/ftp/AbstractFtpsTest.java
index 88d7553..7cb1814 100644
--- a/src/test/java/org/apache/commons/net/ftp/AbstractFtpsTest.java
+++ b/src/test/java/org/apache/commons/net/ftp/AbstractFtpsTest.java
@@ -36,6 +36,7 @@
import org.apache.ftpserver.listener.ListenerFactory;
import org.apache.ftpserver.ssl.SslConfiguration;
import org.apache.ftpserver.ssl.SslConfigurationFactory;
+import org.apache.ftpserver.usermanager.Md5PasswordEncryptor;
import org.apache.ftpserver.usermanager.PropertiesUserManagerFactory;
import org.apache.ftpserver.usermanager.impl.BaseUser;
import org.junit.Assert;
@@ -90,6 +91,8 @@
SocketPort = 0;
final FtpServerFactory serverFactory = new FtpServerFactory();
final PropertiesUserManagerFactory propertiesUserManagerFactory =
new PropertiesUserManagerFactory();
+ // TODO Update to SHA512
+ propertiesUserManagerFactory.setPasswordEncryptor(new
Md5PasswordEncryptor());
final URL userPropsResource =
ClassLoader.getSystemClassLoader().getResource(userPropertiesResource);
Assert.assertNotNull(userPropertiesResource, userPropsResource);
propertiesUserManagerFactory.setUrl(userPropsResource);
diff --git
a/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java
b/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java
index f30db8c..c971780 100644
---
a/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java
+++
b/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java
@@ -50,7 +50,7 @@
}
@Override
- public String[] getEnabledProtocols() {
+ public String getEnabledProtocol() {
return null;
}
```
I get 503 errors from each test:
```
[ERROR] Tests run: 20, Failures: 0, Errors: 20, Skipped: 0, Time elapsed:
0.193 s <<< FAILURE! -- in org.apache.commons.net.ftp.FTPSClientTest
[ERROR]
org.apache.commons.net.ftp.FTPSClientTest.testOpenClose[endpointCheckingEnabled=false]
-- Time elapsed: 0.035 s <<< ERROR!
javax.net.ssl.SSLException:
550 Requested action not taken.
at org.apache.commons.net.ftp.FTPSClient.execAUTH(FTPSClient.java:409)
at
org.apache.commons.net.ftp.FTPSClient._connectAction_(FTPSClient.java:244)
at org.apache.commons.net.SocketClient._connect(SocketClient.java:142)
at org.apache.commons.net.SocketClient.connect(SocketClient.java:308)
at org.apache.commons.net.SocketClient.connect(SocketClient.java:290)
at
org.apache.commons.net.ftp.AbstractFtpsTest.loginClient(AbstractFtpsTest.java:175)
at
org.apache.commons.net.ftp.FTPSClientTest.testOpenClose(FTPSClientTest.java:181)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.lang.Thread.run(Thread.java:840)
```
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
