[jira] [Reopened] (IO-871) IOUtils.contentEquals is incorrect when InputStream.available under-reports

2025-03-24 Thread Jira
[ https://issues.apache.org/jira/browse/IO-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Éamonn McManus reopened IO-871: --- This issue may have been resolved, but I'm reopening it until I can verify. (This involves a long test run t

[jira] [Commented] (IO-866) Recent change to AbstractByteArrayOutputStream breaks source compatibility

2025-03-24 Thread Jira
[ https://issues.apache.org/jira/browse/IO-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937962#comment-17937962 ] Éamonn McManus commented on IO-866: --- Apologies, I accidentally commented on this issue when

Re: [PR] [COMPRESS-695] Ability to use different InputStreams for Zstd [commons-compress]

2025-03-24 Thread via GitHub
mehmet-karaman commented on code in PR #656: URL: https://github.com/apache/commons-compress/pull/656#discussion_r2010311572 ## src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java: ## @@ -186,7 +188,9 @@ public ZipFile get() throws IOException { * @sin

Re: [PR] [COMPRESS-695] Ability to use different InputStreams for Zstd [commons-compress]

2025-03-24 Thread via GitHub
mehmet-karaman commented on code in PR #656: URL: https://github.com/apache/commons-compress/pull/656#discussion_r2010295922 ## src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java: ## @@ -186,7 +188,9 @@ public ZipFile get() throws IOException { * @sin

Re: [PR] Improve performance of encoding URIs [commons-vfs]

2025-03-24 Thread via GitHub
garydgregory commented on PR #660: URL: https://github.com/apache/commons-vfs/pull/660#issuecomment-2748179515 @japplis I merged the PR. TY for your patience. Please test your use case with git master or a `2.11.0-SNAPSHOT` build from https://repository.apache.org/content/repositories

Re: [PR] Improve performance of encoding Uris [commons-vfs]

2025-03-24 Thread via GitHub
garydgregory merged PR #660: URL: https://github.com/apache/commons-vfs/pull/660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

[jira] [Commented] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Jaykumar Prajapati (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937894#comment-17937894 ] Jaykumar Prajapati commented on CODEC-327: -- Thank you for the feedback. I complet

[jira] [Comment Edited] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Jaykumar Prajapati (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937894#comment-17937894 ] Jaykumar Prajapati edited comment on CODEC-327 at 3/24/25 1:00 PM: -

[jira] [Comment Edited] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937888#comment-17937888 ] Gary D. Gregory edited comment on CODEC-327 at 3/24/25 12:51 PM: ---

[jira] [Commented] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937888#comment-17937888 ] Gary D. Gregory commented on CODEC-327: --- [~jay24]  Sure, but a word of caution: To

[jira] [Commented] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Jaykumar Prajapati (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937887#comment-17937887 ] Jaykumar Prajapati commented on CODEC-327: -- Hello [~ggregory], Could you please

[jira] [Commented] (JCS-241) Use System.Logger abstraction

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/JCS-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937886#comment-17937886 ] Gary D. Gregory commented on JCS-241: - bq. > What kind of incompatibilities? bq. Loads o

[jira] [Updated] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CODEC-327: -- Fix Version/s: (was: 1.18.0) > Refactor multiple classes for better readability and maintain

Re: [PR] IO-872: PathUtils.directoryAndFileContentEquals with different FileSystems [commons-io]

2025-03-24 Thread via GitHub
garydgregory commented on PR #732: URL: https://github.com/apache/commons-io/pull/732#issuecomment-2747981366 @dsmiley OK, sounds good. We'll be here 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Updated] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CODEC-327: -- Labels: (was: Refactoring improvement) > Refactor multiple classes for better readability and

[jira] [Updated] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CODEC-327: -- Priority: Trivial (was: Major) > Refactor multiple classes for better readability and maintaina

[jira] [Updated] (CODEC-327) Refactor multiple classes for better readability and maintainability

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated CODEC-327: -- Affects Version/s: (was: 1.18.0) > Refactor multiple classes for better readability and main

[jira] [Resolved] (LANG-1768) MutableLong and friends should provide better parsing exceptions Javadocs

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-1768. --- Fix Version/s: 3.18.0 Assignee: Gary D. Gregory Resolution: Fixed Hello [~sust

[jira] [Updated] (LANG-1768) MutableLong and friends should provide better parsing exceptions Javadocs

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1768: -- Summary: MutableLong and friends should provide better parsing exceptions Javadocs (was: Mutabl

[jira] [Updated] (LANG-1768) MutableLong and friends should document parsing exceptions better

2025-03-24 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1768: -- Summary: MutableLong and friends should document parsing exceptions better (was: Java Doc incon

Re: [PR] ArrayUtils makes extensive use of reflection [commons-lang]

2025-03-24 Thread via GitHub
garydgregory commented on PR #1365: URL: https://github.com/apache/commons-lang/pull/1365#issuecomment-2747945520 Hello @shraymoza -1: This looks to me like change for the sake of change. If you would like to help the project: - Look at Jira tickets for bugs to fix - Fix

Re: [PR] Consolidating duplicated add logic [commons-lang]

2025-03-24 Thread via GitHub
garydgregory commented on PR #1362: URL: https://github.com/apache/commons-lang/pull/1362#issuecomment-2747923982 Hello @shraymoza -1 here and I agree with the other comments. If you would like to help the project: - Look at Jira tickets for bugs to fix - Fix the fail

Re: [PR] Consolidating duplicated add logic [commons-lang]

2025-03-24 Thread via GitHub
garydgregory closed pull request #1362: Consolidating duplicated add logic URL: https://github.com/apache/commons-lang/pull/1362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]

2025-03-24 Thread via GitHub
garydgregory closed pull request #1363: encapsulating to avoid Deficient Encapsulation URL: https://github.com/apache/commons-lang/pull/1363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]

2025-03-24 Thread via GitHub
garydgregory commented on PR #1363: URL: https://github.com/apache/commons-lang/pull/1363#issuecomment-2747920571 Hello @shraymoza -1: This looks to me like change for the sake of change. If you would like to help the project: - Look at Jira tickets for bugs to fix -

Re: [PR] extracting duplicate logic to improve modularization [commons-lang]

2025-03-24 Thread via GitHub
garydgregory commented on PR #1364: URL: https://github.com/apache/commons-lang/pull/1364#issuecomment-2747919297 Hello @shraymoza -1: This looks to me like change for the sake of change. If you would like to help the project: - Look at Jira tickets for bugs to fix -

[jira] [Created] (LANG-1769) FastDateFormat.parse can not handle invalid input data

2025-03-24 Thread Wang Hailong (Jira)
Wang Hailong created LANG-1769: -- Summary: FastDateFormat.parse can not handle invalid input data Key: LANG-1769 URL: https://issues.apache.org/jira/browse/LANG-1769 Project: Commons Lang Issue T

Re: [PR] ArrayUtils makes extensive use of reflection [commons-lang]

2025-03-24 Thread via GitHub
ppkarwasz commented on PR #1365: URL: https://github.com/apache/commons-lang/pull/1365#issuecomment-2747868265 @shraymoza, Can you explain, what problem does this PR solve and what goals are you trying to achieve? -- This is an automated message from the Apache Git Service. To resp

Re: [PR] extracting duplicate logic to improve modularization [commons-lang]

2025-03-24 Thread via GitHub
ppkarwasz commented on PR #1364: URL: https://github.com/apache/commons-lang/pull/1364#issuecomment-2747863705 @shraymoza, Can you explain, what problem does this PR solve and what goals are you trying to achieve? -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Extracting the offset adjustment logic into its own method to improve readability and maintainability. [commons-lang]

2025-03-24 Thread via GitHub
garydgregory closed pull request #1360: Extracting the offset adjustment logic into its own method to improve readability and maintainability. URL: https://github.com/apache/commons-lang/pull/1360 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Extracting the offset adjustment logic into its own method to improve readability and maintainability. [commons-lang]

2025-03-24 Thread via GitHub
garydgregory commented on PR #1360: URL: https://github.com/apache/commons-lang/pull/1360#issuecomment-2747824459 Closing: See previous comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (JCS-241) Use System.Logger abstraction

2025-03-24 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/JCS-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937815#comment-17937815 ] Piotr Karwasz commented on JCS-241: --- {quote} That would require big changes because we hea

[PR] ArrayUtils makes extensive use of reflection [commons-lang]

2025-03-24 Thread via GitHub
shraymoza opened a new pull request, #1365: URL: https://github.com/apache/commons-lang/pull/1365 Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [ ] Read the [c

[PR] extracting duplicate logic to improve modularization [commons-lang]

2025-03-24 Thread via GitHub
shraymoza opened a new pull request, #1364: URL: https://github.com/apache/commons-lang/pull/1364 Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [ ] Read the [c

Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]

2025-03-24 Thread via GitHub
aherbert commented on PR #1363: URL: https://github.com/apache/commons-lang/pull/1363#issuecomment-2747213572 Removing a public field will break binary compatibility. Note that the field is **final** and encapsulation is not required. -- This is an automated message from the Apache Git Se

[PR] encapsulating to avoid Deficient Encapsulation [commons-lang]

2025-03-24 Thread via GitHub
shraymoza opened a new pull request, #1363: URL: https://github.com/apache/commons-lang/pull/1363 encapsulating to avoid Deficient Encapsulation Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull r