garydgregory commented on PR #1365: URL: https://github.com/apache/commons-lang/pull/1365#issuecomment-2747945520
Hello @shraymoza -1: This looks to me like change for the sake of change. If you would like to help the project: - Look at Jira tickets for bugs to fix - Fix the failing test(s) on Java 23 and up Other notes to consider when creating future PRs: - This PR adds new and public code without matching unit tests - The new code is redundant with the existing code - The new code has zero Javadoc - The new code calls Array.newInstance() and assumes the result can be null. When can this happen? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
