Re: [PATCH] Docs: dt: Be explicit and consistent in reference to IOMMU specifiers

2016-12-19 Thread Rob Herring
On Thu, Dec 15, 2016 at 06:16:13PM -0600, Stuart Yoder wrote: > The generic IOMMU binding says that the meaning of an 'IOMMU specifier' > is defined by the binding of a specific SMMU. The ARM SMMU binding > never explicitly uses the term 'specifier' at all. Update implicit > references to use the

Re: [RFC PATCH] iommu/arm-smmu: Add global SMR masking property

2016-12-20 Thread Rob Herring
On Fri, Dec 16, 2016 at 01:19:29PM +, Robin Murphy wrote: > The current SMR masking support using a 2-cell iommu-specifier is > primarily intended to handle individual masters with large and/or > complex Stream ID assignments; it quickly gets a bit clunky in other SMR > use-cases where we just

Re: [PATCH] iommu/ipmmu-vmsa: Add r8a7795 DT binding

2017-02-08 Thread Rob Herring
On Fri, Feb 03, 2017 at 04:10:30PM +0200, Laurent Pinchart wrote: > Hi Rob, > > On Monday 29 Feb 2016 23:33:09 Magnus Damm wrote: > > From: Magnus Damm > > > > Update the IPMMU DT binding documentation to include the r8a7795 compat > > string as well as the "renesas,ipmmu-main" property that on

Re: [PATCH 3/9] Docs: dt: document qcom iommu bindings

2017-03-02 Thread Rob Herring
On Wed, Mar 01, 2017 at 12:42:52PM -0500, Rob Clark wrote: Nit: use "dt-bindings: iommu: ..." for subject. And a commit message would be nice. > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Clark > --- > .../devicetree/bindings/iommu/qcom,iommu.txt | 106 > + >

Re: [PATCH V3 2/5] iommu/arm-smmu: Add support for MMU40x/500 clocks

2017-03-16 Thread Rob Herring
On Thu, Mar 09, 2017 at 09:05:45PM +0530, Sricharan R wrote: > The MMU400x/500 is the implementation of the SMMUv2 > arch specification. It is split in to two blocks > TBU, TCU. TBU caches the page table, instantiated > for each master locally, clocked by the TBUn_clk. > TCU manages the address tra

Re: [PATCH V3 3/5] drivers: arm-smmu: Add clock support for QCOM_SMMUV2

2017-03-16 Thread Rob Herring
On Thu, Mar 09, 2017 at 09:05:46PM +0530, Sricharan R wrote: > The QCOM_SMMUV2 is an implementation of the arm,smmu-v2 architecture. > The qcom,smmu is instantiated for each of the multimedia cores (for eg) > Venus (video encoder/decoder), mdp (display) etc, and they are connected > to the Multimed

Re: [PATCH 3/9] Docs: dt: document qcom iommu bindings

2017-03-23 Thread Rob Herring
On Tue, Mar 14, 2017 at 11:18:05AM -0400, Rob Clark wrote: > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Clark > --- > .../devicetree/bindings/iommu/qcom,iommu.txt | 113 > + > 1 file changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bind

Re: [RFC PATCH 3/3] of: fix node traversing in of_dma_get_range

2017-03-27 Thread Rob Herring
On Sat, Mar 25, 2017 at 12:31 AM, Oza Pawandeep wrote: > it jumps to the parent node without examining the child node. > also with that, it throws "no dma-ranges found for node" > for pci dma-ranges. > > this patch fixes device node traversing for dma-ranges. What's the DT look like that doesn't

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-27 Thread Rob Herring
On Sat, Mar 25, 2017 at 12:31 AM, Oza Pawandeep wrote: > it is possible that PCI device supports 64-bit DMA addressing, > and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), > however PCI host bridge may have limitations on the inbound > transaction addressing. As an example, consider

Re: [PATCH 3/9] Docs: dt: document qcom iommu bindings

2017-03-27 Thread Rob Herring
On Thu, Mar 23, 2017 at 9:45 PM, Rob Clark wrote: > On Thu, Mar 23, 2017 at 6:21 PM, Rob Herring wrote: >> On Tue, Mar 14, 2017 at 11:18:05AM -0400, Rob Clark wrote: >>> Cc: devicet...@vger.kernel.org >>> Signed-off-by: Rob Clark >>> --- >>>

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-28 Thread Rob Herring
On Tue, Mar 28, 2017 at 12:27 AM, Oza Oza wrote: > On Mon, Mar 27, 2017 at 8:16 PM, Rob Herring wrote: >> On Sat, Mar 25, 2017 at 12:31 AM, Oza Pawandeep wrote: >>> it is possible that PCI device supports 64-bit DMA addressing, >>> and thus it's driver sets devi

Re: [V9, 07/11] iommu: of: Handle IOMMU lookup failure with deferred probing or error

2017-03-28 Thread Rob Herring
On Fri, Mar 10, 2017 at 12:30:57AM +0530, Sricharan R wrote: > From: Laurent Pinchart > > Failures to look up an IOMMU when parsing the DT iommus property need to > be handled separately from the .of_xlate() failures to support deferred > probing. > > The lack of a registered IOMMU can be caused

Re: [PATCH V10 00/12] IOMMU probe deferral support

2017-04-04 Thread Rob Herring
> bus/driver is called. Similarly dma_deconfigure is called during > device/driver_detach path. For patches 3, 4, 6, 7, 8: Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Rob Herring
On Thu, Apr 6, 2017 at 5:24 AM, Robin Murphy wrote: > On 06/04/17 08:01, Frank Rowand wrote: >> On 04/04/17 03:18, Sricharan R wrote: >>> Size of the dma-range is calculated as coherent_dma_mask + 1 >>> and passed to arch_setup_dma_ops further. It overflows when >>> the coherent_dma_mask is set fo

Re: [RFC PATH] of/pci/dma: fix DMA configruation for PCI masters

2017-04-24 Thread Rob Herring
On Sat, Apr 22, 2017 at 3:08 AM, Oza Pawandeep wrote: > current device frmework and of framework integration assumes dma-ranges > in a way where memory-mapped devices define their dma-ranges. > dma-ranges: (child-bus-address, parent-bus-address, length). > > but iproc based SOCs and other SOCs(suc

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-03 Thread Rob Herring
On Tue, May 2, 2017 at 11:46 PM, Oza Pawandeep wrote: > current device framework and of framework integration assumes > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). > > of_dma_configure is specifically written to take c

Re: [PATCH 3/3] PCI/of fix of_dma_get_range; get PCI specific dma-ranges

2017-05-03 Thread Rob Herring
On Tue, May 2, 2017 at 11:46 PM, Oza Pawandeep wrote: > current device framework and of framework integration assumes > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). > > of_dma_configure is specifically written to take c

Re: [PATCH 3/4] iommu: add qcom_iommu

2017-05-04 Thread Rob Herring
On Thu, May 4, 2017 at 8:34 AM, Rob Clark wrote: > An iommu driver for Qualcomm "B" family devices which do not completely > implement the ARM SMMU spec. These devices have context-bank register > layout that is similar to ARM SMMU, but no global register space (or at > least not one that is acce

Re: [PATCH] iommu: add qcom_iommu

2017-05-05 Thread Rob Herring
On Fri, May 5, 2017 at 1:21 PM, Rob Clark wrote: > An iommu driver for Qualcomm "B" family devices which do not completely > implement the ARM SMMU spec. These devices have context-bank register > layout that is similar to ARM SMMU, but no global register space (or at > least not one that is acce

Re: [PATCH] iommu: add qcom_iommu

2017-05-05 Thread Rob Herring
On Fri, May 5, 2017 at 2:37 PM, Rob Clark wrote: > On Fri, May 5, 2017 at 3:04 PM, Rob Herring wrote: >> On Fri, May 5, 2017 at 1:21 PM, Rob Clark wrote: >>> An iommu driver for Qualcomm "B" family devices which do not completely >>> implement the ARM SMMU s

Re: [PATCH 1/4] Docs: dt: document qcom iommu bindings

2017-05-08 Thread Rob Herring
umentation/devicetree/bindings/iommu/qcom,iommu.txt Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC v1 3/7] iommu/arm-smmu-v3: Replace the device tree binding for hisilicon broken prefetch cmd with erratum id

2017-05-15 Thread Rob Herring
On Sat, May 13, 2017 at 4:47 AM, shameer wrote: > Signed-off-by: shameer > --- > Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt > b/Documentation/devicetree/

Re: [v6 2/3] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #74

2017-05-15 Thread Rob Herring
DT changes should go to DT list. On Fri, May 12, 2017 at 7:41 AM, Geetha sowjanya wrote: > From: Linu Cherian > > Cavium ThunderX2 SMMU implementation doesn't support page 1 register space > and PAGE0_REGS_ONLY option is enabled as an errata workaround. > This option when turned on, replaces all

Re: [PATCH 2/7] dt-bindings: PCI: Describe ATS property for root complex nodes

2017-05-31 Thread Rob Herring
On Tue, May 30, 2017 at 11:58:50AM +0100, Jean-Philippe Brucker wrote: > On 30/05/17 11:01, Joerg Roedel wrote: > > On Wed, May 24, 2017 at 07:01:38PM +0100, Jean-Philippe Brucker wrote: > >> +- ats-supported: if present, the root complex supports the Address > >> + Translation Service (ATS). It i

Re: [PATCH 2/7] dt-bindings: PCI: Describe ATS property for root complex nodes

2017-05-31 Thread Rob Herring
On Wed, May 24, 2017 at 07:01:38PM +0100, Jean-Philippe Brucker wrote: > Address Translation Service (ATS) is an extension to PCIe allowing > endpoints to manage their own IOTLB, called Address Translation Cache > (ATC). Instead of having every memory transaction processed by the IOMMU, > the endpo

Re: [PATCH 2/7] dt-bindings: PCI: Describe ATS property for root complex nodes

2017-06-05 Thread Rob Herring
On Thu, Jun 01, 2017 at 01:28:01PM +0100, Jean-Philippe Brucker wrote: > On 31/05/17 18:23, Rob Herring wrote: > > On Wed, May 24, 2017 at 07:01:38PM +0100, Jean-Philippe Brucker wrote: > >> Address Translation Service (ATS) is an extension to PCIe allowing > >> endpoint

Re: [PATCH V4 5/6] iommu/arm-smmu: Add support for MMU40x/500 clocks

2017-07-09 Thread Rob Herring
On Thu, Jul 06, 2017 at 03:07:04PM +0530, Vivek Gautam wrote: > From: Sricharan R > > The MMU400x/500 is the implementation of the SMMUv2 > arch specification. It is split in to two blocks > TBU, TCU. TBU caches the page table, instantiated > for each master locally, clocked by the TBUn_clk. > TC

Re: [PATCH V4 6/6] iommu/arm-smmu: Add support for qcom,msm8996-smmu-v2 clocks

2017-07-09 Thread Rob Herring
On Thu, Jul 06, 2017 at 03:07:05PM +0530, Vivek Gautam wrote: > qcom,msm8996-smmu-v2 is an arm,smmu-v2 implementation with > specific clock and power requirements. This smmu core is used > with multiple masters on msm8996, viz. mdss, video, etc. > Add bindings for the same. > > Signed-off-by: Vive

[PATCH] iommu: Convert to using %pOF instead of full_name

2017-07-18 Thread Rob Herring
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring Cc: Joerg Roedel Cc: Heiko Stuebner Cc: iommu@lists.linux-foundation.org Cc: linux-arm-ker

Re: [PATCH] documentation: iommu: add description of ARM System MMU binding

2013-04-05 Thread Rob Herring
On 04/04/2013 11:50 AM, Will Deacon wrote: > This patch adds a description of the device tree binding for the ARM > System MMU architecture. > > Cc: Rob Herring > Cc: Andreas Herrmann > Signed-off-by: Will Deacon > --- > > Hello, > > The driver for this

Re: [PATCH] documentation: iommu: add description of ARM System MMU binding

2013-04-05 Thread Rob Herring
On 04/05/2013 11:57 AM, Will Deacon wrote: > Hi Rob, > > On Fri, Apr 05, 2013 at 05:43:06PM +0100, Rob Herring wrote: [...] >>> +- compatible: Should be one of "arm,smmu-v1" or "arm,smmu-v2" >>> +

Re: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-07-27 Thread Rob Herring
On Fri, Jul 26, 2013 at 6:28 AM, Cho KyongHo wrote: > Signed-off-by: Cho KyongHo > --- > .../bindings/iommu/samsung,exynos4210-sysmmu.txt | 103 +++ > arch/arm/boot/dts/exynos4.dtsi | 122 > arch/arm/boot/dts/exynos4210.dtsi | 25 ++ > arch

Re: [PATCH 6/6] iommu/arm-smmu: Support buggy implemenations where all config accesses are secure

2013-10-01 Thread Rob Herring
On 10/01/2013 07:39 AM, Andreas Herrmann wrote: > In such a case we have to use secure aliases of some non-secure > registers. > > This behaviour is controlled via a flag in smmu->bugs. It is set > based on DT information when probing an SMMU device. Perhaps quirks would be a nicer word... > >

Re: [PATCH v8 06/12] ARM: dts: Add description of System MMU of Exynos SoCs

2013-10-07 Thread Rob Herring
On Fri, Jul 26, 2013 at 6:28 AM, Cho KyongHo wrote: > Signed-off-by: Cho KyongHo > --- > .../bindings/iommu/samsung,exynos4210-sysmmu.txt | 103 +++ > arch/arm/boot/dts/exynos4.dtsi | 122 > arch/arm/boot/dts/exynos4210.dtsi | 25 ++ > arch

Re: [PATCH 3/5] iommu/arm-smmu: Introduce stream ID masking

2013-10-08 Thread Rob Herring
On 10/08/2013 11:59 AM, Will Deacon wrote: > On Tue, Oct 08, 2013 at 05:40:21PM +0100, Andreas Herrmann wrote: >> On Tue, Oct 08, 2013 at 05:20:08PM +0200, Andreas Herrmann wrote: >> To be more specific: For SATA I'd need to specify 10 StreamIds. This >> would >> >> (1) exceed MAX_MASTER_STREAMIDS

Re: [PATCH 6/6] documentation/iommu: Update description of ARM System MMU binding

2013-10-30 Thread Rob Herring
On Wed, Oct 30, 2013 at 8:17 PM, Will Deacon wrote: > On Fri, Oct 18, 2013 at 09:13:15PM +0100, Andreas Herrmann wrote: >> This patch adds descriptions fore new properties of device tree >> binding for the ARM SMMU architecture. These properties control >> arm-smmu driver o

Re: Report from 2013 ARM kernel summit

2013-11-19 Thread Rob Herring
On 11/19/2013 11:35 AM, Will Deacon wrote: > On Tue, Nov 19, 2013 at 09:40:54AM +, Hiroshi Doyu wrote: >> Grant Likely wrote @ Fri, 15 Nov 2013 08:06:27 >> +0100: >>> On Mon, 11 Nov 2013 10:47:23 +0100, Hiroshi Doyu wrote: 1, When a device is populated, it checks if that device is IOMMU

Re: Report from 2013 ARM kernel summit

2013-11-20 Thread Rob Herring
On Wed, Nov 20, 2013 at 7:53 AM, Thierry Reding wrote: > On Wed, Nov 20, 2013 at 10:31:11AM +, Will Deacon wrote: >> On Tue, Nov 19, 2013 at 08:45:02PM +0000, Rob Herring wrote: >> > On 11/19/2013 11:35 AM, Will Deacon wrote: >> > > Adding Andreas and Rob

Re: Report from 2013 ARM kernel summit

2013-11-20 Thread Rob Herring
On Wed, Nov 20, 2013 at 12:39 AM, Hiroshi Doyu wrote: > Hi Rob, > > Rob Herring wrote @ Tue, 19 Nov 2013 21:45:02 +0100: > >> On 11/19/2013 11:35 AM, Will Deacon wrote: >> > On Tue, Nov 19, 2013 at 09:40:54AM +, Hiroshi Doyu wrote: >> >> Grant Likely w

Re: Report from 2013 ARM kernel summit

2013-11-20 Thread Rob Herring
On Wed, Nov 20, 2013 at 4:31 AM, Will Deacon wrote: > On Tue, Nov 19, 2013 at 08:45:02PM +0000, Rob Herring wrote: >> On 11/19/2013 11:35 AM, Will Deacon wrote: >> > Adding Andreas and Rob for input on potential binding additions to the >> > SMMU. >>

Re: [PATCHv5 1/9] of: introduce of_property_for_earch_phandle_with_args()

2013-11-21 Thread Rob Herring
On Thu, Nov 21, 2013 at 11:20 AM, Hiroshi Doyu wrote: > Grant Likely wrote @ Thu, 21 Nov 2013 16:56:49 > +0100: > >> On Thu, 21 Nov 2013 15:12:18 +0200, Hiroshi Doyu wrote: >> > On Thu, 21 Nov 2013 13:43:28 +0100 >> > Grant Likely wrote: >> > >> > > On Tue, 19 Nov 2013 11:33:05 +0200, Hiroshi

Re: [RFC][PATCHv6+++ 01/13] of: introduce of_property_for_earch_phandle_with_args()

2013-12-02 Thread Rob Herring
On Mon, Dec 2, 2013 at 5:02 AM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Sun, 1 Dec 2013 20:00:09 +0100: > >> On 11/29/2013 04:46 AM, Hiroshi Doyu wrote: >> ... >> > Iterating over a property containing a list of phandles with arguments >> > is a common operation for device drivers. This patc

Re: [PATCH 09/11] ARM: dts: Add nodes for SMMUs on Calxeda ECX-2000

2014-01-16 Thread Rob Herring
On Thu, Jan 16, 2014 at 6:44 AM, Andreas Herrmann wrote: > Cc: Rob Herring > Cc: Andreas Herrmann > Signed-off-by: Andreas Herrmann One minor comment, but otherwise: Acked-by: Rob Herring > --- > arch/arm/boot/dts/ecx-2000.dts| 44 > +++

Re: [PATCH 08/11] of: Increase MAX_PHANDLE_ARGS

2014-01-16 Thread Rob Herring
t Calxeda ECX-2000 hardware arm-smmu driver requires a > slightly higher value for MAX_PHANDLE_ARGS as this hardware has 10 > stream IDs for one master device. > > Cc: Grant Likely > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Cc: Andreas Herrmann > Signed-off-by

Re: [PATCH 06/11] documentation/iommu: Update description of ARM System MMU binding

2014-01-16 Thread Rob Herring
On Thu, Jan 16, 2014 at 6:44 AM, Andreas Herrmann wrote: > This patch adds descriptions fore new properties of device tree > binding for the ARM SMMU architecture. These properties control > arm-smmu driver options. > > Cc: Rob Herring > Cc: Grant Likely > Cc: Will

Re: [PATCH v2 08/11] of: Increase MAX_PHANDLE_ARGS

2014-01-29 Thread Rob Herring
sing it to 16 seems a reasonable choice. >> >> Cc: Grant Likely >> Cc: Rob Herring >> Cc: devicet...@vger.kernel.org >> Cc: Andreas Herrmann >> Acked-by: Rob Herring >> Signed-off-by: Andreas Herrmann >> --- >> include/linux/of.h |2

Re: [PATCH v2 08/11] of: Increase MAX_PHANDLE_ARGS

2014-01-31 Thread Rob Herring
On Thu, Jan 30, 2014 at 11:45 AM, Andreas Herrmann wrote: > On Wed, Jan 29, 2014 at 12:26:35PM -0500, Suravee Suthikulanit wrote: >> On 1/29/2014 11:16 AM, Andreas Herrmann wrote: >> > On Wed, Jan 29, 2014 at 11:59:12AM -0500, Suravee Suthikulanit wrote: >> >> On 1

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Rob Herring
On Fri, May 23, 2014 at 3:33 PM, Thierry Reding wrote: > From: Thierry Reding > > This commit introduces a generic device tree binding for IOMMU devices. > Only a very minimal subset is described here, but it is enough to cover > the requirements of both the Exynos System MMU and Tegra SMMU as >

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Rob Herring
On Fri, May 30, 2014 at 2:06 PM, Arnd Bergmann wrote: > On Friday 30 May 2014 08:16:05 Rob Herring wrote: >> On Fri, May 23, 2014 at 3:33 PM, Thierry Reding >> wrote: >> > From: Thierry Reding >> > +IOMMU master node: >> > +== >>

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-30 Thread Rob Herring
> >> I think there weren't any comments left for me to address and I've >> mostly been waiting for Joerg to pick it up. >> >> Joerg, can you take this through the iommu tree for 3.17? Will acked >> this, but perhaps you were waiting for an ACK from th

Re: [PATCH v4 1/2] dt-bindings: arm-smmu: Add binding doc for Qcom smmu-500

2018-10-11 Thread Rob Herring
> --- > > Changes since v3: > - Refined language more to state things directly for the bindings >description. > > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring _

Re: [PATCH v3 1/7] dt-bindings: virtio-mmio: Add IOMMU description

2018-10-17 Thread Rob Herring
n. > > Signed-off-by: Jean-Philippe Brucker > --- > .../devicetree/bindings/virtio/mmio.txt | 30 +++ > 1 file changed, 30 insertions(+) One nit, otherwise, Reviewed-by: Rob Herring > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.txt > b/Do

Re: [PATCH v3 2/7] dt-bindings: virtio: Add virtio-pci-iommu node

2018-10-17 Thread Rob Herring
t; create mode 100644 Documentation/devicetree/bindings/virtio/iommu.txt > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 3/4] dt-bindings: iommu/arm, smmu: add compatible string for Marvell

2018-10-18 Thread Rob Herring
On Mon, Oct 15, 2018 at 02:11:52PM +0100, Robin Murphy wrote: > On 15/10/18 13:00, han...@marvell.com wrote: > > From: Hanna Hawa > > > > Add specific compatible string for Marvell usage due errata of > > accessing 64bit registers of ARM SMMU, in AP806. > > > > AP806 SOC use the generic ARM-MMU5

Re: [PATCH] of/device: Really only set bus DMA mask when appropriate

2018-11-07 Thread Rob Herring
On Wed, Nov 07, 2018 at 12:56:49PM +, Robin Murphy wrote: > On 2018-11-07 8:03 am, Christoph Hellwig wrote: > > On Tue, Nov 06, 2018 at 11:54:15AM +, Robin Murphy wrote: > > > of_dma_configure() was *supposed* to be following the same logic as > > > acpi_dma_configure() and only setting bus

Re: [PATCH v2] of/device: Really only set bus DMA mask when appropriate

2018-11-07 Thread Rob Herring
On Wed, Nov 07, 2018 at 04:30:32PM +, Robin Murphy wrote: > of_dma_configure() was *supposed* to be following the same logic as > acpi_dma_configure() and only setting bus_dma_mask if some range was > specified by the firmware. However, it seems that subtlety got lost in > the process of fittin

Re: [PATCH v4 3/7] of: Allow the iommu-map property to omit untranslated devices

2018-11-16 Thread Rob Herring
t; pci_msi_setup_msi_irqs() will return an error when attempting to find the > device's MSI domain. > > Signed-off-by: Jean-Philippe Brucker > --- > drivers/of/base.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-04 Thread Rob Herring
On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > This solves a problem we see with drm/msm, caused by getting > iommu_dma_ops while we attach our own domain and manage it directly at > the iommu API level: > > [0038] user address but active_mm is swapper > Internal error: Oops:

Re: [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW

2019-01-11 Thread Rob Herring
ree/bindings/media/mediatek-mdp.txt | 8 > Documentation/devicetree/bindings/media/mediatek-vcodec.txt | 4 > 4 files changed, 25 deletions(-) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH] iommu: Allow io-pgtable to be used outside of drivers/iommu/

2019-02-05 Thread Rob Herring
: Matthias Brugger Cc: Rob Clark Cc: linux-arm-ker...@lists.infradead.org Cc: iommu@lists.linux-foundation.org Cc: linux-media...@lists.infradead.org Cc: linux-arm-...@vger.kernel.org Signed-off-by: Rob Herring --- This will be needed for an in-progress Mali GPU DRM driver. It's using the page

Re: [PATCH] iommu: Allow io-pgtable to be used outside of drivers/iommu/

2019-02-05 Thread Rob Herring
On Tue, Feb 5, 2019 at 10:55 AM Christoph Hellwig wrote: > > On Tue, Feb 05, 2019 at 10:37:31AM -0600, Rob Herring wrote: > > Move io-pgtable.h to include/linux/ and export alloc_io_pgtable_ops > > and free_io_pgtable_ops. This enables drivers outside drivers/iommu/ to > >

Re: [PATCH 04/12] of: select OF_RESERVED_MEM automatically

2019-02-12 Thread Rob Herring
/powerpc/Kconfig | 1 - > arch/xtensa/Kconfig | 1 - > drivers/of/Kconfig | 5 ++--- > 7 files changed, 2 insertions(+), 9 deletions(-) Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 03/12] of: mark early_init_dt_alloc_reserved_memory_arch static

2019-02-12 Thread Rob Herring
d_mem.h | 7 --- > 2 files changed, 1 insertion(+), 8 deletions(-) Reviewed-by: Rob Herring Looks like this one isn't a dependency, so I can take it if you want. Rob ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linu

Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability

2019-02-12 Thread Rob Herring
On Mon, Feb 11, 2019 at 7:37 AM Christoph Hellwig wrote: > > This API is primarily used through DT entries, but two architectures > and two drivers call it directly. So instead of selecting the config > symbol for random architectures pull it in implicitly for the actual > users. Also rename the

Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability

2019-02-13 Thread Rob Herring
On Wed, Feb 13, 2019 at 12:24 PM Christoph Hellwig wrote: > > On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > index 3607fd2810e4..f8c66a9472a4 100644 > > > --- a/drivers/of/Kconf

Re: [PATCH v6 01/22] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI

2019-02-18 Thread Rob Herring
ndings/iommu/mediatek,iommu.txt | 30 - > .../memory-controllers/mediatek,smi-common.txt | 12 +- > .../memory-controllers/mediatek,smi-larb.txt | 4 + > include/dt-bindings/memory/mt8183-larb-port.h | 130 > + > 4 files changed, 170 insertions(+), 6 deletions(-) > create mode 100644 include/dt-bindings/memory/mt8183-larb-port.h > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH] iommu: Add a quirk for ARM Mali midgard MMU

2019-02-26 Thread Rob Herring
linux-foundation.org Signed-off-by: Rob Herring --- drivers/iommu/io-pgtable-arm.c | 51 ++ include/linux/io-pgtable.h | 4 +++ 2 files changed, 37 insertions(+), 18 deletions(-) diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c index d3700ec

Re: [PATCH] iommu: Add a quirk for ARM Mali midgard MMU

2019-02-26 Thread Rob Herring
On Tue, Feb 26, 2019 at 1:25 PM Robin Murphy wrote: > > Hi Rob, > > On 26/02/2019 18:17, Rob Herring wrote: > > ARM Mali midgard GPUs have a few differences from standard 64-bit > > stage 1 page tables. > > > > The 3rd level page entry bits are 0x1 instead

[PATCH v2] iommu: io-pgtable: Add ARM Mali midgard MMU page table format

2019-02-27 Thread Rob Herring
ists.linux-foundation.org Signed-off-by: Rob Herring --- Robin, Hopefully this is what you had in mind. drivers/iommu/io-pgtable-arm.c | 70 +++--- drivers/iommu/io-pgtable.c | 1 + include/linux/io-pgtable.h | 2 + 3 files changed, 59 insertions(+), 14 deletions(-)

Re: [PATCH v2] iommu: io-pgtable: Add ARM Mali midgard MMU page table format

2019-03-04 Thread Rob Herring
On Fri, Mar 1, 2019 at 10:28 AM Robin Murphy wrote: > > On 27/02/2019 23:22, Rob Herring wrote: > > ARM Mali midgard GPU page tables are similar to standard 64-bit stage 1 > > page tables, but have a few differences. Add a new format type to > > represent the format. The

Re: [PATCH v2] iommu: io-pgtable: Add ARM Mali midgard MMU page table format

2019-03-04 Thread Rob Herring
On Mon, Mar 4, 2019 at 11:31 AM Robin Murphy wrote: > > On 04/03/2019 15:32, Rob Herring wrote: > > On Fri, Mar 1, 2019 at 10:28 AM Robin Murphy wrote: > >> > >> On 27/02/2019 23:22, Rob Herring wrote: > >>> ARM Mali midgard GPU page tables are sim

[RFC PATCH 07/11] net: Remove Calxeda XGMAC driver

2020-02-18 Thread Rob Herring
Cc: "David S. Miller" Cc: net...@vger.kernel.org Signed-off-by: Rob Herring --- Do not apply yet. drivers/net/ethernet/Kconfig |1 - drivers/net/ethernet/Makefile |1 - drivers/net/ethernet/calxeda/Kconfig |9 - drivers/net/ethernet/calxeda/Makef

[RFC PATCH 04/11] cpufreq: Remove Calxeda driver

2020-02-18 Thread Rob Herring
Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org Signed-off-by: Rob Herring --- Do not apply yet. drivers/cpufreq/Kconfig.arm | 10 --- drivers/cpufreq/Makefile | 3 +- drivers/cpufreq/cpufreq-dt-platdev.c | 3 - drivers/cpufre

[RFC PATCH 05/11] EDAC: Remove Calxeda drivers

2020-02-18 Thread Rob Herring
Cc: Borislav Petkov Cc: Mauro Carvalho Chehab Cc: Tony Luck Cc: James Morse Cc: Robert Richter Cc: linux-e...@vger.kernel.org Signed-off-by: Rob Herring --- Do not apply yet. MAINTAINERS | 6 - drivers/edac/Kconfig| 14 -- drivers/edac/Makefile

[RFC PATCH 00/11] Removing Calxeda platform support

2020-02-18 Thread Rob Herring
y don't exactly match what's shipping in firmware). Rob [1] https://lore.kernel.org/linux-arm-kernel/20200210141324.21090-1-...@kernel.org/ Rob Herring (11): vfio: Remove Calxeda XGMAC reset driver ata: Remove Calxeda AHCI driver cpuidle: Remove Calxeda driver cpufreq: Rem

[RFC PATCH 08/11] clk: Remove Calxeda driver

2020-02-18 Thread Rob Herring
Cc: Stephen Boyd Cc: linux-...@vger.kernel.org Signed-off-by: Rob Herring --- Do not apply yet. drivers/clk/Makefile | 1 - drivers/clk/clk-highbank.c | 329 - 2 files changed, 330 deletions(-) delete mode 100644 drivers/clk/clk-highbank.c diff

[RFC PATCH 03/11] cpuidle: Remove Calxeda driver

2020-02-18 Thread Rob Herring
Cc: "Rafael J. Wysocki" Cc: Daniel Lezcano Cc: linux...@vger.kernel.org Signed-off-by: Rob Herring --- Do not apply yet. drivers/cpuidle/Kconfig.arm | 7 --- drivers/cpuidle/Makefile | 1 - drivers/cpuidle/cpuidle-calxeda.c | 72 --

[RFC PATCH 09/11] ARM: Remove Calxeda platform support

2020-02-18 Thread Rob Herring
Signed-off-by: Rob Herring --- MAINTAINERS | 8 -- arch/arm/Kconfig| 2 - arch/arm/Kconfig.debug | 12 +- arch/arm/Makefile | 1 - arch/arm/configs/multi_v7_defconfig | 5 - arch/arm/mach-highbank/Kconfig

[RFC PATCH 02/11] ata: Remove Calxeda AHCI driver

2020-02-18 Thread Rob Herring
Cc: Jens Axboe Cc: linux-...@vger.kernel.org Signed-off-by: Rob Herring --- Do not apply yet. drivers/ata/Kconfig | 9 - drivers/ata/Makefile| 1 - drivers/ata/sata_highbank.c | 635 3 files changed, 645 deletions(-) delete mode 100644

[RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk

2020-02-18 Thread Rob Herring
Cc: Will Deacon Cc: Robin Murphy Cc: Joerg Roedel Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- Do not apply yet. drivers/iommu/arm-smmu-impl.c | 43 --- 1 file changed, 43 deletions(-) diff --git a/drivers/iommu/arm-smmu-impl.c b

[RFC PATCH 11/11] dt-bindings: Remove Calxeda platforms bindings

2020-02-18 Thread Rob Herring
Cc: devicet...@vger.kernel.org Signed-off-by: Rob Herring --- .../devicetree/bindings/arm/calxeda.yaml | 22 -- .../devicetree/bindings/arm/calxeda/l2ecc.txt | 15 --- .../devicetree/bindings/ata/sata_highbank.txt | 44 --- .../devicetree/bindings/clock

[RFC PATCH 01/11] vfio: Remove Calxeda XGMAC reset driver

2020-02-18 Thread Rob Herring
Cc: Eric Auger Cc: Alex Williamson Cc: Cornelia Huck Cc: k...@vger.kernel.org Signed-off-by: Rob Herring --- Do not apply yet. drivers/vfio/platform/reset/Kconfig | 8 -- drivers/vfio/platform/reset/Makefile | 2 - .../reset/vfio_platform_calxedaxgmac.c| 74

[RFC PATCH 10/11] ARM: dts: Remove Calxeda platforms

2020-02-18 Thread Rob Herring
Cc: devicet...@vger.kernel.org Signed-off-by: Rob Herring --- arch/arm/boot/dts/Makefile| 3 - arch/arm/boot/dts/ecx-2000.dts| 103 - arch/arm/boot/dts/ecx-common.dtsi | 230 -- arch/arm/boot/dts/highbank.dts| 161 - 4

Re: [RFC PATCH 11/11] dt-bindings: Remove Calxeda platforms bindings

2020-02-18 Thread Rob Herring
On Tue, Feb 18, 2020 at 11:23 AM Will Deacon wrote: > > On Tue, Feb 18, 2020 at 11:13:21AM -0600, Rob Herring wrote: > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > .../devicetree/bindings/arm/calxeda.yaml | 22 -- &g

Re: [RFC PATCH 00/11] Removing Calxeda platform support

2020-02-18 Thread Rob Herring
On Tue, Feb 18, 2020 at 12:14 PM Andre Przywara wrote: > > On Tue, 18 Feb 2020 11:13:10 -0600 > Rob Herring wrote: > > Hi, > > > Calxeda has been defunct for 6 years now. Use of Calxeda servers carried > > on for some time afterwards primarily as distro builders fo

Re: [PATCH 01/11] dt-bindings: PCI: generic: Add ats-supported property

2020-02-19 Thread Rob Herring
--- > Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2] iommu/arm-smmu-v3: Add SMMUv3.2 range invalidation support

2020-02-20 Thread Rob Herring
On Mon, Feb 17, 2020 at 1:17 PM Robin Murphy wrote: > > On 13/02/2020 9:49 pm, Rob Herring wrote: > > On Thu, Jan 30, 2020 at 11:34 AM Robin Murphy wrote: > >> > >> On 30/01/2020 3:06 pm, Auger Eric wrote: > >>> Hi Rob, > >>> On 1/17/20

Re: [PATCH v2] iommu/arm-smmu-v3: Add SMMUv3.2 range invalidation support

2020-02-21 Thread Rob Herring
On Fri, Feb 21, 2020 at 10:19 AM Robin Murphy wrote: > > On 20/02/2020 5:54 pm, Rob Herring wrote: > > On Mon, Feb 17, 2020 at 1:17 PM Robin Murphy wrote: > >> > >> On 13/02/2020 9:49 pm, Rob Herring wrote: > >>> On Thu, Jan 30, 2020 at 11:34 AM Robin Mu

[PATCH v3] iommu/arm-smmu-v3: Add SMMUv3.2 range invalidation support

2020-02-24 Thread Rob Herring
-off-by: Rob Herring --- v3: - Use inv_range local instead of modifying granule - Simplify the TG calculation - Use shift instead of divide by power of 2. --- drivers/iommu/arm-smmu-v3.c | 69 +++-- 1 file changed, 67 insertions(+), 2 deletions(-) diff --git a

Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk

2020-02-25 Thread Rob Herring
On Tue, Feb 18, 2020 at 11:20 AM Will Deacon wrote: > > On Tue, Feb 18, 2020 at 11:13:16AM -0600, Rob Herring wrote: > > Cc: Will Deacon > > Cc: Robin Murphy > > Cc: Joerg Roedel > > Cc: iommu@lists.linux-foundation.org > > Signed-off-by: Rob H

Re: [PATCH v3] iommu/arm-smmu-v3: Add SMMUv3.2 range invalidation support

2020-03-19 Thread Rob Herring
On Wed, Mar 18, 2020 at 4:19 PM Will Deacon wrote: > > Hi Rob, > > On Mon, Feb 24, 2020 at 04:31:29PM -0600, Rob Herring wrote: > > Arm SMMUv3.2 adds support for TLB range invalidate operations. > > Support for range invalidate is determined by the RIL bit in the IDR3 &

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom: Add iommus property

2020-03-30 Thread Rob Herring
changed, 3 insertions(+) > Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] dt-bndings: iommu: renesas,ipmmu-vmsa: convert to json-schema

2020-04-20 Thread Rob Herring
On Mon, Apr 13, 2020 at 07:25:33PM +0900, Yoshihiro Shimoda wrote: > Convert Renesas VMSA-Compatible IOMMU bindings documentation > to json-schema. > > Signed-off-by: Yoshihiro Shimoda > --- > .../bindings/iommu/renesas,ipmmu-vmsa.txt | 73 -- > .../bindings/iommu/renesa

Re: [PATCH] of_device: removed #include that caused a recursion in included headers

2020-04-20 Thread Rob Herring
On Mon, Apr 13, 2020 at 04:35:53PM +0300, Hadar Gat wrote: > Both of_platform.h and of_device.h were included each other. > In of_device.h, removed unneeded #include to of_platform.h > and added include to of_platform.h in the files that needs it. Guess we forgot about that temporary comment! Bot

Re: [PATCH v5] dt-bindings: iommu: renesas,ipmmu-vmsa: convert to json-schema

2020-05-05 Thread Rob Herring
On Tue, 21 Apr 2020 14:15:52 +0900, Yoshihiro Shimoda wrote: > Convert Renesas VMSA-Compatible IOMMU bindings documentation > to json-schema. > > Note that original documentation doesn't mention renesas,ipmmu-vmsa > for R-Mobile APE6. But, R-Mobile APE6 is similar to the R-Car > Gen2. So, renesas,

Re: [PATCH v3 2/5] dt-bindings: display: sun8i-mixer: Allow for an iommu property

2020-05-12 Thread Rob Herring
mixer.yaml > | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v5 19/38] drm: panfrost: fix common struct sg_table related issues

2020-05-14 Thread Rob Herring
uct sg_table nents > vs. orig_nents misuse' thread: > https://lore.kernel.org/linux-iommu/20200513132114.6046-1-m.szyprow...@samsung.com/T/ > --- > drivers/gpu/drm/panfrost/panfrost_gem.c | 4 ++-- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 7 +++ > 2 files changed, 5 insertions(+), 6

Re: [PATCH 06/12] of/iommu: Make of_map_rid() PCI agnostic

2020-05-21 Thread Rob Herring
buys much. And there's only 3 callers. > No functionality change intended. > > Signed-off-by: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Joerg Roedel > Cc: Robin Murphy > Cc: Marc Zyngier > --- > drivers/iommu/of_iommu.c | 2 +- > drivers/of/base.c

Re: [PATCH 07/12] of/device: Add input id to of_dma_configure()

2020-05-21 Thread Rob Herring
d parameter, > leaving current functionality unchanged. > > Signed-off-by: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Robin Murphy > Cc: Joerg Roedel > Cc: Laurentiu Tudor > --- > drivers/bus/fsl-mc/fsl-mc-bus.c | 4 ++- > drivers/iommu/of_iommu.c| 53 +

Re: [PATCH 09/12] dt-bindings: arm: fsl: Add msi-map device-tree binding for fsl-mc bus

2020-05-21 Thread Rob Herring
map property. > > Signed-off-by: Laurentiu Tudor > Cc: Rob Herring > --- > .../devicetree/bindings/misc/fsl,qoriq-mc.txt | 30 +-- > 1 file changed, 27 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt

  1   2   3   4   5   >