On Wed, Oct 30, 2013 at 8:17 PM, Will Deacon <will.dea...@arm.com> wrote: > On Fri, Oct 18, 2013 at 09:13:15PM +0100, Andreas Herrmann wrote: >> This patch adds descriptions fore new properties of device tree >> binding for the ARM SMMU architecture. These properties control >> arm-smmu driver options. >> >> Cc: Rob Herring <robherri...@gmail.com> >> Cc: Grant Likely <grant.lik...@linaro.org> >> Cc: Will Deacon <will.dea...@arm.com> >> Signed-off-by: Andreas Herrmann <andreas.herrm...@calxeda.com> >> --- >> .../devicetree/bindings/iommu/arm,smmu.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.txt >> b/Documentation/devicetree/bindings/iommu/arm,smmu.txt >> index e34c6cd..de88cf9 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.txt >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.txt >> @@ -48,6 +48,17 @@ conditions. >> from the mmu-masters towards memory) node for this >> SMMU. >> >> +- arm,smmu-isolate-devices : Enable device isolation for all masters >> + of this SMMU. Ie. each master will be >> + attached to its own iommu domain. >> + >> +- arm,smmu-secure-config-access : Enable proper handling of buggy >> + implementations that always use >> + secure access to SMMU configuration >> + registers. In this case non-secure >> + aliases of secure registers have to >> + be used during SMMU configuration. > > Why are you using the "arm" vendor prefix for the secure config access > stuff? Wouldn't it make more sense to use "calxeda", just in case somebody > else finds a different way to wire things up in this regard?
I think that the property prefix should match the compatible vendor prefix. You could then argue that the compatible string itself should be prefixed with "calxeda". In that case, this property would not be needed at all as you could just key off the compatible string to determine this characteristic. Of the options, my preference would be just to leave things as is. Rob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
