Re: AMD IOMMU: Please support Marvell 88SE91xx SATA Controllers

2013-05-21 Thread Joerg Roedel
On Mon, May 20, 2013 at 11:21:52PM +0200, Manfred Schwarb wrote: > Is anybody working on this issue for the AMD part? I would be very > grateful if such support could be added to the linux kernel. I would > be prepared to test patches, if needed. I will look into the best way to port this to the A

Re: [PATCH 0/2 V3] perf/x86/amd: IOMMU Performance Counter Support

2013-05-27 Thread Joerg Roedel
Hi Peter, On Mon, May 27, 2013 at 06:30:23PM +0200, Peter Zijlstra wrote: > Have you had time to look at this yet? -- mostly sending this email to > make sure I don't forget about these patches. Sorry about that, I didn't forget it. But I was traveling last week and had an outage of my root-serve

Re: [PATCH 1/2 V3] perf/x86/amd: Adding IOMMU PC resource management

2013-05-28 Thread Joerg Roedel
On Fri, May 17, 2013 at 02:43:31PM -0500, Suthikulpanit, Suravee wrote: > From: Steven L Kinney > > Add functionality to check the availability of the AMD IOMMU Performance > Counters and export this functionality to other core drivers, such as in this > case, a perf AMD IOMMU PMU. This feature

Re: [PATCH 2/2 V3] perf/x86/amd: AMD IOMMU PC PERF uncore PMU implementation

2013-05-28 Thread Joerg Roedel
On Fri, May 17, 2013 at 02:43:32PM -0500, Suthikulpanit, Suravee wrote: > diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile > index b0684e4..fcbd3b8 100644 > --- a/arch/x86/kernel/cpu/Makefile > +++ b/arch/x86/kernel/cpu/Makefile > @@ -30,7 +30,7 @@ obj-$(CONFIG_CPU_SUP_UMC_3

Re: [PATCH] msm: iommu: fix leak and invalid access

2013-05-28 Thread Joerg Roedel
On Wed, May 22, 2013 at 01:58:39PM +0800, Libo Chen wrote: > > > > This patch merge two patch that I sended before: > > 1. msm: iommu: add missing platform_device_unregister() in err case > > 2. msm: iommu: no need kfree before kzalloc successful > > > > It fixes two obvious problems: > > 1. We h

[git pull] IOMMU Updates for v3.11

2013-07-08 Thread Joerg Roedel
tion assumption around grouping iommu: Split iommu_unmaps iommu: Fix compiler warning on pr_debug iommu/amd: Only unmap large pages from the first pte Andy Lutomirski (1): iommu/vt-d: Downgrade the warning if enabling irq remapping fails Joe Perches (1): iommu: U

[git pull] IOMMU Updates for v3.12

2013-09-12 Thread Joerg Roedel
--- Alex Williamson (1): intel-iommu: Fix leaks in pagetable freeing Grant Grundler (1): iommu/exynos: Remove dead code (set_prefbuf) Joerg Roedel (3): iommu/fsl: Fix whitespace problems noticed by git-am iommu/fsl: Remove unnecessary 'fsl

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.12

2013-09-24 Thread Joerg Roedel
On Tue, Sep 17, 2013 at 02:19:49PM +0100, Will Deacon wrote: > The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f: > > Linux 3.12-rc1 (2013-09-16 16:17:51 -0400) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.

Re: [PATCH] MAINTAINERS: add overall IOMMU section

2013-09-24 Thread Joerg Roedel
On Fri, Sep 13, 2013 at 01:10:27PM -0600, Stephen Warren wrote: > I believe that Joerg Roedel is at least the path through which > drivers/iommu changes should be merged. Add a MAINTAINERS entry to > make this clear, so that he's Cd'd on all relevant patches. This is > rele

Re: [PATCH 0/7] iommu: Add event tracing feature to iommu

2013-09-24 Thread Joerg Roedel
On Thu, Aug 15, 2013 at 11:59:22AM -0600, Shuah Khan wrote: > Shuah Khan (7): > iommu: Add event tracing feature to iommu > iommu: Change iommu driver to call add_device_to_group trace event > iommu: Change iommu driver to call remove_device_to_group trace event > iommu: Change iommu driver

Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace

2013-09-24 Thread Joerg Roedel
On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote: > +DEFINE_EVENT(iommu_fault, report_fault, > + > + TP_PROTO(struct device *dev, unsigned long iova, int flags), > + > + TP_ARGS(dev, iova, flags) > +); I am not entirely happy with the naming. It is better to name the class iommu_

Re: [PATCH 1/1] x86/iommu: correct ICS register offset

2013-09-24 Thread Joerg Roedel
On Tue, Sep 17, 2013 at 04:38:29PM +0800, ZhenHua wrote: > Hi Guys, > Though DMAR_ICS_REG is not used yet, I think this patch is > necessary. So please take a look at it. You are right, my Spec says the same. It doesn't matter much since the register seems to be unused in the VT-d driver. I a

Re: [PATCH v2] intel-iommu: Quiesce devices before disabling IOMMU

2013-09-24 Thread Joerg Roedel
On Wed, Sep 18, 2013 at 03:09:01PM +0900, Takao Indoh wrote: > + /* > + * In the case of kdump, ioremap is needed because root-entry table > + * exists in first kernel's memory area which is not mapped in second > + * kernel > + */ > + root = (struct root_entry *)iore

Re: [PATCH v4 0/2] iommu: Add iommu_error class event to iommu trace

2013-09-25 Thread Joerg Roedel
On Tue, Sep 24, 2013 at 03:21:18PM -0600, Shuah Khan wrote: > Shuah Khan (2): > iommu: Add iommu_error class event to iommu trace > iommu: Change iommu driver to call io_page_fault trace event Applied to the tracing branch, thanks Shuah. ___ iommu

[PATCH 2/3] Fix compile error in drivers/gpu/drm/msm/msm_drv.c

2013-09-25 Thread Joerg Roedel
The include file has been moved but this file was not updated, so compile breaks. Signed-off-by: Joerg Roedel --- drivers/gpu/drm/msm/Makefile |3 --- drivers/gpu/drm/msm/msm_drv.c |5 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/Makefile b

[PATCH 3/3] Fix compile error in drivers/gpu/drm/msm/msm_drv.c with IOMMU disabled

2013-09-25 Thread Joerg Roedel
The function msm_iommu_get_ctx() is needed buy the MSM-GPU driver with and wiithout IOMMU compiled in. Make the function available when no IOMMU driver is there. Signed-off-by: Joerg Roedel --- drivers/iommu/msm_iommu.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/iommu

[PATCH 1/3] MSM: Remove iommu include from drivers/gpu/drm/msm/mdp4/mdp4_kms.c

2013-09-25 Thread Joerg Roedel
The include file has been removed and the file does not need it anyway, so remove it. Fixes a compile error. Signed-off-by: Joerg Roedel --- drivers/gpu/drm/msm/mdp4/mdp4_kms.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm

Re: [PATCH] On unmap, flush IOMMU TLB and return correct size

2013-09-25 Thread Joerg Roedel
On Sat, Sep 21, 2013 at 09:59:00PM -0500, David Woodhouse wrote: > I *hate* the bizarre calling convention for iommu_unmap(). Is it > actually clearly documented anywhere? Why on earth is it not just > returning void, and expected to unmap what it was *asked* to unmap? Yeah, I agree that this shou

Re: [PATCH 6/7] iommu/arm-smmu: Add module parameter arm-smmu=off|force_isolation

2013-09-25 Thread Joerg Roedel
On Tue, Sep 24, 2013 at 04:42:18PM +0100, Will Deacon wrote: > On Tue, Sep 24, 2013 at 04:07:00PM +0100, Andreas Herrmann wrote: > > +__setup("arm-smmu", arm_smmu_parse_options); > > If this is going to be a common function for IOMMUs, let's instead move the > command-line parsing out into the gen

Re: [PATCH] On unmap, flush IOMMU TLB and return correct size

2013-09-25 Thread Joerg Roedel
On Wed, Sep 25, 2013 at 05:05:13PM +0100, David Woodhouse wrote: > On Wed, 2013-09-25 at 17:54 +0200, Joerg Roedel wrote: > > Yeah, I agree that this should be documented since it is quite > > non-standard/non-obvious behaviour of a function. The reason the > > interface was

Re: [PATCH 3/3] Fix compile error in drivers/gpu/drm/msm/msm_drv.c with IOMMU disabled

2013-09-27 Thread Joerg Roedel
Hi Rob, On Fri, Sep 27, 2013 at 11:28:36AM -0400, Rob Clark wrote: > But I am not the right one to merge this one. And, well, if there is > a way to make this work without msm_iommu_get_ctx(), I am interested > in some hints ;-) > > Of the other two, 1/3 looks fine and I'll pull that in. And I'

[git pull] IOMMU Fixes for v3.12-rc3

2013-10-04 Thread Joerg Roedel
-smmu: fix iommu_present() test in init Joerg Roedel (1): Merge branch 'for-joerg/arm-smmu/fixes' of git://git.kernel.org/.../will/linux into iommu/fixes Li, Zhen-Hua (1): x86/iommu: correct ICS register offset Stephen Warren (1): MAINTAINERS: add overall IOMMU section W

Re: [PATCH v10 00/20] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-11-01 Thread Joerg Roedel
On Mon, Oct 07, 2013 at 10:52:12AM +0900, Cho KyongHo wrote: > Patch summary: > [PATCH 01/20] iommu/exynos: do not include removed header > [PATCH 02/20] iommu/exynos: add missing cache flush for removed page table > entries > [PATCH 03/20] iommu/exynos: change error handling when page table updat

Re: [PATCH] vfio, iommu: Fixed interaction of VFIO_IOMMU_MAP_DMA with IOMMU address limits

2013-11-01 Thread Joerg Roedel
On Wed, Oct 09, 2013 at 10:03:52AM +0200, Julian Stecklina wrote: > The BUG_ON in drivers/iommu/intel-iommu.c:785 can be triggered from userspace > via > VFIO by calling the VFIO_IOMMU_MAP_DMA ioctl on a vfio device with any address > beyond the addressing capabilities of the IOMMU. The problem is

Re: VT-d and x2apic: broken resume after suspend to ram

2013-11-01 Thread Joerg Roedel
Hi Peter, On Fri, Nov 01, 2013 at 01:37:36PM +0100, Peter Senna Tschudin wrote: > I have one notebook that is failing to resume after suspend to ram. > I've filled a bug report back on the 2.6.41 days: > > https://bugzilla.redhat.com/show_bug.cgi?id=787299 > > The issue is that trying to resume

Re: [PATCH v10 00/20] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-11-01 Thread Joerg Roedel
Hi Cho, On Fri, Nov 01, 2013 at 09:37:45PM +0900, Cho KyongHo wrote: > I am preparing next patches to apply Alex Williamson's comment that > description of IOMMU's masters must be aligned with ARM SMMU. > > It is delayed due to my jobs in the office. > > I will post the next patche series in two

Re: [PATCH 1/2] IOMMU/trivial: Use for_each_drhd_unit() instead of list_for_each_entry()

2013-11-01 Thread Joerg Roedel
On Thu, Oct 31, 2013 at 05:25:16PM +0800, Yijing Wang wrote: > Use for_each_drhd_unit() instead of list_for_each_entry for > better readability. > > Signed-off-by: Yijing Wang Applied both, thanks. ___ iommu mailing list iommu@lists.linux-foundation.

Re: [PATCH 1/2] iommu/tegra-gart: Staticize tegra_gart_pm_ops

2013-11-01 Thread Joerg Roedel
On Tue, Oct 08, 2013 at 04:21:03PM +0530, Sachin Kamat wrote: > 'tegra_gart_pm_ops' is local to this file. Make it static. > > Signed-off-by: Sachin Kamat Applied both, thanks. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.lin

Re: [PATCH v2 05/19] iommu: shmobile: Enable the driver on all ARM platforms

2013-11-01 Thread Joerg Roedel
ILE > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with > COMPILE_TEST. > > Cc: Joerg Roedel > Cc: iommu@lists.linux-foundation.org > Signed-off-by: Laurent Pinchart Applied, thanks. ___ iommu mailing list iommu@lists

Re: VT-d and x2apic: broken resume after suspend to ram

2013-11-01 Thread Joerg Roedel
On Fri, Nov 01, 2013 at 02:21:07PM +0100, Peter Senna Tschudin wrote: > On Fri, Nov 1, 2013 at 2:07 PM, Joerg Roedel wrote: > > Which kernels have you tried? Does it happen with all of them or is > > there a kernel-version where this started? > > I'm using 3.11.6-200.fc

Re: VT-d and x2apic: broken resume after suspend to ram

2013-11-01 Thread Joerg Roedel
On Fri, Nov 01, 2013 at 04:47:47PM +0100, Peter Senna Tschudin wrote: > Only serial ports over USB: > usb 2-1.3.2: pl2303 converter now attached to ttyUSB0 > > The issue with no_console_suspend is that the monitor is powered off > on suspend and never resume after that. The external monitor enters

[git pull] IOMMU Updates for Linux v3.13

2013-11-14 Thread Joerg Roedel
check for proper size of mapped region iommu/arm-smmu: Check for num_context_irqs > 0 to avoid divide by zero exception iommu/arm-smmu: Print context fault information iommu/arm-smmu: Clear global and context bank fault status registers Fabio Estevam (1): iommu: No need to pass &#x

Vacation Notice

2013-11-15 Thread Joerg Roedel
Hi, this is just a short notice that I will be traveling through south-east Asia for the next 4 weeks and will probably not have internet access there. Alex Williamson will pick up IOMMU related fixes while I am gone and send them upstream, so feel free to send everything to him while I am gone :)

Re: [GIT PULL] iommu/arm-smmu: updates for 3.14

2013-12-30 Thread Joerg Roedel
On Tue, Dec 17, 2013 at 06:08:54PM +, Will Deacon wrote: > Antonios Motakis (1): > iommu/arm-smmu: add devices attached to the SMMU to an IOMMU group > > Will Deacon (3): > iommu/arm-smmu: use VA_BITS to determine arm64 virtual address space > iommu: add IOMMU_EXEC flag for s

Re: [PATCHv7 05/12] iommu/core: add ops->{bound,unbind}_driver()

2013-12-30 Thread Joerg Roedel
On Thu, Dec 12, 2013 at 09:57:06AM +0200, Hiroshi Doyu wrote: > ops->{bound,unbind}_driver() functions are called at > BUS_NOTIFY_{BOUND,UNBIND}_DRIVER respectively. > > This is necessary to control the device population order. IOMMU master > devices depend on an IOMMU device instanciation. IOMMU

Re: [PATCH 1/3] drivers: iommu: Mark functions as static in dmar.c

2013-12-30 Thread Joerg Roedel
On Wed, Dec 18, 2013 at 12:01:46PM +0530, Rashika Kheria wrote: > Mark the functions check_zero_address() and dmar_get_fault_reason() as > static in dmar.c because they are not used outside this file. > > This eliminates the following warnings in dmar.c: > drivers/iommu/dmar.c:491:12: warning: no

Re: [PATCH 04/15] iommu: shmobile: Enable driver compilation with COMPILE_TEST

2014-01-07 Thread Joerg Roedel
On Wed, Dec 11, 2013 at 01:48:01PM +0100, Laurent Pinchart wrote: > Hi Joerg, > > Could you please pick this patch up for v3.14 ? Applied, thanks. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinf

Re: [PATCH] iommu: add missing include

2014-01-07 Thread Joerg Roedel
On Wed, Dec 04, 2013 at 05:22:53PM -0800, Brian Norris wrote: > Fix a warning in of_iommu.c: > > drivers/iommu/of_iommu.c:38:5: warning: no previous prototype for > 'of_get_dma_window' [-Wmissing-prototypes] > > Signed-off-by: Brian Norris > Cc: Hiroshi DOYU Applied, thanks. ___

Re: [PATCH] iommu: Rename domain_has_cap to iommu_domain_has_cap

2014-01-07 Thread Joerg Roedel
On Wed, Dec 11, 2013 at 08:19:56PM +, Upinder Malhi (umalhi) wrote: > domain_has_cap is a misnomer bc the func name should be > the same for CONFIG_IOMMU_API and !CONFIG_IOMMU_API. > > Signed-off-by: Upinder Malhi Applied, thanks. ___ iommu mail

Re: [PATCH 0/2] SH Mobile IOMMU fixes

2014-01-07 Thread Joerg Roedel
On Tue, Dec 17, 2013 at 06:18:48PM +0100, Laurent Pinchart wrote: > Hello, > > These two small patches fix bugs in the SH Mobile IOMMU driver that result in > crashes at runtime. Given that the bugs have been present in the driver since > v3.9 there's no urgency to push the fixes to v3.13. > > La

Re: [PATCH 1/1] x86/iommu: use bit structures for context_entry

2014-01-07 Thread Joerg Roedel
On Fri, Dec 20, 2013 at 04:45:01PM +0800, Li, Zhen-Hua wrote: > There is a structure named context_entry used by intel iommu, and there > are some bit operations on it. Use bit structure may make these operations > easy. > Also the function context_set_address_root may cause problem because it uses

Re: [Patch Part1 V3 09/20] iommu/vt-d: mark internal functions as static

2014-01-07 Thread Joerg Roedel
On Mon, Jan 06, 2014 at 02:18:16PM +0800, Jiang Liu wrote: > Function detect_intel_iommu()/alloc_iommu()/parse_ioapics_under_ir() > are only used internally, so mark them as static. Doesn't seem to be true for detect_intel_iommu which is used in ia64 setup code, no? Joerg _

Re: [Patch Part1 V3 00/20] Bugfixes and improvements for Intel IOMMU drivers

2014-01-07 Thread Joerg Roedel
On Mon, Jan 06, 2014 at 02:18:07PM +0800, Jiang Liu wrote: > This patchset includes several bugfixes and code improvements for > Intel DMA remapping and interrupt remapping drivers. It's also a > preparation for Intel IOMMU device hotplug. > > It applies to the latest mainstream kernel on top of >

[PATCH] drm/msm: Fix link error with !MSM_IOMMU

2014-01-07 Thread Joerg Roedel
Rob Clark Signed-off-by: Joerg Roedel --- drivers/gpu/drm/msm/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index f39ab75..d3de8e1 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -4,6 +4,7

Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU

2014-01-07 Thread Joerg Roedel
On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: > The DRM driver for MSM depends on symbols from the MSM > IOMMU driver. Add this dependency to the Kconfig file. > > Fixes this comile error: > > Kernel: arch/arm/boot/zImage is ready > ERROR: "msm_iommu

Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU

2014-01-08 Thread Joerg Roedel
On Wed, Jan 08, 2014 at 08:23:49AM -0500, Rob Clark wrote: > On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel wrote: > > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: > >> The DRM driver for MSM depends on symbols from the MSM > >> IOMMU driver. Add this dep

Re: [PATCH] iommu/vt-d: fix compilation error for IA64 platform

2014-01-09 Thread Joerg Roedel
On Wed, Jan 08, 2014 at 04:57:07PM +0800, Jiang Liu wrote: > Hi Joerg, > Could you please help to fold this into "[21/22] iommu/vt-d, > trivial: clean sparse warnings"? Okay, I folded the two patches in, but that is something I'd like to avoid because it requires a rebase. So next time pleas

Re: [PATCH Trivial] intel-iommu: check return value of device_to_iommu() before using it

2014-01-09 Thread Joerg Roedel
On Thu, Jan 09, 2014 at 09:58:42AM +0800, ethan zhao wrote: > drivers/iommu/intel-iommu.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index 40203ad..5b4531a 100644 > --- a/drivers/iommu/intel-iommu.c >

Re: [patch] iommu/vt-d: signedness bug in alloc_irte()

2014-01-09 Thread Joerg Roedel
On Thu, Jan 09, 2014 at 08:32:36AM +0300, Dan Carpenter wrote: > "index" needs to be signed for the error handling to work. I deleted a > little bit of obsolete cruft related to "index" and "start_index" as > well. > > Fixes: 360eb3c5687e ('iommu/vt-d: use dedicated bitmap to track remapping > e

[git pull] IOMMU Updates for Linux v3.14

2014-01-29 Thread Joerg Roedel
n free_dmar_iommu() iommu/vt-d: release invalidation queue when destroying IOMMU unit iommu/vt-d: fix wrong return value of dmar_table_init() iommu/vt-d, trivial: clean sparse warnings iommu/vt-d: free all resources if failed to initialize DMARs Joerg Roedel (3): M

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-18 Thread Joerg Roedel
On Mon, Feb 10, 2014 at 06:32:32PM +, Will Deacon wrote: > The following changes since commit b28a960c42fcd9cfc987441fa6d1c1a471f0f9ed: > > Linux 3.14-rc2 (2014-02-09 18:15:47 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-18 Thread Joerg Roedel
On Mon, Feb 10, 2014 at 06:32:32PM +, Will Deacon wrote: > - Andreas Herrmann took the driver for a run with a real SATA > controller, which caused the new mutex-based locking to explode > since we require mappings in atomic context I just did quick review of the changes. Was the SAT

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-20 Thread Joerg Roedel
fixup patch, if you want it to be converted please include a renaming patch in your updates for the next merge window. Joerg >From e848d16b3129cc7234089d6917a0568b1b5f4acc Mon Sep 17 00:00:00 2001 From: Joerg Roedel Date: Thu, 20 Feb 2014 12:19:08 +0100 Subject: [PATCH] arm/smmu:

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-20 Thread Joerg Roedel
Hi Will, On Thu, Feb 20, 2014 at 11:51:27AM +, Will Deacon wrote: > > Can the arm_smmu_devices_lock also be used in a DMA-API path? > > I don't think so -- that lock is only taken when: > > - Probing the SMMU > - Attaching a device to a domain (->attach_dev) > - Adding or removing a de

[git pull] IOMMU Fixes for Linux v3.14-rc3

2014-02-21 Thread Joerg Roedel
based systems. Besides that I put a fix on-top to make the spinlock irq-safe, so that the code-paths can be used in the DMA-API. Joerg Roedel (2): Merge branch 'for-joerg/arm-smmu/fixes' of git://git.kernel.org/.../will/

Re: [GIT PULL] iommu/arm-smmu: updates for 3.15

2014-03-04 Thread Joerg Roedel
On Fri, Feb 28, 2014 at 11:05:25AM +, Will Deacon wrote: > The following changes since commit cfbf8d4857c26a8a307fb7cd258074c9dcd8c691: > > Linux 3.14-rc4 (2014-02-23 17:40:03 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.

Re: [PATCH 1/1] iommu/amd: Fix PASID format in INVALIDATE_IOTLB_PAGES command

2014-03-04 Thread Joerg Roedel
On Wed, Feb 26, 2014 at 03:49:31PM -0600, suravee.suthikulpa...@amd.com wrote: > From: Jay Cornwall > > This patch corrects the PASID format in the INVALIDATE_IOTLB_PAGES > command, which was caused by incorrect information in > the AMD IOMMU Architectural Specification v2.01 document. > > I

Re: [PATCH v2] IOMMU: enhance dmar to support device hotplug

2014-03-04 Thread Joerg Roedel
On Thu, Nov 21, 2013 at 04:21:56PM +0800, Yijing Wang wrote: > @@ -3641,21 +3681,42 @@ static int device_notifier(struct notifier_block *nb, > struct device *dev = data; > struct pci_dev *pdev = to_pci_dev(dev); > struct dmar_domain *domain; > + struct dmar_device *dmar_dev; >

Re: [PATCHv3 3/6] Crashdump-Accepting-Active-IOMMU-Domain-Interfaces

2014-03-04 Thread Joerg Roedel
On Fri, Jan 10, 2014 at 03:07:29PM -0700, Bill Sumner wrote: > +context_get_entry(struct context_entry *context_addr, > + struct intel_iommu *iommu, u32 bus, int devfn) > +{ > + unsigned long long q; /* quadword scratch */ > + struct root_entry *root_phys; /*

Re: [PATCHv3 0/6] Crashdump Accepting Active IOMMU

2014-03-04 Thread Joerg Roedel
Hi Bill, On Fri, Jan 10, 2014 at 03:07:26PM -0700, Bill Sumner wrote: > Bill Sumner (6): > Crashdump-Accepting-Active-IOMMU-Flags-and-Prototype > Crashdump-Accepting-Active-IOMMU-Utility-functions > Crashdump-Accepting-Active-IOMMU-Domain-Interfaces > Crashdump-Accepting-Active-IOMMU-Copy-

Re: [PATCH] IOMMU: iommu module do not check NULL return of kmem_cache_zalloc

2014-03-04 Thread Joerg Roedel
On Tue, Feb 11, 2014 at 10:12:53AM +0800, Zhouyi Zhou wrote: > From: Zhouyi Zhou > > The function iopte_alloc do not check NULL return of kmem_cache_zalloc, > call iopte_free with argument 0 will panic. > > Signed-off-by: Zhouyi Zhou > --- > drivers/iommu/omap-iommu.c |3 ++- > 1 file chan

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-04 Thread Joerg Roedel
On Fri, Feb 28, 2014 at 03:00:00PM -0800, Tony Lindgren wrote: > * Suman Anna [140228 12:46]: > > Hi Joerg, Tony, > > > > This is an updated series of the OMAP IOMMU DT adaptation intended > > for 3.15 merge window, addressing the comments from the v2 series. > > This series is rebased onto 3.14-

Re: [Patch Part2 V2 00/17] Enhance DMAR drivers to handle PCI/memory hotplug events

2014-03-04 Thread Joerg Roedel
On Wed, Feb 19, 2014 at 02:07:20PM +0800, Jiang Liu wrote: > Jiang Liu (17): > iommu/vt-d: avoid double free of g_iommus on error recovery path > iommu/vt-d: avoid caching stale domain_device_info and fix memory > leak > iommu/vt-d: avoid caching stale domain_device_info when hot-removing

Re: Re: [PATCH] IOMMU: iommu module do not check NULL return of kmem_cache_zalloc

2014-03-04 Thread Joerg Roedel
On Wed, Mar 05, 2014 at 10:31:17AM +0800, Zhouyi Zhou wrote: > Thanks Joerg for reviewing > Checking the null pointer in iopte_free guarantees kmem_cache_free > is happy all the time. Can you send this as a new patch in a new thread please? Thanks, Joerg ___

Re: [PATCH] iommu/amd: Fix logics to determine and checking max PASID

2014-03-05 Thread Joerg Roedel
On Wed, Mar 05, 2014 at 01:01:08PM -0600, suravee.suthikulpa...@amd.com wrote: > drivers/iommu/amd_iommu.c | 26 +++--- > drivers/iommu/amd_iommu_init.c | 15 --- > drivers/iommu/amd_iommu_types.h |6 ++ > drivers/iommu/amd_iommu_v2.c|2 +-

Re: [PATCH v2] IOMMU: iopte free should check wether input argument is NULL

2014-03-05 Thread Joerg Roedel
On Wed, Mar 05, 2014 at 06:20:19PM +0800, Zhouyi Zhou wrote: > From: Zhouyi Zhou > > iopte free should check wether input argument is NULL because kmem_cache_free > will panic on NULL argument > > Signed-off-by: Zhouyi Zhou > Signed-off-by: Joerg Roedel > > --- &g

Re: [GIT PULL] VT-d fixes and ACPI device mapping support for 3.15

2014-03-24 Thread Joerg Roedel
On Mon, Mar 24, 2014 at 03:17:59PM +, David Woodhouse wrote: > Jörg, please pull into your x86/vt-d branch from > > git://git.infradead.org/iommu-2.6 > > This contains the two patch sets I've posted in the last week; first the > set which fixes the use-after-free issues with IOTLB flush

Re: [PATCH V2] iommu/amd: Fix logic to determine and checking max PASID

2014-03-24 Thread Joerg Roedel
On Wed, Mar 05, 2014 at 06:54:18PM -0600, suravee.suthikulpa...@amd.com wrote: > From: Suravee Suthikulpanit > > In reality, the spec can only support 16-bit PASID since > INVALIDATE_IOTLB_PAGES and COMPLETE_PPR_REQUEST commands only allow 16-bit > PASID. So, we updated the PASID_MASK accordingly

[PATCH] iommu/vt-d: Check for NULL pointer in dmar_acpi_dev_scope_init() array

2014-03-25 Thread Joerg Roedel
not done that close to the merge-window. Do you have objections? Joerg >From 0e1ad789087ea3b142ee4a169662db0ec77425ff Mon Sep 17 00:00:00 2001 From: Joerg Roedel Date: Tue, 25 Mar 2014 20:16:40 +0100 Subject: [PATCH] iommu/vt-d: Check for NULL pointer in dmar_acpi_dev_scope_init() When

Re: [GIT PULL] VT-d fixes and ACPI device mapping support for 3.15

2014-04-02 Thread Joerg Roedel
On Tue, Apr 01, 2014 at 03:35:35PM +0100, David Woodhouse wrote: > On Mon, 2014-03-24 at 15:17 +, David Woodhouse wrote: > > Jörg, please pull into your x86/vt-d branch from > > > > git://git.infradead.org/iommu-2.6 > > Again, please. A few minor fixes... > > Dan Carpenter (1): >

[git pull] IOMMU Updates for Linux v3.15

2014-04-04 Thread Joerg Roedel
Introduce a rwsem to protect global data structures iommu/vt-d: Use RCU to protect global resources in interrupt context iommu/vt-d: Update DRHD/RMRR/ATSR device scope caches when PCI hotplug happens iommu/vt-d: Unify the way to process DMAR device scope array iommu/vt-d: U

Re: [PATCH 0/5] OMAP IOMMU fixes and IOMMU architecture questions

2014-04-04 Thread Joerg Roedel
On Fri, Mar 14, 2014 at 12:00:16PM +0100, Laurent Pinchart wrote: > Right, we indeed need two levels of API, one for drivers such as remoteproc > that need direct control of the IOMMU, and one for drivers that only need to > map buffers without any additional requirement. In the second case the

Re: [PATCH] iommu-groups: Add list_head for iommu groups

2014-04-08 Thread Joerg Roedel
On Mon, Apr 07, 2014 at 09:54:54PM +0530, Ritesh Harjani wrote: > On Mon, Apr 7, 2014 at 7:44 PM, Alex Williamson > wrote: > > On Mon, 2014-04-07 at 15:23 +0530, Ritesh Harjani wrote: > >> Say multiple groups are linked to one iommu device. Each iommu_group > >> maintains > >> one iommu_data spec

Re: [PATCH 0/5] OMAP IOMMU fixes and IOMMU architecture questions

2014-04-08 Thread Joerg Roedel
Hi Laurent, On Tue, Apr 08, 2014 at 02:50:38PM +0200, Laurent Pinchart wrote: > I agree with you, the two levels are already present, but there's still rough > edges that we need to soften. > > The ARM DMA API implementation requires someone to create the VA space > mapping > by calling arm_i

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-04-09 Thread Joerg Roedel
Hi Laurent, On Wed, Apr 09, 2014 at 12:43:57PM +0200, Laurent Pinchart wrote: > On Wednesday 02 April 2014 12:47:37 Laurent Pinchart wrote: > > Signed-off-by: Laurent Pinchart > > --- > > drivers/iommu/Kconfig| 12 + > > drivers/iommu/Makefile |1 + > >

Re: [PATCH 0/5] OMAP IOMMU fixes and IOMMU architecture questions

2014-04-09 Thread Joerg Roedel
On Tue, Apr 08, 2014 at 05:02:37PM +0200, Laurent Pinchart wrote: > On Tuesday 08 April 2014 15:43:22 Joerg Roedel wrote: > > Who is "someone" in this case? > > That's exactly the problem :-) The ARM DMA API implementation doesn't care > who > that &q

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Joerg Roedel
t;> > Ok so I don't see those DMA messages and system starts just fine. I'm > > >> > thinking perhaps something broke after the IO mmu stuff in commit > > >> > 3f583bc21977a608908b83d03ee2250426a5695c... could this be indirectly > > >> > ca

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.15

2014-04-16 Thread Joerg Roedel
On Tue, Apr 15, 2014 at 05:21:06PM +0100, Will Deacon wrote: > --->8 > > The following changes since commit c9eaa447e77efe77b7fa4c953bd62de8297fd6c5: > > Linux 3.15-rc1 (2014-04-13 14:18:35 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/

Re: [GIT PULL FOR v3.16] OMAP IOMMU fixes

2014-04-16 Thread Joerg Roedel
Hi Laurent, On Fri, Apr 04, 2014 at 12:11:52AM +0200, Laurent Pinchart wrote: > Laurent Pinchart (3): > iommu/omap: Fix 'no page for' debug message in flush_iotlb_page() > iommu/omap: Remove comment about supporting single page mappings only > iommu/omap: Fix map protection value

Re: [GIT PULL v2 FOR v3.16] OMAP IOMMU fixes

2014-04-16 Thread Joerg Roedel
On Wed, Apr 16, 2014 at 04:51:56PM +0200, Laurent Pinchart wrote: > The following changes since commit c9eaa447e77efe77b7fa4c953bd62de8297fd6c5: > > Linux 3.15-rc1 (2014-04-13 14:18:35 -0700) > > are available in the git repository at: > > git://linuxtv.org/pinchartl/media.git iommu/omap >

[git pull] IOMMU Fixes for Linux v3.15-rc1

2014-04-20 Thread Joerg Roedel
): iommu/vt-d: Fix get_domain_for_dev() handling of upstream PCIe bridges Jiang Liu (2): iommu/vt-d: fix memory leakage caused by commit ea8ea46 iommu/vt-d: fix bug in matching PCI devices with DRHD/RMRR descriptors Joerg Roedel (1): Merge git://git.infradead.org/iommu-2.6 into

Re: [PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-05-06 Thread Joerg Roedel
On Wed, Apr 30, 2014 at 04:27:10PM +0530, Shaik Ameer Basha wrote: > This series is going on for quite a long time and most of the patches here > doesn't depend on dt bindings. As Exynos IOMMU h/w is introducing new versions > very frequently, maintaining and reviewing all these patches again and >

Re: [PATCH] iommu/amd: Take mmap_sem when calling get_user_pages

2014-05-06 Thread Joerg Roedel
On Mon, Apr 28, 2014 at 05:27:46PM -0500, Suthikulpanit, Suravee wrote: > From: Jay Cornwall > > get_user_pages requires caller to hold a read lock on mmap_sem. Right, but can't we just switch to get_user_pages_fast instead? Joerg ___ iommu

Re: [GIT PULL] iommu/arm-smmu: updates for 3.16

2014-05-12 Thread Joerg Roedel
On Tue, May 06, 2014 at 06:23:34PM +0100, Will Deacon wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git > for-joerg/arm-smmu/updates > Pulled, thanks Will. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.

Re: [GIT PULL FOR v3.16] SH-Mobile IPMMU miscellaneous cleanups

2014-05-12 Thread Joerg Roedel
On Thu, Apr 17, 2014 at 12:18:21PM +0200, Laurent Pinchart wrote: > > git://linuxtv.org/pinchartl/fbdev.git iommu/for-v3.16 > Pulled, thanks Laurent, despite I missed a MAINTAINERS patch ;-) What happened to the original author of this driver? ___

Re: [PATCH] iommu/amd: Take mmap_sem when calling get_user_pages

2014-05-12 Thread Joerg Roedel
On Mon, Apr 28, 2014 at 05:27:46PM -0500, suravee.suthikulpa...@amd.com wrote: > From: Jay Cornwall > > get_user_pages requires caller to hold a read lock on mmap_sem. > > Signed-off-by: Jay Cornwall > Signed-off-by: Suravee Suthikulpanit Applied, thanks Jay and Suravee.

Re: [PATCH] iommu/amd: Fix interrupt remapping for aliased devices

2014-05-12 Thread Joerg Roedel
On Tue, Apr 22, 2014 at 10:08:40AM -0600, Alex Williamson wrote: > An apparent cut and paste error prevents the correct flags from being > set on the alias device resulting in MSI on conventional PCI devices > failing to work. This also produces error events from the IOMMU like: > > AMD-Vi: Event

Re: [PATCH v13 00/19] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-05-13 Thread Joerg Roedel
On Mon, May 12, 2014 at 11:44:45AM +0530, Shaik Ameer Basha wrote: > Cho KyongHo (18): > iommu/exynos: fix build errors > iommu/exynos: change error handling when page table update is failed > iommu/exynos: allocate lv2 page table from own slab > iommu/exynos: fix L2TLB invalidation > iom

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-05-13 Thread Joerg Roedel
Hi Laurent, Sorry for taking so long with this. The code looks good and clean overall, besides my second comment. On Wed, Apr 02, 2014 at 12:47:37PM +0200, Laurent Pinchart wrote: > +static void ipmmu_domain_destroy_context(struct ipmmu_vmsa_domain *domain) > +{ > + /* > + * Disable the

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-05-13 Thread Joerg Roedel
On Tue, May 13, 2014 at 11:04:10PM +0200, Laurent Pinchart wrote: > > Isn't this the same as ipmmu_tlb_invalidate()? > > ipmmu_tlb_invalidate() performs a read-update-write operation on the IMCTR > register to set the FLUSH bit without modifying the other bits, while this > function writes the F

Re: [PATCH] documentation/iommu: Add note on existing DT binding status

2014-05-14 Thread Joerg Roedel
On Wed, May 14, 2014 at 11:23:33AM +0530, Shaik Ameer Basha wrote: > .../devicetree/bindings/iommu/samsung,sysmmu.txt |5 + > 1 file changed, 5 insertions(+) Applied, thanks. ___ iommu mailing list iommu@lists.linux-foundation.org https://li

Re: [PATCH] iommu/amd: Fix for L2 race with VM invalidation

2014-05-14 Thread Joerg Roedel
On Wed, May 14, 2014 at 01:34:12AM -0500, suravee.suthikulpa...@amd.com wrote: > A low probability race exists with this fix. Translations received > within the critical section to PTEs which are concurrently being > invalidated may resolve to stale mappings. Sorry, no. This patch can cause silent

Re: [PATCH v3 08/15] iommu/amd: Use pci_find_dma_isolation_root() for IOMMU groups

2014-05-14 Thread Joerg Roedel
On Sat, May 10, 2014 at 09:03:11AM -0600, Alex Williamson wrote: > The expectation is that the kernel and IVRS will produce the same > result for topology based aliases while the kernel will also include > device specific DMA quirks. Is that expectation really true? There are PCIe devices out ther

Re: [Patch Part3 V2 00/21] Enable support of Intel DMAR device hotplug

2014-05-19 Thread Joerg Roedel
Hey David, On Tue, May 06, 2014 at 03:05:11PM +0800, Jiang Liu wrote: > Patch 1-13 are bugfixes and code improvement for current drivers. > Patch 14-17 enhances DMAR framework to support hotplug > Patch 18 enhances Intel interrupt remapping driver to support hotplug > Patch 19 enhances error handl

Re: [PATCH] iommu/amd: Fix for L2 race with VM invalidation

2014-05-20 Thread Joerg Roedel
On Wed, May 14, 2014 at 11:38:25AM +, Cornwall, Jay wrote: > Hi, > > I'm not sure why you're submitting this, Suravee? > > We already agreed that we need the extra mmu_notifier point, proposed > by Joerg back in 2011, to eliminate the race. I had thought we were > waiting on that to be implem

[PATCH 4/5] iommu/amd: Remove IOMMUv2 pasid_state_list

2014-05-20 Thread Joerg Roedel
From: Joerg Roedel This list was only used for the task_exit notifier function. Now that it is gone we can remove it. Signed-off-by: Joerg Roedel Tested-by: Jay Cornwall --- drivers/iommu/amd_iommu_v2.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers

[PATCH 2/5] iommu/amd: Convert IOMMUv2 state_table into state_list

2014-05-20 Thread Joerg Roedel
From: Joerg Roedel The state_table consumes 512kb of memory and is only sparsly populated. Convert it into a list to save memory. There should be no measurable performance impact. Signed-off-by: Joerg Roedel Tested-by: Jay Cornwall --- drivers/iommu/amd_iommu_v2.c | 39

[PATCH 1/5] iommu/amd: Don't access IOMMUv2 state_table directly

2014-05-20 Thread Joerg Roedel
From: Joerg Roedel This is a preparation for converting the state_table into a state_list. Signed-off-by: Joerg Roedel Tested-by: Jay Cornwall --- drivers/iommu/amd_iommu_v2.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/amd_iommu_v2.c b

[PATCH 5/5] iommu/amd: Handle parallel invalidate_range_start/end calls correctly

2014-05-20 Thread Joerg Roedel
From: Joerg Roedel Add a counter to the pasid_state so that we do not restore the original page-table before all invalidate_range_start to invalidate_range_end sections have finished. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu_v2.c | 17 + 1 file changed, 13

[PATCH 3/5] iommu/amd: Implement mmu_notifier_release call-back

2014-05-20 Thread Joerg Roedel
From: Joerg Roedel Since mmu_notifier call-backs can sleep (because they use SRCU now) we can use them to tear down PASID mappings. This allows us to finally remove the hack to use the task_exit notifier from oprofile to get notified when a process dies. Signed-off-by: Joerg Roedel Tested-by

<    1   2   3   4   5   6   7   8   9   10   >