On Wed, May 14, 2014 at 01:34:12AM -0500, suravee.suthikulpa...@amd.com wrote: > A low probability race exists with this fix. Translations received > within the critical section to PTEs which are concurrently being > invalidated may resolve to stale mappings.
Sorry, no. This patch can cause silent data corruption when the pages in these stale mappings get reused. I understand that the current way does not work either and can cause failures in the GPU, but silent data corruption is worse than that. How about putting the page-fault requests on hold between invalidate_range_start/end()? The GPU will not see the failures, just a longer delay until the page faults are handled. Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu