Re: [Patch Part1 V3 09/20] iommu/vt-d: mark internal functions as static

2014-01-08 Thread Jiang Liu
Hi Joerg, Thanks for fix up this issue! I forgot to test the changes against IA64 platform. There's another issue related to IA64, I will send out the patch soon. I have setup cross compilation environment for IA64 and verified all changes passing compilation tests. Thanks! Gerry On 2014/

[PATCH] iommu/vt-d: fix compilation error for IA64 platform

2014-01-08 Thread Jiang Liu
commit: ecd1c02e9fea1c684c9698e8ce6a552656ba0871 [21/22] iommu/vt-d, trivial: clean sparse warnings config: make ARCH=ia64 defconfig All error/warnings: arch/ia64/kernel/built-in.o: In function `pci_iommu_alloc': >> (.init.text+0xb541): undefined reference to `intel_dma_ops' arch/ia64/kerne

Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU

2014-01-08 Thread Rob Clark
On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel wrote: > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: >> The DRM driver for MSM depends on symbols from the MSM >> IOMMU driver. Add this dependency to the Kconfig file. >> >> Fixes this comile error: >> >> Kernel: arch/arm/boot/zImag

Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU

2014-01-08 Thread Joerg Roedel
On Wed, Jan 08, 2014 at 08:23:49AM -0500, Rob Clark wrote: > On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel wrote: > > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: > >> The DRM driver for MSM depends on symbols from the MSM > >> IOMMU driver. Add this dependency to the Kconfig file.

Re: [PATCH 4/6] iommu/tegra124: smmu: support more than 32 bit pa

2014-01-08 Thread Thierry Reding
On Tue, Jan 07, 2014 at 01:25:37PM +0800, Mark Zhang wrote: > On 12/05/2013 08:25 PM, Hiroshi Doyu wrote: [...] > > @@ -526,6 +530,21 @@ static int smmu_setup_regs(struct smmu_device *smmu) > > return 0; > > } > > > > +static void flush_ptc_by_addr(struct smmu_device *smmu, unsigned long *pt

Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU

2014-01-08 Thread Rob Clark
On Wed, Jan 8, 2014 at 8:35 AM, Joerg Roedel wrote: > On Wed, Jan 08, 2014 at 08:23:49AM -0500, Rob Clark wrote: >> On Tue, Jan 7, 2014 at 5:53 PM, Joerg Roedel wrote: >> > On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote: >> >> The DRM driver for MSM depends on symbols from the MSM >

Re: [Patch Part2 V1 00/14] Enhance DMAR drivers to handle PCI/memory hotplug events

2014-01-08 Thread Yinghai Lu
On Tue, Jan 7, 2014 at 1:00 AM, Jiang Liu wrote: > Intel DMA/interrupt remapping drivers scan available PCI/memory devices > at startup and cache discovered hardware topologies. They don't update > cached information if PCI/memory hotplug event happens at runtime, then > the stale information may

Re: [Patch Part2 V1 00/14] Enhance DMAR drivers to handle PCI/memory hotplug events

2014-01-08 Thread Jiang Liu
On 2014/1/9 4:43, Yinghai Lu wrote: > On Tue, Jan 7, 2014 at 1:00 AM, Jiang Liu wrote: >> Intel DMA/interrupt remapping drivers scan available PCI/memory devices >> at startup and cache discovered hardware topologies. They don't update >> cached information if PCI/memory hotplug event happens at

[PATCH Trivial] intel-iommu: check return value of device_to_iommu() before using it

2014-01-08 Thread ethan zhao
in function iommu_support_dev_iotlb(),return value of device_to_iommu() is used without checking, this could cause NULL pointer issue. this patch is for v3.12.6 Signed-off-by: Ethan Zhao --- drivers/iommu/intel-iommu.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/d

Re: [PATCH 4/6] iommu/tegra124: smmu: support more than 32 bit pa

2014-01-08 Thread Mark Zhang
On 01/08/2014 09:45 PM, Thierry Reding wrote: > On Tue, Jan 07, 2014 at 01:25:37PM +0800, Mark Zhang wrote: >> On 12/05/2013 08:25 PM, Hiroshi Doyu wrote: > [...] >>> @@ -526,6 +530,21 @@ static int smmu_setup_regs(struct smmu_device *smmu) >>> return 0; >>> } >>> >>> +static void flush_ptc_

Re: [Patch Part2 V1 07/14] iommu/vt-d: fix error in detect ATS capability

2014-01-08 Thread Yijing Wang
This is a issue, our BIOS also supports several ATSR which have the same segment. Good fix :) On 2014/1/7 17:00, Jiang Liu wrote: > Current Intel IOMMU driver only matches a PCIe root port with the first > DRHD unit with the samge segment number. It will report false result > if there are multipl

[patch] iommu/vt-d: signedness bug in alloc_irte()

2014-01-08 Thread Dan Carpenter
"index" needs to be signed for the error handling to work. I deleted a little bit of obsolete cruft related to "index" and "start_index" as well. Fixes: 360eb3c5687e ('iommu/vt-d: use dedicated bitmap to track remapping entry allocation status') Signed-off-by: Dan Carpenter diff --git a/driver