RE: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-08 Thread Liu, Yi L
Hi, > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Friday, November 9, 2018 9:40 AM > Subject: Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor > support > > Hi, > > On 11/8/18 3:20 PM, Liu, Yi L wrote: > > Hi, > &g

Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-08 Thread Lu Baolu
04/12] iommu/vt-d: Add 256-bit invalidation descriptor support Hi, On 11/8/18 11:49 AM, Liu, Yi L wrote: Hi, From: Lu Baolu [mailto:baolu...@linux.intel.com] Sent: Thursday, November 8, 2018 10:17 AM Subject: Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support Hi Yi

RE: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-07 Thread Liu, Yi L
> Subject: Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation > >> descriptor support > >> > >> Hi, > >> > >> On 11/8/18 11:49 AM, Liu, Yi L wrote: > >>> Hi, > >>> > >>>> From: Lu Baolu [mailto:baolu.

Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-07 Thread Lu Baolu
On 11/8/18 1:48 PM, Liu, Yi L wrote: From: Liu, Yi L Sent: Thursday, November 8, 2018 1:45 PM + memcpy(desc, qi->desc + (wait_index << shift), Would "memcpy(desc, (unsigned long long) (qi->desc + (wait_index << shift)," be more safe? Can that be compiled? memcpy() re

Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-07 Thread Lu Baolu
Hi, On 11/8/18 1:45 PM, Liu, Yi L wrote: From: Lu Baolu [mailto:baolu...@linux.intel.com] Sent: Thursday, November 8, 2018 1:25 PM Subject: Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support Hi, On 11/8/18 11:49 AM, Liu, Yi L wrote: Hi, From: Lu Baolu

RE: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-07 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Thursday, November 8, 2018 1:45 PM > > + memcpy(desc, qi->desc + (wait_index << shift), > > >>> > > >>> Would "memcpy(desc, (unsigned long long) (qi->desc + (wait_index > > >>> << shift)," be more safe? > > >> > > >> Can that be compiled? memcpy(

RE: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-07 Thread Liu, Yi L
> From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Thursday, November 8, 2018 1:25 PM > Subject: Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor > support > > Hi, > > On 11/8/18 11:49 AM, Liu, Yi L wrote: > > Hi, > &g

Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-07 Thread Lu Baolu
Hi, On 11/8/18 11:49 AM, Liu, Yi L wrote: Hi, From: Lu Baolu [mailto:baolu...@linux.intel.com] Sent: Thursday, November 8, 2018 10:17 AM Subject: Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support Hi Yi, On 11/7/18 2:07 PM, Liu, Yi L wrote: Hi Baolu, From: Lu

RE: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-07 Thread Liu, Yi L
Hi, > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Thursday, November 8, 2018 10:17 AM > Subject: Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor > support > > Hi Yi, > > On 11/7/18 2:07 PM, Liu, Yi L wrote: > > Hi Baolu, > &g

Re: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-07 Thread Lu Baolu
Hi Yi, On 11/7/18 2:07 PM, Liu, Yi L wrote: Hi Baolu, From: Lu Baolu [mailto:baolu...@linux.intel.com] Sent: Monday, November 5, 2018 1:32 PM [...] --- drivers/iommu/dmar.c| 83 +++-- drivers/iommu/intel-svm.c | 76 --

RE: [PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-06 Thread Liu, Yi L
Hi Baolu, > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Monday, November 5, 2018 1:32 PM [...] > --- > drivers/iommu/dmar.c| 83 +++-- > drivers/iommu/intel-svm.c | 76 -- > drivers/iommu/intel_irq_remapping.

[PATCH v4 04/12] iommu/vt-d: Add 256-bit invalidation descriptor support

2018-11-04 Thread Lu Baolu
Intel vt-d spec rev3.0 requires software to use 256-bit descriptors in invalidation queue. As the spec reads in section 6.5.2: Remapping hardware supporting Scalable Mode Translations (ECAP_REG.SMTS=1) allow software to additionally program the width of the descriptors (128-bits or 256-bits) that