Re: [PATCH 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-03-29 Thread Tom Lendacky
On 3/29/2018 5:54 PM, Gary R Hook wrote: > Implement a skeleton framework for debugfs support in the > AMD IOMMU. > > > Signed-off-by: Gary R Hook > --- > drivers/iommu/Kconfig |6 ++--- > drivers/iommu/Makefile|2 +- > drivers/iommu/amd_iommu_debugfs.c | 47 >

Re: [PATCH 1/2] iommu - Enable debugfs exposure of the IOMMU

2018-03-29 Thread Tom Lendacky
On 3/29/2018 5:54 PM, Gary R Hook wrote: > Provide base enablement for using debugfs to expose internal data of > an IOMMU driver. When enabled, create the /sys/kernel/debug/iommu So this can't actually create anything yet since nothing invokes the function. Maybe describe how it should be used b

Re: [PATCH 0/3] iommu/vt-d: Global PASID name space

2018-03-29 Thread Lu Baolu
Hi, On 03/29/2018 04:52 PM, Joerg Roedel wrote: > On Mon, Mar 26, 2018 at 08:38:21AM +0800, Lu Baolu wrote: >> Hi Joerg, >> >> A gentle ping. :-) >> >> Any comments on this patch set? > Yes, it doesn't apply on-top of my x86/vt-d branch. Please rebase it > after the merge-window to rc1 and re-send

[PATCH 1/2] iommu - Enable debugfs exposure of the IOMMU

2018-03-29 Thread Gary R Hook
Provide base enablement for using debugfs to expose internal data of an IOMMU driver. When enabled, create the /sys/kernel/debug/iommu directory. Emit a strong warning at boot time to indicate that this feature is enabled. Signed-off-by: Gary R Hook --- drivers/iommu/Kconfig | 11 +++

[PATCH 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-03-29 Thread Gary R Hook
Implement a skeleton framework for debugfs support in the AMD IOMMU. Signed-off-by: Gary R Hook --- drivers/iommu/Kconfig |6 ++--- drivers/iommu/Makefile|2 +- drivers/iommu/amd_iommu_debugfs.c | 47 + drivers/iommu/amd_iomm

[PATCH 0/2] Base enablement of IOMMU debugfs support

2018-03-29 Thread Gary R Hook
These patches create a top-level function to create a debugfs directory for the IOMMU, under which drivers may create and populate-specific directories for their device internals. Patch 1: general IOMMU enablement Patch 2: basic AMD enablement to demonstrate linkage with patch 1 Introduce a new K

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-03-29 Thread Jacob Pan
On Thu, 29 Mar 2018 10:48:24 +0200 Joerg Roedel wrote: > [ Adding Gary from AMD to Cc ] > > On Mon, Mar 19, 2018 at 09:37:14AM -0700, Jacob Pan wrote: > > On Thu, 15 Mar 2018 14:18:54 +0100 > > Joerg Roedel wrote: > > > > > On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote: > > > >

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-03-29 Thread Gary R Hook
On 03/29/2018 03:48 AM, Joerg Roedel wrote: [ Adding Gary from AMD to Cc ] On Mon, Mar 19, 2018 at 09:37:14AM -0700, Jacob Pan wrote: On Thu, 15 Mar 2018 14:18:54 +0100 Joerg Roedel wrote: On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote: Just wondering if your concern is on the im

Re: [PATCHv3] iommu/intel: Ratelimit each dmar fault printing

2018-03-29 Thread Dmitry Safonov
2018-03-29 9:50 GMT+01:00 Joerg Roedel : > On Tue, Mar 20, 2018 at 08:50:13PM +, Dmitry Safonov wrote: >> Hmm, but this fixes my softlockup issue, because it's about time spent >> in printk() inside irq-disabled section, rather about exiting the dmar- >> clearing loop. >> And on my hw doesn't m

Re: [PATCH] iommu/io-pgtable-arm: Avoid warning with 32-bit phys_addr_t

2018-03-29 Thread Joerg Roedel
On Thu, Mar 29, 2018 at 12:24:52PM +0100, Robin Murphy wrote: > It's not entirely unreasonable for io-pgtable-arm to be built for > configurations with 32-bit phys_addr_t, where the compiler rightly > raises a warning about the 36-bit shift. That particular code path > should never actually *run* o

[PATCH] iommu/io-pgtable-arm: Avoid warning with 32-bit phys_addr_t

2018-03-29 Thread Robin Murphy
It's not entirely unreasonable for io-pgtable-arm to be built for configurations with 32-bit phys_addr_t, where the compiler rightly raises a warning about the 36-bit shift. That particular code path should never actually *run* on those systems, but we still want it to compile cleanly, which is eas

Re: [PATCH v8 00/14] iommu/rockchip: Use OF_IOMMU

2018-03-29 Thread Joerg Roedel
On Fri, Mar 23, 2018 at 03:38:00PM +0800, Jeffy Chen wrote: > > This series fixes some issues in rockchip iommu driver, and add of_iommu > support in it. > > Changes in v8: > Rebase on newest for-next. > Don't introduce the additional return. > Rename startup()/shutdown() to enable()/disable(). >

Re: [PATCH 0/3] iommu/vt-d: Global PASID name space

2018-03-29 Thread Joerg Roedel
On Mon, Mar 26, 2018 at 08:38:21AM +0800, Lu Baolu wrote: > Hi Joerg, > > A gentle ping. :-) > > Any comments on this patch set? Yes, it doesn't apply on-top of my x86/vt-d branch. Please rebase it after the merge-window to rc1 and re-send. Thanks, Joerg __

Re: [PATCHv3] iommu/intel: Ratelimit each dmar fault printing

2018-03-29 Thread Joerg Roedel
On Tue, Mar 20, 2018 at 08:50:13PM +, Dmitry Safonov wrote: > Hmm, but this fixes my softlockup issue, because it's about time spent > in printk() inside irq-disabled section, rather about exiting the dmar- > clearing loop. > And on my hw doesn't make any difference to limit loop or not because

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-03-29 Thread Joerg Roedel
[ Adding Gary from AMD to Cc ] On Mon, Mar 19, 2018 at 09:37:14AM -0700, Jacob Pan wrote: > On Thu, 15 Mar 2018 14:18:54 +0100 > Joerg Roedel wrote: > > > On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote: > > > Just wondering if your concern is on the implementation or the > > > debugfs

Re: [PATCH 00/10 v3] iommu/amd: lock splitting & GFP_KERNEL allocation

2018-03-29 Thread Joerg Roedel
On Thu, Mar 22, 2018 at 04:22:32PM +0100, Sebastian Andrzej Siewior wrote: > Hi, > > this is the rebase on top of iommu/x86/amd of my last series. It takes > Scotts comments into consideration from my v2. > > It contains lock splitting and GFP_KERNEL allocation of remap-table. > Mostly cleanup. >

Re: [PATCH] iommu/vt-d, trivial: Remove unused variable

2018-03-29 Thread Joerg Roedel
On Thu, Mar 22, 2018 at 06:18:06PM +0800, Shaokun Zhang wrote: > Unused after commit <42e8c186b595> ("iommu/vt-d: Simplify io/tlb flushing > in intel_iommu_unmap"), cleanup it. > > Cc: David Woodhouse > Cc: Joerg Roedel > Signed-off-by: Shaokun Zhang > --- > drivers/iommu/intel-iommu.c | 6 +--

Re: [GIT PULL] iommu/arm-smmu: Updates for 4.17

2018-03-29 Thread Joerg Roedel
On Tue, Mar 27, 2018 at 05:37:17PM +0100, Will Deacon wrote: > Hi Joerg, > > Please pull the following Arm SMMU updates for 4.17. Changes include: > > * More graceful handling and reporting of IRQ setup failures > * General cleanup of our register field definitions using linux/bitmask.h > *