It's very important! Take a look at http://gcov.php.net
A single build takes almost 2 days with most extensions enabled plus
valgrind testing.
So, yes, parallel testing would be highly appreciated (but do not forget my
initial requirements, such as e.g. mysql and mysqli tests cannot run at the
I have no clue what those 2 sections do either.
But if the number of affected tests is small, then feel free to patch the
tests and/or run-tests.php.
Nuno
-Original Message-
From: zoe slattery
Sent: Tuesday, May 08, 2012 2:06 PM
Subject: [PHP-QA] run-tests.php - GZIP_POST and DEFLAT
Hi Zoe,
Thanks for undertaking this project!
I just have a few concerns about this:
- The speedup seems a bit low to me. Maybe with a higher number of
extensions enabled it will improve?..
- Is there any developer documentation available? If I wanted to do a
change or a bug fix today, how cou
Alright, thanks for the reply!
I'll try to have a look at the code and give it a try next weekend.
Nuno
-Original Message-
From: zoe slattery
Sent: Monday, May 21, 2012 8:26 AM
Subject: Re: [PHP-QA] Parallel run-tests
On 21/05/2012 06:45, Nuno Lopes wrote:
Hi Zoe,
Thank
I would like first to see some bugs closed, like:
* #30641 - PHP 5.1 doesn't compile on Solaris 9
* #31725 - PHP is always segfaulting when using sqlite
* upgrade sqlite and PCRE libraries
Thanks,
Nuno
- Original Message -
Hey,
I'd like to roll PHP 5.1 Beta 1 very soon.
Wez, I've been wait
But at least you could allow Solaris guys to test PHP 5.1 beta 1 :)
Nuno
- Original Message -
Guys,
Not that I disagree with resolving these problems, but it has nothing to
do with beta 1 which was planned to get wider testing and feedback, mainly
about PDO which is the main new code bas
Patch attached (explanation in the bug report).
Nuno
- Original Message -
Do you have a fix?
Andi
At 03:15 PM 4/3/2005 +0100, Nuno Lopes wrote:
But at least you could allow Solaris guys to test PHP 5.1 beta 1 :)
Nuno
- Original Message -
Guys,
Not that I disagree with resolving
You should contact the peardoc team instead: [EMAIL PROTECTED]
BTW, livedocs shouldn't work with peardoc correctly, because the indexing
system is a bit phpdoc specific.
Nuno
- Original Message -
Hello!
I was wondering if I could get some help about a problem I have when I try
to config
ups, forward to right list..
- Original Message -
just a quick note to say that win32 build are broken since April 26.
Nuno
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Personally, this could be a good opportunity for me to start learning the
PHP and Zend APIs...
Nuno
- Original Message -
Adam,
Perhaps the mentoring FAQ will give you a clue why, specifically the "What
is the role of a mentoring organization?" portion. :-)
http://code.google.com/
Yes, I and Monte vouch this request.
Nuno
- Original Message -
From: "Peter 'Mash' Morgan" <[EMAIL PROTECTED]>
To:
Sent: Sunday, June 05, 2005 4:29 PM
Subject: [PHP-DEV] CVS Account Request: pete_morgan
Maintaining the smarty.php.net documentation.
Reffered by nlopess at php.net
I've tested it under solaris 9 and it failed 3 tests:
=
FAILED TEST SUMMARY
-
Bug #31213 (Sideeffects caused by bug #29493)
[ext/standard/tests/array/bug31213.ph
Hi,
Today, while discussing with my teachers and colleagues about PHP vs Java,
I've found a typo in the bench.php file.
In the line 169, you should read:
"return(($n < 2) ? 1 : fibo_r($n - 2) + fibo_r($n - 1));"
Could someone please fix it?
Thanks,
Nuno
P.S.: if anyone has some materi
""Andi Gutmans"" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> andi Mon Jun 20 16:49:56 2005 EDT
>
> Modified files:
>/php-src NEWS configure.in
>/ZendEngine2 zend.h
>/php-src/main php_version.h
> Log:
> - Beta 2
There is a problem in the configure:
checking for embe
I still have a problem in the configure script.
With the package you post:
checking for embedded SAPI library support... no
./configure: syntax error at line 9265: `;' unexpected
checking that line, there is a problem indeed:
header_path=sapi/embed/php_embed.h
for header_file in ; do
;, and
'docref_root' and 'docref_ext' to "" in the INI section.
Nuno
- Original Message -
Fixed in CVS.
--Jani
On Tue, 21 Jun 2005, Nuno Lopes wrote:
I still have a problem in the configure script.
With the package you post:
checking for
Sebastian Nohn wrote:
It compiles fine.
Andi Gutmans wrote:
Please check new packages at http://snaps.php.net/~andi
Will release tomorrow if there's not another major screwup :)
There are still some strtotime() issues to work out.
echo date("m d Y",strtotime("Jan 14, 2004"));
correctly giv
It was renamed to 'server-tests.php'.
Nuno
- Original Message -
Hi All,
I used to see run-tests2.php in php source bundle.
But I could not see it anymore.
In http://cvs.php.net/php-src show deleted file shows run-tests2.php has
been renamed by helly 3 months back.
I want to what it ha
Seems to be a good idea, but not for PHP 4 (closed for new features).
Official description:
http://msdn.microsoft.com/workshop/author/dhtml/httponly_cookies.asp
Nuno
- Original Message -
Hello Marcus,
patches for official php-4.3.11 release in attachment... (diff -Naur)
Jochen
[p
You can find the patches for httpOnly session cookies against the PHP5
CVS HEAD in the attachment.
Now also included is support for httpOnly cookies for PHP functions
setcookie() and setrawcookie().
bool setcookie ( string name [, string value [, int expire [, string path
[, string domain [, boo
Jochen Hansper wrote:
The indexed array 'parameters' is expected to be:
array( {int|string} expires [, string path [, domain [, bool secure
[,bool httponly )
Why not like this?
array(
'expires' => ...,
'path' => ...,
'domain => ...,
'secure' => ...,
'httponly' => ...
);
This was the a
On Wed, 29 Jun 2005 [EMAIL PROTECTED] wrote:
ID: 12284
Updated by: [EMAIL PROTECTED]
Reported By: andrew at andrew dot org
-Status: Open
+Status: Closed
Bug Type: Feature/Change Request
Operating System: any
PHP Version: 4.0.6
New
- Original Message -
derick Sat Jul 2 17:19:25 2005 EDT
Log:
- Overhauled selecting the correct timezone. The timezone set with
"date_timezone_set" override the TZ environment variable, which on its
turn
overrides the date.timezone setting. If none of the three is set, we
fallb
On Sun, 3 Jul 2005, Nuno Lopes wrote:
Hi Derick et all,
I think that having the date_timezone_set() and date_timezone_get()
functions
along with the default_timezone ini option is redundant. You can use
ini_set()/ini_get() to emulate the functions you added. I don't see a
point to
h
So, you can give precedence to the ini option over the TZ var.
That way you don't need the functions.
IMHO this is the better choice, as it allows you to set a site
wide ini option, without touching in the environment vars or
having to call a function in each script.
If there was not a BC proble
Last point, can you rename date_timezone_* to
date_default_timezone_*?
Yes, but it's too long. Can we come up with something better?
Derick
Sorry, but I still didn't understand why the need for those functions..
You can change the precendence in the TZ guess internal function and you can
dro
>> Last point, can you rename date_timezone_* to
>> date_default_timezone_*?
>
> Yes, but it's too long. Can we come up with something better?
>
> Derick
Sorry, but I still didn't understand why the need for those
functions.. You can change the precendence in the TZ guess
internal function and yo
On Mon, 4 Jul 2005, Pierre-Alain Joye wrote:
I was not :) but still remains TS issues and inconsistencies
between OSes.
Don't forget the thread safety issues...
In short, we need this function, we can move to the name choice
now :)
date_timezone_default_set
date_tz_default_set
date_default
iliaa Mon Jun 13 22:39:43 2005 EDT
Modified files:
/php-src/main network.c php_network.h
/php-src/main/streams xp_socket.c
/php-src/ext/ftp ftp.c
/php-src NEWS
Log:
Added bindto socket context option.
Hi,
I was going to document this new feature but I have a question:
Does the
Nuno
- Original Message -
It is not a wrapper specific context option, it'll work with any TCP/IP
socket.
Ilia
Nuno Lopes wrote:
iliaa Mon Jun 13 22:39:43 2005 EDT
Modified files:
/php-src/main network.c php_network.h
/php-src/main/streams xp_socket.c
/php-src/ext/f
bind both to the port you specified.
--Wez.
On 7/13/05, Nuno Lopes <[EMAIL PROTECTED]> wrote:
Well I've tested again and it works also with the 'tcp' wrapper, but not
with ftp.
consider this:
array('bindto' =>
"1.2.3.1:5000")));
echo
file_get_content
On Fri, 15 Jul 2005, Wez Furlong wrote:
How many people are seriously using Win9x with PHP?
There are quite a few APIs that are either server-only or Win2k and up
that PHP would benefit from using. Before we just go ahead and use
them (breaking support for Win9x) I thought it would be a good id
Today I was trying to reduce the number of tests that fail on my solaris
boxes. (because I don't remember to see PHP pass all the tests)
I needed to patch a couple of tests that didn't work well on that plataform.
Detailed explanation (I hope):
ext/date/tests/bug32555.phpt
strftime is system/lo
I can clearly set the PHP_INI_SYSTEM option in the httpd.conf.
As stated in http://php.net/configuration.changes you should use the
'php_admin_xx' directive instead of 'php_xx'.
AFAIK, those options marked with 'php.ini only' were considered too
expensive to be set at run-time (they are hard-c
On 2.8.2005 10:16 Uhr, Ron Korving wrote:
Shouldn't PHP suppress this warning then? Right now 3 warnings are shown
for
just one bad statement. I think one warning would suffice. Of course this
is
all rather unimportant and very low-priority, but I still think it's a
situation that could be impr
OK thanks for the info. I'll add that to the documentation.
Nuno
- Original Message -
Column numbers in errors are not yet implemented everywhere in libxml
and 0 is often returned.
Rob
Nuno Lopes wrote:
The most interesting example is at http://php.net/libxml_get_errors
But
Hi,
I've already had a change to test your patch (I've even have asked my
university for a server to put ithe reports on-line).
I've also came into this issue, which happens because re2c is called in the
wrong way (the output is printed to stdout, rather than directly to the
file). Those files
Just a note to tell you that the build is broken when configured with
'--disable-zend-memory-manager'.
Thats because you forgot to add the eumaloc() and friends in the else part
of USE_ZEND_MALLOC (zend_alloc.h).
Nuno
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, vi
It doesn't output so many errors as before, but still fails:
"undefined reference to 'zend_ustrdup'"
Nuno
- Original Message -
Should be fixed now.
-Andrei
On Aug 12, 2005, at 9:16 AM, Nuno Lopes wrote:
Just a note to tell you that the build is br
Attached is a patch to fix the build with zend mm disabled. (just a little
typo)
Nuno
Index: Zend/zend_alloc.h
===
RCS file: /repository/ZendEngine2/zend_alloc.h,v
retrieving revision 1.66
diff -u -r1.66 zend_alloc.h
--- Zend/zend
Hi,
HEAD is currently broken because Wez forgot to change the datetime.h file.
Attached is a patch to fix it.
Nuno
Index: datetime.h
===
RCS file: /repository/php-src/ext/standard/datetime.h,v
retrieving revision 1.23
diff -u -r1.23
Hi,
I've made a simple patch to allow a user to retrieve the SQL syntax error
occured in either sqlite_exec(), sqlite_query() or
sqlite_unbuffered_query().
Untill now this wasn't possible, because sqlite_last_error() doesn't handle
SQL syntax errors. The patch adds an additional parameter to t
tried to replicate the problem and it appears to work fine:
$db = sqlite_open(":memory:");
sqlite_exec($db, "SELECT ***");
var_dump(sqlite_error_string(sqlite_last_error($db)));
prints "SQL logic error or missing database"
Ilia
Nuno Lopes wrote:
Hi,
I've
> the "feature request":
prints "SQL logic error or missing database", but you don't have a clue
of what error is.
with my patch, you can retrieve the error (in the additional variable)
you get in the Warning message ("no such column: column").
Aha, I see... that is indeed useful. +1
Ilia
Thanks for reviewing and applying my patch ;)
Nuno
- Original Message -
Applied to CVS, thanks for the patch and the reminder :-)
Ilia
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hi,
Although this is not as hot as references or Unicode stuff, I would like to
discuss a new topic.
Currently PHP accepts more parameters to a function than the required.
In English:
PHP accepts this and generates no errors. My purpose is to start generating
an E_NOTICE, just like we do for
Nuno Lopes wrote:
PHP accepts this and generates no errors. My purpose is to start
generating an E_NOTICE, just like we do for not yet initialized
variables.
No, stupid output!
Generating E_NOTICE is not a good idea. You don't need to create functions
with variable arguments count
derick Sat Oct 1 11:07:21 2005 EDT
Modified files:
/php-src/ext/date php_date.c
/php-src/ext/date/lib fallbackmap.h timezonemap.h .cvsignore
parse_date.c timelib.h timelib_structs.h
/php-src/ext/date/lib/resource parse_date.re
/php-src/ext/date/tests date_def
On Fri, 7 Oct 2005, Nuno Lopes wrote:
> > derick Wed Oct 5 07:06:57 2005 EDT
> >
> > Modified files: (Branch: PHP_5_1)
> > /php-src/ext/date php_date.c
> > Log:
> > - Implement correct Windows timezone guessing.
>
> Thanks for you
On Fri, 7 Oct 2005, Nuno Lopes wrote:
Uhm, sorry but it doesn't work well when I choose a timezone which has
no DST. For an unknown reason, windows returns TIME_ZONE_ID_UNKOWN in
that case, so PHP always returns UTC.
Can you check if in that case the elements in the struct
On 8.10.2005 15:30 Uhr, Zeev Suraski wrote:
I've been away from email for the last couple of weeks - read through
the timezone thread, and didn't really see a conclusion.
IIRC the conclusion was, that Derick tries to make the TZ detection
better (which was the only BC problem, AFAIK). And accor
Derick Rethans wrote:
You don't need this, as there is:
http://no.php.net/date_default_timezone_set
cool ..
now we only need to get the list of possible legal TZ's documented (or
linked from the docs) .. atleast I do not see it yet (but it might be just
me not seeing it at 5 am after coming
I'm not sure if all the patches are commited as for now, but it still
doesn't work for me. First, IDT setting still returns unknown timezone,
second, now PHP crashes in:
0x08095bcd in timelib_tzinfo_dtor (tz=0x0) at
php5/ext/date/lib/timelib.c:107
107 TIMELIB_TIME_FREE(tz->name);
Hi,
In the last hours I've been debugging and testing the new implementation of
the date related functions on windows.
I've found some little problems:
1) timelib_tz_lookup_table defines the gmtoffset as an int, but in the
fallback table there are some decimals numbers. So, either remove thos
1) timelib_tz_lookup_table defines the gmtoffset as an int, but in the
fallback table there are some decimals numbers. So, either remove those
entries or change the struct to hold a float. This also applies to the
timelib_timezone_id_from_abbr() function, which receives a long, instead
of a
floa
john Wed Oct 19 20:18:26 2005 EDT
Added files:
/php-src Makefile.gcov gen_php_cov
Modified files:
/php-src NEWS configure.in
Log:
Implementing C-level Code coverage (--enable-gcov).
o Requires LTP 1.4+ and libgcov
Hello,
As I've told you before, I had already tested your patch.
ng to the re2c files, which most have absolute paths (and
not everyone downloads the sources to the same dir :) ), and some have
.
Nuno
On Thu, 20 Oct 2005, Nuno Lopes wrote:
john Wed Oct 19 20:18:26 2005 EDT
Added files:
/php-src Makefile.gcov gen_php_cov
Modified files:
/php-s
rces to the same dir :) ), and some have
.
Nuno
On Thu, 20 Oct 2005, Nuno Lopes wrote:
john Wed Oct 19 20:18:26 2005 EDT
Added files:
/php-src Makefile.gcov gen_php_cov
Modified files:
/php-src NEWS configure.in
Log:
Implementing C-level Code coverage (--enable-gcov).
o Require
Hi Marcus.
Thanks for reviewing the patch!
I agree with you that using environment vars is excessive in this script.
The only reason I've used it is to allow the user to pass arguments to
valgrind (like the suppresions file). After reading the valgrind manual,
I've discovered that it is also p
; of them in the files by using the -L or -l options for
> flex/bison!!
> --Jani
> On Thu, 20 Oct 2005, Nuno Lopes wrote:
>>
>>> john Wed Oct 19 20:18:26 2005 EDT
>>>
>>> Added files:
>>>/php-src Makefile.gcov gen_php_cov
>>
Hi,
I have made two patches for two open bugs of the sockets extension.
I would like to ask if someone can review/commit them:
http://bugs.php.net/bug.php?id=35062 - bogus warning produced
http://bugs.php.net/bug.php?id=21197 - php_read() doesn't work on windows
Thanks,
Nuno
--
PHP Internals
I must say that I feel deceived by this.
Derick and I agreed that this won't be enabled for 5.1, and he then took
advantage of the fact that release managers changed to enable his class.
Doesn't leave a good taste in my mouth and it shouldn't happen again in
future.
Andi
Just to clarify, it
Marcus Boerger wrote:
here again namespaces would be perfect. Given a lib that doesn't prefix
you'd simply do:
namespace LibNameHere { reqire "some_lib_include"; }
and be done...wohooo :-)
Only if newly introduced PHP core classes use a namespace too. You'll have
to use PHP\Date (or the like
On 12/3/05, Michael Wallner <[EMAIL PROTECTED]> wrote:
> Patrick Barnes wrote:
> > Hi there,
> >
> > I was wondering what the recommended work flow was to generate shared
> > modules compatible with the binary PHP .zip/installer for Win32.
> >
> > Additionally, what software would I need to use to
Hi,
I've made a patch to fix some problems in TSRM on windows:
http://mega.ist.utl.pt/~ncpl/php_tsrm.txt
fixes:
* #31347 - is_dir and is_file (incorrectly) return true for any string >
255 characters - the bug is caused because the return value of
virtual_file_ex() isn't tested
* save one byt
Hi,
There are several (very) old files in phpweb. In order to save space on disk
:), I would like to know which one of these may I delete:
27-05-2000 18:40 840.141 ctlib-linux-elf-dynamic.tar.gz - sybase
stuff
03-12-1997 01:33 488.563 ctlib-linux-elf.tar.gz - sybase stu
Yes, we have, but I don't have (write) access to it..
But at least gd, dbwin* and ctlib-* don't need to go to our museum :)
Nuno
- Original Message -
Don't we have some PHP museum someplace? I prefer not to completely delete
these files.
At 07:17 AM 12/20/2005, Nuno L
nlopess Fri Sep 14 15:28:04 2007 UTC
Log:
changes to run-tests.php:
- change %s to %a
- make %s = [^\r\n]+
- fix tests accordingly
I think this is a very bad change. While tests of bundled extensions
can be updated accordingly, pecl extension tests have no way to be
version agnostic
I already use 2k3 to compile my binaries or to develop, it works
pretty well. The 2k5 brings more change and require a couple of
important changes in our build (like the manifest support or what
other describe in this thread).
Uhm I use VS 2005 to build PHP (vanila) for quite some time and it wo
No, no and no!
The gcc 4 -fvisibility patch wasn't rejected. It's a no-op and although it
is only useful for gcc 4 users, it brings many benefits for them!
So please keep that in the PHP 5.3 TODO.
Nuno
- Original Message -
Hi,
I updated the 5.3 todo list [1] yesterday evening. I al
we would like to know whether at php org level there are any test
results available / published / shared per OS (like Solaris, RH in
particular)
Not grouped, but we do have all the test results here:
http://news.php.net/php.qa
In addition to what Derick said, there is a "reference" build and t
It would be interesting, yes. My university has been discontinuing the
Solaris servers and now I only have access to an ancient Solaris 7 server.
Even more interesting would be to get your patches to fix those bugs :)
Thanks,
Nuno
- Original Message -
From: "Rob Thompson" <[EMAIL PROT
I know, I know.. It is on my TODO list for a loong time. I have the program
on my head, I just need to get some time to sit and code it..
BTW: Jean, would Sun be interested in setting up a build machine to run the
PHP test suite and post the results to a central build DB?
Nuno
- Origina
Hi,
It sounds cool, indeed.
The obvious question now is: how it performs with real-world applications?
Have you been able to identify security bugs (either new or already known)?
I don't have time to perform these tests myself, but I would love to see
some results.
Regards,
Nuno
- Origi
With installing a security update for the pcre3 library on Debian
(http://lists.debian.org/debian-security-announce/debian-security-announ
ce-2007/msg00177.html), preg_match('|^\(|', 'xxx') suddenly returns 1
instead of 0 using PHP 5.1.6.
the correct value is 0, yes.
The thing is - I have bui
Hello Hans-Peter,
not that I am aware of. EXTENSIONS file doesn't list any and Ard who is
listed in CREDITS didn't show up in the last couple of months. Read this:
php.net/cvs-php.php and be also prepared to be asked to take care of
firebird installation on http://gcov.php.net :-)
Ah, sure! La
I just wanted to ask if there was ever a decision made that said tainted
mode will go into PHP mainstream.
no, there was no decision yet.
It is no secret that I don't like the idea of a taint mode in PHP
because it cannot be made secure and fast at the same time.
/me too. Although I can't a
The other difference is that Venema's implementation assumes that
functions exist that make a variable safe for usage in SQL, HTML, ...
When such a function is used the variable is marked as not tainted... In
the previous mail I showed examples why this is not secure.
GRASP on the other hand hook
Hi,
I was assigned a class work in the university to compare web
applications architectures, mainly PHP vs
Java+Hibernate+Struts/Stripes. I'll need to provide some benchmarks
for some typical web apps.
Well, I'm a bit afraid that Java may win, because of the usage of
Hibernate, which caches sql s
Hi,
I was assigned a class work in the university to compare web
applications architectures, mainly PHP vs
Java+Hibernate+Struts/Stripes. I'll need to provide some benchmarks
for some typical web apps.
Well, I'm a bit afraid that Java may win, because of the usage of
Hibernate, which caches sql
Abstaract Syntax Tree, that should be evaluated at run-time
> by
> zval_update_constant().
> Thanks. Dmitry.
>> -Original Message-
>> From: Nuno Lopes [mailto:[EMAIL PROTECTED]
>> Sent: Saturday, September 08, 2007 10:50 PM
>> To: Stanislav Malyshev
>> Cc: i
Definitely a great idea, since most linux distributions already bundle this
information and update it frequently.
BTW, your implementation seems to require some security checks for timezone
names like "../../../etc/passwd".
Nuno
- Original Message -
From: "Joe Orton" <[EMAIL PROTECTE
Hi Dmitry,
The patch looks fine. Although it wastes a bit more memory than the current
implementation, I think it's ok. It also has some memory fragmentation,
which shouldn't be an issue (we don't have functions with 100 arguments :P).
As a side note, I think the following code could be optim
As a side note, I think the following code could be optimized:
Probably it could, but note that the code not just moves the stack
pointer, but also destroys arguments there (zval_ptr_dtor).
+ while (zend_vm_stack_top(TSRMLS_C) != stack_frame) {
+ zval *stack_zval_p = zend_vm_stack_pop(TSRMLS
I like the patches. If noone complains please go ahead and commit them.
Thanks,
Nuno
- Original Message -
From: "Etienne Kneuss" <[EMAIL PROTECTED]>
To: "php-dev"
Sent: Monday, February 11, 2008 6:07 PM
Subject: [PHP-DEV] substr & substr_compare fix
Hi,
please consider the follow
Hi,
Thanks for working on this. However I don't think more effort should be
wasted with this script. It's a bogus approach to the problem and it will
always generate many false-positives (disclaimer: I'm the author of the
original script and it was like a POC).
Thus my idea is to move along to
Yes, i understand.
It was interesting for me -
how i can decrease false positive and others by improvings on current
script.
If there will be not GSoC participant for this project,
possibly i can do it.
OK, great! :)
Also base questions, which will be asked in any case, are still alive:
Commited, thanks!
Nuno
On 2008-04-06 23:44, Christian Hoffmann wrote:
> Heya,
>
> while building and testing a minimal version of PHP and as such
> disabling the session extension, I discovered that
> ext/standard/tests/general_functions/bug44394_2.phpt fails without the
> session extension bei
Patch applied, thanks!
I haven't merged my other patch to HEAD yet, but I'll do so ASAP.
Thanks,
Nuno
- Original Message -
Hi Scott,
I noticed that Nuno changed yyless() to be like flex after your commit
(not
in HEAD? I considered that, but figured you guys wanted it different
:-))
Thanks Matt for the nice work :)
Also removed the ST_START_[HEREDOC|NOWDOC] states
in the scanner, by doing their work (to catch immediate ending label) in
the
initial heredoc rule.
This one was in my todo list as well. I think there might be other places
where a similar optimization can be
It's time for helly's birthday present from me (and indirectly, Derick,
who did the cp -r) :).
Happy Birthday!
I suspect there may need to be some
changes at gcov.php.net to keep things running smoothly, so this is a
heads up message.
OK, done.
Nuno
--
PHP Internals - PHP Runtime Developm
Hi,
So some comments:
- you have some problems with the indentation. We only use tabs, so please
stick to that. Also, there are some lines that are not indented correctly
- Have you considered the Boyer-Moore algorithm? I think it's a little
faster than KMP (take a look at e.g.
http://www.cs.u
Out of curiosity, what's the slowdown without fastcall?
Despite the potential slowdown, I still think this is the way to go. The
engine isn't supposed to crash!
Nuno
- Original Message -
From: "Dmitry Stogov" <[EMAIL PROTECTED]>
To: "PHP Internals List"
Cc: "Andi Gutmans" <[EMAIL PRO
Nuno Lopes wrote:
Out of curiosity, what's the slowdown without fastcall?
fastcall calling convention assumes passing parameters in registers
instead of pushing them on stack.
yeah, I know. I was asking what's the slowdown that this patch introduces
without the fastcall bits.
>> What would rock is to have it supported by gcov (by us or
>> somewhere else with a public report), would it be possible?
>
> How can I get this done?
I'm adding Nuno to the loop, he is the one leading the gcov initiative
and will surely explain the setup in a better way than me :)
I can add
Hi,
Sorry for taking so long to answer, but I'm trying to catch up last stuff.
It's known that usually to optimize things for longer inputs you usually end
up making things for short inputs worst. So IMHO, I think you should have
the len==1 optimization and then use the KMP algorithm. Your impl
I'd prefer a run-tests.php option that sets the timeout limit in seconds.
Nice idea, but I'm not sure it's achievable under CLI.
Yes, it is. Check the system_with_timeout() function in the run-tests.php
script.
There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You would
just nee
Yes, it is. Check the system_with_timeout() function in the run-tests.php
script.
There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You would
just need to make it configurable by some environment var.
I already tried hard-coding both tv_sec and tv_usec to 0 and it makes no
differe
Hi,
Both patches seem ok to me. Please ask for a CVS account and prepare
yourself to commit (when your mentor says so) :)
In the second patch maybe you could use zend_memrchr() as well, but you
should get the same results. Also I think that bundling the backwards KMP
would be a nice addition.
I didn't test it, but yeah that should fix the # problem. :-) BTW, I also
had other ideas about checking for , etc. tags in the
inline
HTML scanning part, so the largest chunk of HTML is always grabbed (I'll
send the patch in the future; didn't modify anything yet, and it's not
related to the s
1 - 100 of 348 matches
Mail list logo
