Re: [PHP-DEV] Immutability RFC

2016-11-21 Thread Mathieu Rochette
On 20/11/2016 20:25, Rasmus Schultz wrote: Reading through the RFC and the replies, I'm confused about this question. Why would the comparison operators work any differently on immutable objects? If these were value objects, the question would make sense, but it doesn't sound like that's what

Re: [PHP-DEV] Immutability RFC

2016-11-21 Thread Silvio Marijić
@Rasmus We are not changing behaviour of operators since we are not dealing here just with Value Objects. It's not even a question that matter of this RFC can be achieved with encapsulation. Already there are couple of features that got passed, which also could be achieved without 'syntax' sugar,

Re: [PHP-DEV] Immutability RFC

2016-11-21 Thread Lester Caine
On 21/11/16 08:46, Mathieu Rochette wrote: >> The term 'immutable", especially for the property-annotation, doesn't >> strictly seem correct to me either, as for example, I can annotate a >> public >> property as immutable, but if I put an object in there, that object is >> not >> necessarily immut

[PHP-DEV] [RFC] Parameter No Type Variance

2016-11-21 Thread Niklas Keller
Morning Internals, I'd like to announce a RFC to allow omitting the type declarations for parameters in subclasses: https://wiki.php.net/rfc/parameter-no-type-variance PHP doesn't currently allow variance for parameters as checking these for compatibility isn't possible on compile time. This limi

Re: [PHP-DEV] [RFC] Parameter No Type Variance

2016-11-21 Thread Josh Di Fabio
On Mon, Nov 21, 2016 at 9:40 AM Niklas Keller wrote: > Morning Internals, > > I'd like to announce a RFC to allow omitting the type declarations for > parameters in subclasses: > https://wiki.php.net/rfc/parameter-no-type-variance > > PHP doesn't currently allow variance for parameters as checkin

Re: [PHP-DEV] [RFC] Parameter No Type Variance

2016-11-21 Thread Daniel Morris
What happens if the method signature is defined within an interface? I would consider that method signature a contract and one that should not be able to be overwritten. -- Daniel Morris dan...@honestempire.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http:/

Re: [PHP-DEV] [RFC] Parameter No Type Variance

2016-11-21 Thread Niklas Keller
2016-11-21 11:00 GMT+01:00 Daniel Morris : > What happens if the method signature is defined within an interface? Just the same as for every class. Having other rules for interfaces doesn't make sense. Imagine the following example: interface I { function foo(array $foo); } class C1 implements

[PHP-DEV] Re: [RFC] Parameter No Type Variance

2016-11-21 Thread Christoph M. Becker
On 21.11.2016 at 10:39, Niklas Keller wrote: > I'd like to announce a RFC to allow omitting the type declarations for > parameters in subclasses: > https://wiki.php.net/rfc/parameter-no-type-variance > > PHP doesn't currently allow variance for parameters as checking these for > compatibility isn

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.2

2016-11-21 Thread Kalle Sommer Nielsen
Hi 2016-11-18 15:55 GMT+01:00 Nikita Popov : > Hi internals! > > I've submitted this RFC for PHP 7.1 previously, but didn't follow through > due to time constraints. Now I'd like to propose an extended version for > PHP 7.2 and vote on it sooner rather than later to avoid a repeat > performance. >

Re: [PHP-DEV] Request for wiki account activation

2016-11-21 Thread Ferenc Kovacs
On Sat, Nov 19, 2016 at 5:10 PM, Net Mo wrote: > Hi PHP! > > I'm willing to write some awesome RFCs to make PHP great again, I'll build > a wall and it'll be tremendous. Very very great. :-P > > But I'll start with something simple first :-P it is about improving > ArrayIterator (you can find a d

[PHP-DEV] BAD Benchmark Results for PHP Master 2016-11-21

2016-11-21 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-11-21 13:49:02+02:00 commit: 51f5973 previous commit:b6ed319 revision date: 2016-11-21 13:13:28+03:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC] Parameter No Type Variance

2016-11-21 Thread Fleshgrinder
On 11/21/2016 10:39 AM, Niklas Keller wrote: > Morning Internals, > > I'd like to announce a RFC to allow omitting the type declarations for > parameters in subclasses: > https://wiki.php.net/rfc/parameter-no-type-variance > > PHP doesn't currently allow variance for parameters as checking these

Re: [PHP-DEV] Countable Type Hint

2016-11-21 Thread Stanislav Malyshev
Hi! > Nothing prevents it? As far as I'm aware there's no current way to type > hint Countable or array. No, there's not - as there's no way to make other complex type conditions as type. You still can check for it, or just use count(). > How would one add an interface that includes Countable an

Re: [PHP-DEV] [VOTE] Debugging PDO Prepared Statement Emulation

2016-11-21 Thread Stanislav Malyshev
Hi! On 11/16/16 3:06 PM, Adam Baratz wrote: > Hi, > > No, you're not misreading the subject line. I began working on the docs for > the previously accepted proposal and became uncomfortable with the > approach. I think it will be better to integrate this info into > PDOStatement::debugDumpParams(

Re: [PHP-DEV] function overloading

2016-11-21 Thread Stanislav Malyshev
Hi! On 11/15/16 8:13 AM, Dominic Grostate wrote: > I think this may have been discussed before, but I was largely dismissed > because no one though it would be possible to implement. > > However assuming it is possible, what is the general feeling towards > function overloading, as seen in C# and

Re: [PHP-DEV] function overloading

2016-11-21 Thread Stanislav Malyshev
Hi! > a typical use case would be > > class EventHandler { > public function handle(ProductCreated $event) { > ... > } > public function handle(ProductNameChanged $event) { > ... > } > } > > vs what's currently being done: > > class EventHandler { > public fu

[PHP-DEV] makerpm

2016-11-21 Thread Joe Watkins
Morning internals, We have in the root of the repository a script named "makerpm". Other than token changes (changing php5 to php7) it hasn't been properly maintained, and I have to guess that this is because nobody is using it. Possibly I'm wrong about it being out of date, and there are some w