[PHP-DEV] Improvements to for-each implementation

2015-01-22 Thread Benjamin Coutu
Hi, this post is a fork of the "[PHP-DEV] Fixing strange foreach behavior" thread. It proposes a more efficient for-each mechanism (that does NOT change the conceptual behaviour). Currently on for-each the engine will have to copy the array if that array is visible anywhere else in the program

Re: [PHP-DEV] Improvements to Hastable Bucket structure

2015-01-22 Thread Benjamin Coutu
Too bad, didn't think Bucket->key->h was so ubiquitous that it actually kills the benefit of less memory allocation and tighter cache alignment in bucket. == Original == From: Xinchen Hui To: Dmitry Stogov Date: Thu, 22 Jan 2015 08:52:35 +0100 Subject: Re: [PHP-DEV] Improvements

[PHP-DEV] Re: [RFC][VOTE] Turn gc_collect_cycles into function pointer

2015-01-22 Thread Benjamin Eberlei
On Wed, Jan 7, 2015 at 8:33 PM, Benjamin Eberlei wrote: > Hello everyone, > > After discussion I am putting the RFC on turning gc_collect_cycles into a > function pointer to vote: > > https://wiki.php.net/rfc/gc_fn_pointer > > Votes will end on 2015-01-21 19:31 (in 14 days). > Sorry, I forgot to

Re: [PHP-DEV] Re: [RFC][VOTE] Turn gc_collect_cycles into function pointer

2015-01-22 Thread Paul Dragoonis
On 22 Jan 2015 08:57, "Benjamin Eberlei" wrote: > > On Wed, Jan 7, 2015 at 8:33 PM, Benjamin Eberlei > wrote: > > > Hello everyone, > > > > After discussion I am putting the RFC on turning gc_collect_cycles into a > > function pointer to vote: > > > > https://wiki.php.net/rfc/gc_fn_pointer > > >

[PHP-DEV] ZEND_APIifying zendparse()

2015-01-22 Thread Sara Golemon
http://github.com/sgolemon/astkit (See the README.md) I'm using zendparse() to generate an AST but *not* compile it to bytecode. In order to get this extension building, I have to patch php-src to export the zendparse symbol. Anyone object to me pushing that change? diff --git a/Zend/zend_global

Re: [PHP-DEV] Improvements to for-each implementation

2015-01-22 Thread Nikita Popov
On Thu, Jan 22, 2015 at 9:33 AM, Benjamin Coutu wrote: > Hi, > > this post is a fork of the "[PHP-DEV] Fixing strange foreach behavior" > thread. It proposes a more efficient for-each mechanism (that does NOT > change the conceptual behaviour). > > Currently on for-each the engine will have to co

Re: [PHP-DEV] ZEND_APIifying zendparse()

2015-01-22 Thread Nikita Popov
On Thu, Jan 22, 2015 at 10:28 AM, Sara Golemon wrote: > http://github.com/sgolemon/astkit (See the README.md) > > I'm using zendparse() to generate an AST but *not* compile it to > bytecode. In order to get this extension building, I have to patch > php-src to export the zendparse symbol. Anyone

Re: [PHP-DEV] ZEND_APIifying zendparse()

2015-01-22 Thread Pierre Joye
On Thu, Jan 22, 2015 at 11:00 AM, Nikita Popov wrote: > On Thu, Jan 22, 2015 at 10:28 AM, Sara Golemon wrote: > >> http://github.com/sgolemon/astkit (See the README.md) >> >> I'm using zendparse() to generate an AST but *not* compile it to >> bytecode. In order to get this extension building, I

Re: [PHP-DEV] Re: Help - gcc mystery in ext/imap

2015-01-22 Thread Yasuo Ohgaki
Hi all, On Wed, Jan 21, 2015 at 8:22 AM, Rasmus Lerdorf wrote: > On 01/20/2015 02:46 PM, Stanislav Malyshev wrote: > > Hi! > > > >> So, I guess the lesson is that we need to be careful when we migrate > >> extensions to PHP 7. Passing ints instead of size_t string length params > >> to zpp can c

Re: [PHP-DEV] [PATCH] Fix uninitalized variables reads. See CWE-457 for more info.

2015-01-22 Thread Yasuo Ohgaki
Hi Joshua, On Wed, Jan 21, 2015 at 5:28 AM, Joshua Rogers wrote: > ext/mbstring/mbstring.c | 8 > ext/reflection/php_reflection.c | 1 + > main/main.c | 1 + > 3 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/ext/mbstring/mbstring.c b/ext/mb

Re: [PHP-DEV] Improvements to for-each implementation

2015-01-22 Thread Benjamin Coutu
Hi Nikita, I would suggest using the proposal for the by-value case and sticking with the current behavior for the by-reference case as you suggested. Granted, we then cannot remove the internal pointer all together, but we would just use it for the less common by-reference case as well as for

Re: [PHP-DEV] Enable error_handler callback parameters to be passed by reference

2015-01-22 Thread Yasuo Ohgaki
Hi Thomas, On Wed, Jan 21, 2015 at 1:39 PM, Thomas Bley wrote: > In userland it is sometimes necessary to extend PHP's notices/warnings > with additional information (e.g. username from session, stack trace, etc.) > I'm proposing to enable error_handler callback parameters to be passed by > refe

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-22 Thread Tony Marston
"Pierre Joye" wrote in message news:caezptu6rlmncdvgbr1cd4hxa0syt0dxs3kvjfdpuwiwmx_l...@mail.gmail.com... On Jan 22, 2015 12:21 AM, "Tony Marston" wrote: "Kristopher" wrote in message news:caf9u7z_bldusnq7c0mvtoxyjpqopa+tmatgqrb7yqeips11...@mail.gmail.com... On Wed, Jan 21, 2015 at 9:5

Re: [PHP-DEV] [PATCH] Fix uninitalized variables reads. See CWE-457 for more info.

2015-01-22 Thread Joshua Rogers
On 22/01/15 21:36, Yasuo Ohgaki wrote: > > Could you send pull request from github? https://github.com/php/php-src/pull/1012 > It's not required strictly, but if you can includes tests, it would be > great. No tests. It is "undefined behaviour." Thanks, -- -- Joshua Rogers

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-22 Thread Arvids Godjuks
2015-01-21 19:21 GMT+02:00 Tony Marston : > "Kristopher" wrote in message news:CAF9U7z_BLDusnq7c0mVToxyJpqOpa+ > tmatgqrb7yqeips11...@mail.gmail.com... > >> >> On Wed, Jan 21, 2015 at 9:50 AM, Tony Marston >> wrote: >> >> >>> You are totally missing the point. It is the principle of having to sp

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-22 Thread Arvids Godjuks
2015-01-22 15:22 GMT+02:00 Arvids Godjuks : > 2015-01-21 19:21 GMT+02:00 Tony Marston : > >> "Kristopher" wrote in message news:CAF9U7z_BLDusnq7c0mVToxyJpqOpa+ >> tmatgqrb7yqeips11...@mail.gmail.com... >> >>> >>> On Wed, Jan 21, 2015 at 9:50 AM, Tony Marston >>> wrote: >>> >>> You are total

[PHP-DEV] Constant-Time Encoding Functions

2015-01-22 Thread Scott Arciszewski
Hi everybody, I've squashed and rebased my pull request that adds a cache-timing-safe bin2hex implementation (named ts_bin2hex) to PHP. https://github.com/php/php-src/pull/909 Before I put more effort into the inverse operation (which, from what I can tell, is already constant-time), does anyone

Re: [PHP-DEV] Enable error_handler callback parameters to be passed by reference

2015-01-22 Thread reeze
I like the idea, we have the similar scenario, we need to print request log id to the log, so I just made a PR to implement this: https://github.com/php/php-src/pull/1018 the PR is against master, but I think this could also been in 5.5. On 22 January 2015 at 18:41, Yasuo Ohgaki wrote: > Hi Th

[PHP-DEV] [RFC] pecl_http

2015-01-22 Thread Michael Wallner
Hi! Now, that I'm mostly done with porting pecl/http [1] and dependencies (propro [2] and raphf [3]) to ZE3 I'd like to restart discussion on the topic, whether it is feasible to add pecl_http as a bundled extension to the core. https://wiki.php.net/rfc/pecl_http [1] https://github.com/php/pecl-

[PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Rasmus Lerdorf
By installing a couple of apps (Wordpress-4.1, Drupal8 and Moodle - there are still some issues in Moodle I haven't figured out yet) on a box we've tracked down some bugs over the last couple of days. It would be really useful if we got more eyes on this. Install php7, then install any random app a

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Sebastian Bergmann
Am 22.01.2015 um 18:05 schrieb Rasmus Lerdorf: > It would be really useful if we got more eyes on this. Install php7, > then install any random app and see how it goes. It's even easier to check whether a component or framework has issues with PHP 7: simply run the respective test suite with PHP

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Julien Pauli
On Thu, Jan 22, 2015 at 6:36 PM, Sebastian Bergmann wrote: > Am 22.01.2015 um 18:05 schrieb Rasmus Lerdorf: > > It would be really useful if we got more eyes on this. Install php7, > > then install any random app and see how it goes. > > It's even easier to check whether a component or framework

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-22 Thread Tony Marston
"Arvids Godjuks" wrote in message news:CAL0xaBFDOP0402T06DJLjbmv6CgsS+xcnY69=szrzts5br5...@mail.gmail.com... 2015-01-22 15:22 GMT+02:00 Arvids Godjuks : 2015-01-21 19:21 GMT+02:00 Tony Marston : "Kristopher" wrote in message news:CAF9U7z_BLDusnq7c0mVToxyJpqOpa+ tmatgqrb7yqeips11...@mail.gm

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Matteo Beccati
Hi, On 22/01/2015 18:36, Sebastian Bergmann wrote: -+'obj' => stdClass Object &6a6ff9c86911d926 () + 'obj' => stdClass Object &6a6ff9c86911d926 () 'inf' => null ) --'6a6ff9c86911d926' => Array

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Levi Morrison
> I had to quarantine a couple of tests in Doctrine and PHPUnit as they both > depend on the re-usage of the hashes returned by spl_object_hash(), which > shouldn't actually be depended upon (am I right dmitry?). I'm not Dmitry, but I am fairly certain you should not rely on hashes being reused.

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Matteo Beccati
On 22/01/2015 19:32, Levi Morrison wrote: I had to quarantine a couple of tests in Doctrine and PHPUnit as they both depend on the re-usage of the hashes returned by spl_object_hash(), which shouldn't actually be depended upon (am I right dmitry?). I'm not Dmitry, but I am fairly certain you sh

Re: [PHP-DEV] [RFC] pecl_http

2015-01-22 Thread Levi Morrison
> Now, that I'm mostly done with porting pecl/http [1] and dependencies > (propro [2] and raphf [3]) to ZE3 I'd like to restart discussion on the > topic, whether it is feasible to add pecl_http as a bundled extension to > the core. > > https://wiki.php.net/rfc/pecl_http The RFC doesn't mention if

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Dmitry Stogov
Hi, Our attempt to run Drupal-8 today, disclosed at least 3 new problems. 2 of them must be already fixed, but I know we must have a lot of other problems uncovered by our test suite. Every new tested app my trigger something new. The more attention we draw now the better quality we will provide.

[PHP-DEV] commit e21fefde381cdd64dc93116440f3ee159c721fa1 breaks tests

2015-01-22 Thread Stanislav Malyshev
Hi! Looks like commit e21fefde381cdd64dc93116440f3ee159c721fa1 leads to 3 tests broken on CI: Bug #54268 (Double free when destroy_zend_class fails) [Zend/tests/bug54268.phpt] Bug #41970 (call_user_func_*() leaks on failure) [ext/standard/tests/general_functions/bug41970.phpt] sem_acquire with no

[PHP-DEV] Re: commit e21fefde381cdd64dc93116440f3ee159c721fa1 breaks tests

2015-01-22 Thread Dmitry Stogov
All these tests pass for me (with and without valgrind). Please, send me the link to Travis report. Thanks. Dmitry. On Thu, Jan 22, 2015 at 10:42 PM, Stanislav Malyshev wrote: > Hi! > > Looks like commit e21fefde381cdd64dc93116440f3ee159c721fa1 leads to 3 > tests broken on CI: > > Bug #54268 (D

[PHP-DEV] Re: commit e21fefde381cdd64dc93116440f3ee159c721fa1 breaks tests

2015-01-22 Thread Stanislav Malyshev
Hi! > All these tests pass for me (with and without valgrind). > Please, send me the link to Travis report. See e.g. https://travis-ci.org/php/php-src/jobs/47945775 (in general, Travis CI is at https://travis-ci.org/php/php-src/builds ) - now different ones fail and one of them is a segfault. --

Re: [PHP-DEV] Re: Help - gcc mystery in ext/imap

2015-01-22 Thread Stanislav Malyshev
Hi! > Should we use size_t/ptrdiff_t everywhere applicable? We should use it everywhere where we deal with zend_string and such - i.e. where the size_t parameter is expected. If it's related to outside library - we should use its type and check (e.g. ICU uses int32_t). For internal things, I gue

Re: [PHP-DEV] Inconsistencies in callable, call_user_func and direct variable calls

2015-01-22 Thread Stanislav Malyshev
Hi! > It’s technically a 'language change’ and would affect the language > specification. That said, it seems rather “no-brainer”. I think it makes a lot of sense to have call_user_func() and $a() work identically. I'm not sure though if it should be done by adding 'foo::bar' to $a() or removing

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Lester Caine
On 22/01/15 17:05, Rasmus Lerdorf wrote: > Install php7, then install any random app and see how it goes. When I can actually run my infrastructure on PHP7 then I could at least see if there is a performance improvement. Although I think only interbase is left on the unavailable list. imagick is n

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Florian Anderiasch
On 22.01.2015 18:05, Rasmus Lerdorf wrote: > By installing a couple of apps (Wordpress-4.1, Drupal8 and Moodle - > there are still some issues in Moodle I haven't figured out yet) on a > box we've tracked down some bugs over the last couple of days. It would > be really useful if we got more eyes o

[PHP-DEV] Re: PHP7 Homework for everyone reading this list

2015-01-22 Thread Jan Ehrhardt
Rasmus Lerdorf in php.internals (Thu, 22 Jan 2015 09:05:28 -0800): >Hopefully everyone here knows how to compile from git and get things up >and running. I would love to test a Windows build with all kinds of extensions if there was a consistent way to find out which branch I'd have to checkout. F

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Benjamin Eberlei
On Thu, Jan 22, 2015 at 7:32 PM, Levi Morrison wrote: > > I had to quarantine a couple of tests in Doctrine and PHPUnit as they > both > > depend on the re-usage of the hashes returned by spl_object_hash(), which > > shouldn't actually be depended upon (am I right dmitry?). > > I'm not Dmitry, bu

Re: [PHP-DEV] [RFC][Vote] Return Types

2015-01-22 Thread Pascal Martin, AFUP
On 14/01/2015 10:18, Levi Morrison wrote: I have moved the Return Types RFC[1] into voting phase. A few changes have happened since it was originally announced but have been covered by discussion. Hi, After discussing this RFC between members of AFUP, we are +1. Once this is done, extending i

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Dan Ackroyd
On 22 January 2015 at 21:07, Lester Caine wrote: > imagick is now available? Not yet. I'll try to finish it off before the end of the weekend. Most of the work was done earlier, but I need to add the changes for the Native TLS. btw this request to update the PHPNG upgrading guide is still open:

[PHP-DEV] Removing base class from session handler

2015-01-22 Thread Yasuo Ohgaki
Hi all, I would like to propose removal of SessionHandler object. PHP7 is perfect opportunity. Session module uses "previous save handler" as it's base class of SessionHandler object. e.g. ini_set('session.save_handler','files); $handler = new SessionHandler; // files save handler functions are u

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Larry Garfield
On 01/19/2015 08:29 AM, Andrea Faulds wrote: Hey Nikita, On 19 Jan 2015, at 14:07, Nikita Popov wrote: I like the idea behind this (exposing internal compare_function), but I don't want to have an extra operator for a minor use case. Please just introduce a function instead. I originally w

Re: [PHP-DEV] in Operator

2015-01-22 Thread Larry Garfield
On 01/20/2015 09:42 AM, Rowan Collins wrote: Mike Willbanks wrote on 20/01/2015 03:30: I am very familiar with the in operator. However, the implementation would be incomplete without handling loops via the in operator. Many people when seeing an in operator also think of JavaScript. In that

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Andrea Faulds
Hi Larry, > On 22 Jan 2015, at 22:48, Larry Garfield wrote: > > This looks potentially quite useful, especially for multi-stage comparisons > as you note. Mainly it would mean I don't have to remember which direction > is positive or negative, as I can never get that right without looking it

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Larry Garfield
On 01/22/2015 05:39 PM, Andrea Faulds wrote: Hi Larry, On 22 Jan 2015, at 22:48, Larry Garfield wrote: This looks potentially quite useful, especially for multi-stage comparisons as you note. Mainly it would mean I don't have to remember which direction is positive or negative, as I can ne

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Andrea Faulds
Hi again, > On 22 Jan 2015, at 23:47, Larry Garfield wrote: > > Assuming it's accurate and I'm understanding you correctly, I think the > following would be a sufficient statement for the RFC: > > - > The behavior of this operator with mixed types is such that the following two > snippets

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Yasuo Ohgaki
Hi Andrea, On Mon, Jan 19, 2015 at 5:28 PM, Andrea Faulds wrote: > This is a reboot of Davey Shafik’s RFC (with permission). After recent > discussions about sort functions, I was inspired to bring this back up, as > I think it would be a useful feature. > > The RFC is here: https://wiki.php.net

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Yasuo Ohgaki
Hi all, On Fri, Jan 23, 2015 at 7:48 AM, Larry Garfield wrote: > The examples say nothing about mixing types, though. Eg, what would these > return: > > return 0 <=> "0" > > return "" <=> 0 > > return 1 <=> [1, 2, 3] > > Ignoring object property names and going by the order of the property > de

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Rasmus Lerdorf
On 01/22/2015 02:30 PM, Dan Ackroyd wrote: > On 22 January 2015 at 21:07, Lester Caine wrote: >> imagick is now available? > > Not yet. I'll try to finish it off before the end of the weekend. Most > of the work was done earlier, but I need to add the changes for the > Native TLS. > > btw this r

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Andrea Faulds
Hey Yasuo, > On 23 Jan 2015, at 00:07, Yasuo Ohgaki wrote: > > Ruby has it. Semantics is the same. > http://ruby-doc.org/core-1.9.3/Comparable.html > > PERL has it. Semantics is the same. > http://perldoc.perl.org/perlop.html#Operator-Precedence-and-Associativity Yep, and I mentioned as much.

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Andrea Faulds
Hi Yasuo, > On 23 Jan 2015, at 00:16, Yasuo Ohgaki wrote: > > Hi all, > > On Fri, Jan 23, 2015 at 7:48 AM, Larry Garfield > wrote: > >> The examples say nothing about mixing types, though. Eg, what would these >> return: >> >> return 0 <=> "0" >> >> return "" <=> 0 >> >> return 1 <=> [1,

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Yasuo Ohgaki
On Fri, Jan 23, 2015 at 9:43 AM, Yasuo Ohgaki wrote: > Ok. Now I understand. Since we don't/can't define strictly typed > less/greater than operator, > it makes sense. It can be handles > I always realize silly mistake after I sent mails :( It can be handled as > > if (get_type($a) != get_type($

Re: [PHP-DEV] [RFC] Combined Comparison (Spaceship) Operator

2015-01-22 Thread Yasuo Ohgaki
Hi Andrea, On Fri, Jan 23, 2015 at 9:24 AM, Andrea Faulds wrote: > Having it be the same as === would be inconsistent with our existing > sorting and comparison behaviour, so I don’t think it should be changed. If > we made it strict like that, we’d also have to define a strict < and > as > well

[PHP-DEV] PHP 5.6.5 is available

2015-01-22 Thread Ferenc Kovacs
Hello! The PHP development team announces the immediate availability of PHP 5.6.5. This release fixes several bugs and three CVE. All PHP 5.6 users are encouraged to upgrade to this version. For source downloads of PHP 5.6.5 please visit our downloads page: http://www.php.net/downloads.php Wind

[PHP-DEV] Identify timing-safe function candidates

2015-01-22 Thread Scott Arciszewski
As per the conversation on this Pull Request https://github.com/php/php-src/pull/909#issuecomment-71077928 What functions are involved in real world PHP applications (frameworks, popular CMSes, etc) that operate on encoded encryption keys that might benefit from having a timing-safe implementation

Re: [PHP-DEV] [RFC] pecl_http

2015-01-22 Thread Pierre Joye
On Thu, Jan 22, 2015 at 5:32 PM, Michael Wallner wrote: > Hi! > > Now, that I'm mostly done with porting pecl/http [1] and dependencies > (propro [2] and raphf [3]) to ZE3 I'd like to restart discussion on the > topic, whether it is feasible to add pecl_http as a bundled extension to > the core. >

Re: [PHP-DEV] in Operator

2015-01-22 Thread Yasuo Ohgaki
Hi Niklas, On Mon, Jan 19, 2015 at 9:42 AM, Niklas Keller wrote: > I'd like to propose a new feature to PHP: The in Operator > Bob mentioned a few weeks ago he wants such an operator in PHP and today I > stumbled over > > http://nikic.github.io/2012/07/27/How-to-add-new-syntactic-features-to-PHP

Re: [PHP-DEV] [RFC] pecl_http

2015-01-22 Thread Yasuo Ohgaki
Hi Mike, On Fri, Jan 23, 2015 at 1:32 AM, Michael Wallner wrote: > Now, that I'm mostly done with porting pecl/http [1] and dependencies > (propro [2] and raphf [3]) to ZE3 I'd like to restart discussion on the > topic, whether it is feasible to add pecl_http as a bundled extension to > the core

[PHP-DEV] PHP 5.4.37 Released

2015-01-22 Thread Stanislav Malyshev
Hello! The PHP development team announces the immediate availability of PHP 5.4.37. Six security-related bugs were fixed in this release, including CVE-2015-0231, CVE-2014-9427 and CVE-2015-0232. All PHP 5.4 users are encouraged to upgrade to this version. For source downloads of PHP 5.4.37 pleas

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Juan Basso
Trying to run phpunit on the latest CakePHP 3 gives a lot of errors of this type (not on every test case): php: /.../php-src/Zend/zend_gc.c:144: gc_possible_root: Assertion `((zend_refcounted*)(ref))->u.v.type == 7 || ((zend_refcounted*)(ref))->u.v.type == 8' failed. This errors happens after the

Re: [PHP-DEV] Removing base class from session handler

2015-01-22 Thread Stanislav Malyshev
Hi! > User script must have access the struct(PS(mod_data)) to extend base class. Can't I extend the base class and then do something in overriding methods and call parent, or override some methods but not others and thus have the original methods still work just fine? > In conclusion, SessionHa

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Juan Basso
I could isolate the problem. Here is a script to reproduce: https://gist.github.com/jrbasso/031fffc8f5eeaf872d4e The issue seems to be related when a new instance is loaded and then get_class_vars is called for the class holding the instance. Removing any of the lines from the static method avoids

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Pierre Joye
On Jan 23, 2015 12:17 PM, "Juan Basso" wrote: > > I could isolate the problem. Here is a script to reproduce: > https://gist.github.com/jrbasso/031fffc8f5eeaf872d4e > > The issue seems to be related when a new instance is loaded and then > get_class_vars is called for the class holding the instanc

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Xinchen Hui
Hey: On Fri, Jan 23, 2015 at 1:23 PM, Pierre Joye wrote: > On Jan 23, 2015 12:17 PM, "Juan Basso" wrote: >> >> I could isolate the problem. Here is a script to reproduce: >> https://gist.github.com/jrbasso/031fffc8f5eeaf872d4e >> >> The issue seems to be related when a new instance is loaded a

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Xinchen Hui
Hey: On Fri, Jan 23, 2015 at 1:17 PM, Juan Basso wrote: > I could isolate the problem. Here is a script to reproduce: > https://gist.github.com/jrbasso/031fffc8f5eeaf872d4e > > The issue seems to be related when a new instance is loaded and then > get_class_vars is called for the class holding t

Re: [PHP-DEV] PHP7 Homework for everyone reading this list

2015-01-22 Thread Juan Basso
Yes, just tested after your change and it solved the problem. Thanks for the quick fix. On Fri, Jan 23, 2015 at 12:50 AM, Xinchen Hui wrote: > Hey: > > > On Fri, Jan 23, 2015 at 1:17 PM, Juan Basso wrote: > > I could isolate the problem. Here is a script to reproduce: > > https://gist.github.co

Re: [PHP-DEV] Identify timing-safe function candidates

2015-01-22 Thread Yasuo Ohgaki
Hi all and Scott, This mail is for all mostly. On Fri, Jan 23, 2015 at 10:37 AM, Scott Arciszewski wrote: > As per the conversation on this Pull Request > https://github.com/php/php-src/pull/909#issuecomment-71077928 > > What functions are involved in real world PHP applications (frameworks, >

Re: [PHP-DEV] Removing base class from session handler

2015-01-22 Thread Yasuo Ohgaki
Hi Stas, On Fri, Jan 23, 2015 at 2:00 PM, Stanislav Malyshev wrote: > > User script must have access the struct(PS(mod_data)) to extend base > class. > > Can't I extend the base class and then do something in overriding > methods and call parent, or override some methods but not others and > thu

Re: [PHP-DEV] Casting a PHP type, new SAPI

2015-01-22 Thread Kevin Ingwersen (Ingwie Phoenix)
> Am 20.01.2015 um 23:11 schrieb Johannes Schlüter : > > Hi, > > On Tue, 2015-01-20 at 06:36 +0100, Kevin Ingwersen (Ingwie Phoenix) > wrote: >> Today I have started to concept a new SAPI which I have wanted to do >> in quite a while now. To learn more, here is a README: >> https://github.com/In

Re: [PHP-DEV] Removing base class from session handler

2015-01-22 Thread Stanislav Malyshev
Hi! > User may extend SessionHandler class like > > class MySession extends SessionHandler {} > > but user cannot extend base class(SessionHandler) capability because > user script > cannot access to PS(mod_data). Not sure what you mean by that. Absence of access to PS(mod_data) certainly doe

Re: [PHP-DEV] Enable error_handler callback parameters to be passed by reference

2015-01-22 Thread Thomas Bley
Thanks I'll draft a RFC during the weekend. Regards Thomas reeze wrote on 22.01.2015 17:01: > I like the idea, we have the similar scenario, we need to print request log > id to the log, > > > so I just made a PR to implement this: > https://github.com/php/php-src/pull/1018 >