On Sat, Sep 7, 2013 at 5:29 AM, Matthew Leverton wrote:
>
> The big difference here is if I accept an options array, I understand
> that the keys are important and would never break backward
> compatibility by changing a parameter name. This isn't a case of "if
> you don't like it, then don't use
hi!
On Fri, Sep 6, 2013 at 6:39 PM, Nikita Popov wrote:
> Hi internals!
>
> I created an RFC and preliminary implementation for named parameters:
>
> https://wiki.php.net/rfc/named_params
>
> The RFC and implementation are not yet complete. I mainly want to have
> feedback on the idea in gene
Hi Leigh,
On Sat, Sep 7, 2013 at 2:56 PM, Leigh wrote:
> Looks like the rfc author was unable to implement it himself at the time
> of the proposal.
>
> The last thing in the discussion thread looks like "implement it in PECL
> first, and it might get bundled later"
>
> http://marc.info/?l=php-i
Hi,
On Sep 7, 2013 10:35 AM, "Yasuo Ohgaki" wrote:
>
> Hi Leigh,
>
> On Sat, Sep 7, 2013 at 2:56 PM, Leigh wrote:
>
> > Looks like the rfc author was unable to implement it himself at the time
> > of the proposal.
> >
> > The last thing in the discussion thread looks like "implement it in PECL
>
On 06/09/2013 20:58, Matthew Leverton wrote:
What I don't like about named parameters is that if I build a library,
now even my parameter names are unchangeable if I don't want to break
any backward compatibility, since I never know if somebody will decide
to call my single parameter method with
> It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc.
>
> Any comments?
Please, don't go down this route. You do not want one class to escape all
kinds of data; delegate each type of escaping to its own class:
JavaScriptEscaper->escape();
PhpEscaper->escape();
HtmlEscaper->escap
Hi internals,
I realized we could not retrieve php_json_serializable_ce from other
extension module. JsonSerializeable interface is easy to serialize with
`json_encode`. So I want to adding getter function.
The patch can be found here:
https://github.com/chobie/php-src/compare/adding-jsonseriali
On Sat, Sep 7, 2013 at 5:43 PM, chobie wrote:
> Hi internals,
>
> I realized we could not retrieve php_json_serializable_ce from other
> extension module. JsonSerializeable interface is easy to serialize with
> `json_encode`. So I want to adding getter function.
>
> The patch can be found here:
On 07/09/2013 15:41, Levi Morrison wrote:
It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc.
Any comments?
Please, don't go down this route. You do not want one class to escape all
kinds of data; delegate each type of escaping to its own class:
JavaScriptEscaper->escape();
On Sat, 07 Sep 2013 20:08:45 +0400, Michael John Burgess
wrote:
On 07/09/2013 15:41, Levi Morrison wrote:
It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc.
Any comments?
Please, don't go down this route. You do not want one class to escape
all
kinds of data; delegat
On Sat, Sep 7, 2013 at 10:08 AM, Michael John Burgess <
mich...@mjburgess.co.uk> wrote:
> On 07/09/2013 15:41, Levi Morrison wrote:
>
>> It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc.
>>>
>>> Any comments?
>>>
>>
>>
>> Please, don't go down this route. You do not want one cla
On Sat, Sep 7, 2013 at 10:36 AM, Nikita Nefedov wrote:
> On Sat, 07 Sep 2013 20:08:45 +0400, Michael John Burgess <
> mich...@mjburgess.co.uk> wrote:
>
> On 07/09/2013 15:41, Levi Morrison wrote:
>>
>>> It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc.
Any comments?
Yea, but my php binary doesn't export php_json_serializable_ce. Did I
missed something?
nm /Users/chobie/.phpenv/versions/5.5-zts-debug/bin/php | grep
php_json_serializable_ce
000100c00460 s _php_json_serializable_ce
2013/9/8 Nikita Popov
> On Sat, Sep 7, 2013 at 5:43 PM, chobie wrote:
>
On Sat, Sep 7, 2013 at 5:05 AM, Michael John Burgess
wrote:
> The position of parameters and the name of the function must already be
> maintained... I dont see why appropriately naming variables is such a
> burden.
>
I wouldn't necessarily make this objection if this were a day-1
feature. But it
On Sat, Sep 7, 2013 at 6:43 PM, Levi Morrison wrote:
> On Sat, Sep 7, 2013 at 10:36 AM, Nikita Nefedov wrote:
>
>> On Sat, 07 Sep 2013 20:08:45 +0400, Michael John Burgess <
>> mich...@mjburgess.co.uk> wrote:
>>
>> On 07/09/2013 15:41, Levi Morrison wrote:
>>>
It looks nicer than Escaper::e
On Sat, 2013-09-07 at 17:46 +0200, Nikita Popov wrote:
> The code has an "extern zend_class_entry *php_json_serializable_ce;" right
> above that line. Shouldn't that be enough?
that only affects code in the same linker run (executable binary or .so)
as weak the linker to hide symbols. For stuff th
Hi,
I ran into 32-bit problems, too, when working with >2GB files (in this
case, raw DVD ISO images) on a 32-bit system (I couldn't find a
reliable(!!) way to read a 4-byte absolute offset and seek to it).
Of course, this warning is mentioned in the manpage, but really, not
having at least a class
On Sat, Sep 7, 2013 at 6:55 PM, Matthew Leverton wrote:
>
> The OCD in me shudders to think about now having to parse through
> people's code like:
>
> substr('length' => 1, 'string' => 'Hello World');
>
Hi, Matthew
Wouldn't this just fail, because one required parameter is omitted?
You can jus
Hi,
On Sat, Sep 7, 2013 at 6:44 PM, Marco Schuster wrote:
>
> I ran into 32-bit problems, too, when working with >2GB files (in this
> case, raw DVD ISO images) on a 32-bit system (I couldn't find a
> reliable(!!) way to read a 4-byte absolute offset and seek to it).
> Of course, this warning is
Hi Nikita
First of all, thanks for your proposal.
I'd like to make some comments, see below.
> -Original Message-
> From: Lazare Inepologlou [mailto:linep...@gmail.com]
> Sent: Friday, September 06, 2013 7:55 PM
> To: Adam Harvey
> Cc: Nikita Popov; PHP internals
> Subject: Re: [PHP-DEV]
> -Original Message-
> From: a...@adamharvey.name [mailto:a...@adamharvey.name] On
> Behalf Of Adam Harvey
> Sent: Friday, September 06, 2013 10:11 PM
> To: Dan Ackroyd
> Cc: Nikita Popov; PHP internals
> Subject: Re: [PHP-DEV] [RFC] Named parameters
>
> On 6 September 2013 13:01, Dan Ackr
> -Original Message-
> From: Robert Stoll [mailto:rst...@tutteli.ch]
> Sent: Sunday, September 08, 2013 12:36 AM
> To: 'Adam Harvey'; 'Dan Ackroyd'
> Cc: 'Nikita Popov'; 'PHP internals'
> Subject: RE: [PHP-DEV] [RFC] Named parameters
>
> > -Original Message-
> > From: a...@adamha
On 06-09-2013 23:54, Nikita Popov wrote:
On Fri, Sep 6, 2013 at 11:23 PM, Gustavo Lopes wrote:
I think the correct course of action is just to drop support for extra
named arguments. Just add an extra array argument to the function and you
have equivalent functionality without having to go thro
23 matches
Mail list logo
