Re: [PHP-DEV] Extension loading improvements

2013-04-11 Thread Julien Pauli
On Wed, Apr 10, 2013 at 7:14 PM, Dmitry Stogov wrote: > Hi, > > 1) I didn't get why do we need fprintf("Loaded/Unloaded extension"). It'll > break all the tests in DEBUG mode > Great catch > > 2) zend_error() may work through SAPI handler (e.g. for FastCGI sapi it > may try to send error messa

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Julien Pauli
On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye wrote: > On Wed, Apr 10, 2013 at 6:46 PM, Julien Pauli wrote: > > > Beta3 has been taggued with curl wrappers, and with the new > > CURL_WRAPPERS_ENABLED constant :-p > > > > Do we all agree to remove that feature (meaning moving it to a branch, or >

[PHP-DEV] PHP 5.5 beta3 is here

2013-04-11 Thread Julien Pauli
Hi Internals, PHP 5.5.0 Beta 3 has been released for testing. It fixes some bugs against beta 2. You'll find details in the NEWS file. The packages can be found at: http://downloads.php.net/dsp and windows packages at http://windows.php.net/qa Please test the release carefully and report

Re: [PHP-DEV] PHP 5.5 beta3 is here

2013-04-11 Thread Paul Dragoonis
Thanks for all your hard work Julien / David. On Thu, Apr 11, 2013 at 9:50 AM, Julien Pauli wrote: > Hi Internals, > > PHP 5.5.0 Beta 3 has been released for testing. It fixes some bugs against > beta 2. > You'll find details in the NEWS file. > > The packages can be found at: > > http://down

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Xinchen Hui
On Thu, Apr 11, 2013 at 4:03 PM, Julien Pauli wrote: > On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye wrote: > >> On Wed, Apr 10, 2013 at 6:46 PM, Julien Pauli wrote: >> >> > Beta3 has been taggued with curl wrappers, and with the new >> > CURL_WRAPPERS_ENABLED constant :-p >> > >> > Do we all ag

Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?

2013-04-11 Thread Laruence
Hey; I think it's a great idea, if all op_arrays in one script share the same literals table, let's say it's main scope 's literals table. then we can make all class entry, function entry share the same constant literal.. image that, same class(function) only need to lookup once in one s

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Kalle Sommer Nielsen
Hi Julien 2013/4/11 Julien Pauli : > Ok, too bad we taggued beta3 with it. I suggest we remove this feature when > going RC so. Huge +1 -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

AW: [PHP-DEV] [RFC] Class instances counter

2013-04-11 Thread Frank Liepert
> It is not entirely clear how the function treats subclasses. Does it > count > only the *direct* instances of a class, or does it also count the > instances > of subclasses? > > class A {} > class B extends A {} > > echo get_objects_count('A'); > // 0 > > $a = new B; > > echo $a instanceof A;

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Pierrick Charron
If you decide to remove it for 5.5 RC, tell me and I'll merge this branch https://github.com/adoy/php-src/tree/remove-curl-wrappers Thanks Pierrick On 11 April 2013 04:03, Julien Pauli wrote: > On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye wrote: > >> On Wed, Apr 10, 2013 at 6:46 PM, Julien Pau

Re: [PHP-DEV] Re: libmagic 5.14 upgrade

2013-04-11 Thread Ondřej Surý
Just a curious question – would it be possible to add some code directly to upstream, so you wouldn't have to engulf yet-another-library into PHP source tree? It's always a security nightmare to have various copies of libraries at various places of the system. Ondrej On Sun, Apr 7, 2013 at 7:44

[PHP-DEV] [PATCH] Add schema default/fixed value support in DOM

2013-04-11 Thread Chris Wright
Good morning/afternoon/evening list I have created a patch to the libxml/DOM extensions to expose the functionality for creating default/fixed values from the XSD schema when validating a document. I have created a PR on GitHub which can be viewed here: https://github.com/php/php-src/pull/325 T

Re: [PHP-DEV] Re: libmagic 5.14 upgrade

2013-04-11 Thread Stas Malyshev
Hi! > Just a curious question – would it be possible to add some code > directly to upstream, so you wouldn't have to engulf > yet-another-library into PHP source tree? > > It's always a security nightmare to have various copies of libraries > at various places of the system. Not sure about what

Re: [PHP-DEV] Re: libmagic 5.14 upgrade

2013-04-11 Thread Pierre Joye
On Thu, Apr 11, 2013 at 5:27 PM, Ondřej Surý wrote: > Just a curious question – would it be possible to add some code > directly to upstream, so you wouldn't have to engulf > yet-another-library into PHP source tree? It is a bit of work to support php's stream upstream. I wanted to do it back the

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Pierre Joye
On Thu, Apr 11, 2013 at 4:54 PM, Pierrick Charron wrote: > If you decide to remove it for 5.5 RC, tell me and I'll merge this branch > https://github.com/adoy/php-src/tree/remove-curl-wrappers s,5.5,all branches, Cheers, -- Pierre @pierrejoye -- PHP Internals - PHP Runtime Development Mailin

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Pierrick Charron
Including 5.3 and 5.4 ?? Pierrick On 11 April 2013 14:12, Pierre Joye wrote: > On Thu, Apr 11, 2013 at 4:54 PM, Pierrick Charron > wrote: > > If you decide to remove it for 5.5 RC, tell me and I'll merge this branch > > https://github.com/adoy/php-src/tree/remove-curl-wrappers > > s,5.5,all br

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Pierre Joye
On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron wrote: > Including 5.3 and 5.4 ?? Yes, why should we have it there? Either it is stable and ready or it is not (as it is now). -- Pierre @pierrejoye -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php

Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?

2013-04-11 Thread Larry Garfield
Speaking as a userspace developer and site admin, I'd be fine with trading a more expensive compilation for a runtime improvement. Even a 100% increase in compilation time would pay for itself over only a dozen or so requests (assuming the runtime improvements are non-trivial, too). Naturally

Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?

2013-04-11 Thread Graham Kelly-Cohn
I don't think this is a safe optimization. In the following case it would output 'b' and not 'a' which is the correct result: a.php: b.php: It is certainly not likely for a constant to be defined twice but PHP currently just issues a notice and continues with the first constant value. On Thu

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Kalle Sommer Nielsen
Hi 2013/4/12 Pierre Joye : > On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron wrote: >> Including 5.3 and 5.4 ?? If removed in 5.3 and 5.4, theres no need for the constant anymore. -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To un

[PHP-DEV] VCS Account Request: rajivgadda

2013-04-11 Thread Rajiv Gadda
writing and editing php source code for optimization. such as facebook hiphop. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?

2013-04-11 Thread Dmitry Stogov
Good point. Thanks. Dmitry. On Fri, Apr 12, 2013 at 3:09 AM, Graham Kelly-Cohn wrote: > I don't think this is a safe optimization. In the following case it would > output 'b' and not 'a' which is the correct result: > > a.php: > define('FOO', 'a'); > include('b.php'); > ?> > > b.php: > define