Just a curious question – would it be possible to add some code directly to upstream, so you wouldn't have to engulf yet-another-library into PHP source tree?
It's always a security nightmare to have various copies of libraries at various places of the system. Ondrej On Sun, Apr 7, 2013 at 7:44 PM, Anatoliy Belsky <a...@php.net> wrote: > Hi, > > Am Samstag, den 06.04.2013, 17:12 -0700 schrieb Stas Malyshev: > >> Looks ok, but I have one question - we have libmagic.patch file there >> which as I understand is supposed to be diff between "our" libmagic and >> upstream libmagic. But this patch does not update it. Is it intentional? >> Will it be updated later? > > > Of course I'll update libmagic.patch before commiting, that's just a > diff command. Didn't do it as that's redundant to ext/fileinfo/libmagic > part in the patch I've sent. > > Thanks for taking time. > > Anatol > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Ondřej Surý <ond...@sury.org> -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
