hi,
On Mon, Jan 24, 2011 at 8:11 PM, Gustavo Lopes wrote:
> Hum? Pierre's change is "correct", but it's also redundant.
It is not redundant. It can even help some compilers or analyzer.
> Please read the C FAQ: http://c-faq.com/null/ptrtest.html
>
> What would be invalid would be testing for a
On Tue, 25 Jan 2011, Pierre Joye wrote:
> Also doing so (testing a == NULL instead of !a) is a common and widely
> adopted practice
Really? I've never written code like that. It's a preference. What you
do in your maintained extensions is up to you, but don't override
other people's preferences
On Tue, Jan 25, 2011 at 4:04 PM, Derick Rethans wrote:
> On Tue, 25 Jan 2011, Pierre Joye wrote:
>
>> Also doing so (testing a == NULL instead of !a) is a common and widely
>> adopted practice
>
> Really? I've never written code like that. It's a preference.
That's not really a surprise.
> What
On Tue, 25 Jan 2011, Pierre Joye wrote:
> Now, as this extension is in the core and had a couple of issues that
> need to be fixed and without affecting the behavior, then I will fix
> them. Features addition or major changes will obviously need review,
> as usual.
if (! tzid)
is *not* a
On Tue, Jan 25, 2011 at 4:10 PM, Derick Rethans wrote:
> On Tue, 25 Jan 2011, Pierre Joye wrote:
>
>> Now, as this extension is in the core and had a couple of issues that
>> need to be fixed and without affecting the behavior, then I will fix
>> them. Features addition or major changes will obvio
hi,
On Mon, Jan 17, 2011 at 5:21 AM, Tommy Pham wrote:
> Thanks Dan. I'll keep it in mind for the future. For interested parties,
> that's found in the official Windows 5.3.3 NTS VC9 build. Works fine with
> the current official 5.3.5 NTS VC9.
5.3.5 was released only to fix this exact bug :-
Pierre,
On 01/25/2011 04:07 PM, Pierre Joye wrote:
> On Tue, Jan 25, 2011 at 4:04 PM, Derick Rethans wrote:
>> On Tue, 25 Jan 2011, Pierre Joye wrote:
>>
>>> Also doing so (testing a == NULL instead of !a) is a common and widely
>>> adopted practice
>>
>> Really? I've never written code like that
On Tue, Jan 25, 2011 at 6:03 PM, Andrey Hristov wrote:
> the first thing to do is to contact the extension maintainer, whoever
> this is. We have karma system and people with php-src access, however it
> is good first to contact the maintainer. On 2-3 occasions you have
> intervened in mysqlnd an
On 01/25/2011 06:37 PM, Pierre Joye wrote:
> On Tue, Jan 25, 2011 at 6:03 PM, Andrey Hristov wrote:
>
>> the first thing to do is to contact the extension maintainer, whoever
>> this is. We have karma system and people with php-src access, however it
>> is good first to contact the maintainer. On
Pierre Joye wrote:
> On Tue, Jan 25, 2011 at 4:10 PM, Derick Rethans wrote:
>> On Tue, 25 Jan 2011, Pierre Joye wrote:
>>
>>> Now, as this extension is in the core and had a couple of issues that
>>> need to be fixed and without affecting the behavior, then I will fix
>>> them. Features addition o
On Tue, Jan 25, 2011 at 7:09 PM, Keisial wrote:
> The change was unrelated to types or castings.
No, but Derick knows what I meant here. I can't count the amount of
times I had to argue about why one thing or another should be done,
like correct casting, floor not being for float, checking mallo
On Tue, 2011-01-25 at 19:09 +0100, Keisial wrote:
> This thread went on bikeshedding about if it's legal C or not.
The question whether the code is legal or not is not bikeshedding.
Valid, correct, code is important. Both for function and for
maintenance.
The questions is cleared: The old code is
Do we have any interesting project for this year, or should we drop
GSOC again this year?
-Hannes
-- Forwarded message --
From: Carol Smith
Date: Mon, Jan 24, 2011 at 23:21
Subject: Google Summer of Code 2011 Announced
To: Google Summer of Code Announce
Hi all,
We're pleased
13 matches
Mail list logo
