Pierre, On 01/25/2011 04:07 PM, Pierre Joye wrote: > On Tue, Jan 25, 2011 at 4:04 PM, Derick Rethans <der...@php.net> wrote: >> On Tue, 25 Jan 2011, Pierre Joye wrote: >> >>> Also doing so (testing a == NULL instead of !a) is a common and widely >>> adopted practice >> >> Really? I've never written code like that. It's a preference. > > That's not really a surprise. > >> What you >> do in your maintained extensions is up to you, but don't override >> other people's preferences in how they test for NULL pointers. It's >> perfectly legal to do it like it was. I'll be changing it back. > > You don't want one to commit in "your" extension? That's fine with me, > but then keep it in pecl.
the first thing to do is to contact the extension maintainer, whoever this is. We have karma system and people with php-src access, however it is good first to contact the maintainer. On 2-3 occasions you have intervened in mysqlnd and broke some glass - recently broken ZTS debug build (which is strange because you as Win dev should build ZTS continously, even debug) and the other thing was the NULL logic. The latter broke 112 tests, it was hard to miss it, if you have tried to run the test suite. > Now, as this extension is in the core and had a couple of issues that > need to be fixed and without affecting the behavior, then I will fix > them. Features addition or major changes will obviously need review, > as usual. > > Thanks for wasting my time with stupid things like that, > > Have a nice day, > > Cheers, Best, Andrey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
