Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-15 Thread Richard Lynch
On Tue, November 14, 2006 4:42 am, Dmitry Stogov wrote: > The following patch adds new INI directive for CGI SAPI. > It may enable/disable check for shebang line (#! /usr/bin/php) and as > result > improve performance of FastCGI. > > I set the default value for this directive to 1 (that means check

RE: [PHP-DEV] cgi.check_shebang_line default value

2006-11-15 Thread Dmitry Stogov
ts.php.net; 'Andi Gutmans'; 'Stanislav Malyshev' > Subject: RE: [PHP-DEV] cgi.check_shebang_line default value > > > The patch allow save one read() and one seek() syscall for > each request. On hello.php () I > got 430 req/sec without patch and 530 req/sec with

RE: [PHP-DEV] cgi.check_shebang_line default value

2006-11-15 Thread Dmitry Stogov
. > -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Tuesday, November 14, 2006 11:15 PM > To: Dmitry Stogov > Cc: internals@lists.php.net; Andi Gutmans; Stanislav Malyshev > Subject: Re: [PHP-DEV] cgi.check_shebang_line default value > > > Hello

Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-15 Thread Derick Rethans
On Tue, 14 Nov 2006, Ilia Alshanetsky wrote: > I think people who want the performance can disable the check, but we should > not break BC, certainly not at a patch level release. I agree there. Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.ph

RE: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Andi Gutmans
ry Stogov'; internals@lists.php.net; 'Stanislav Malyshev' > Subject: Re: [PHP-DEV] cgi.check_shebang_line default value > > Hello Andi, > > all in all i would actually prefer to have no shebang > support in cgi startin gwith 6 and stick to what we have

Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Marcus Boerger
n > my opinion. > Andi >> -Original Message- >> From: Marcus Boerger [mailto:[EMAIL PROTECTED] >> Sent: Tuesday, November 14, 2006 12:15 PM >> To: Dmitry Stogov >> Cc: internals@lists.php.net; Andi Gutmans; Stanislav Malyshev >> Subject: Re: [PH

RE: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Andi Gutmans
that's a waste in my opinion. Andi > -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Tuesday, November 14, 2006 12:15 PM > To: Dmitry Stogov > Cc: internals@lists.php.net; Andi Gutmans; Stanislav Malyshev > Subject: Re: [PHP-DEV] cgi.check_s

Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Stanislav Malyshev
> why not use a command-line switch for itinstead an INI option? Because FCGI can't use command-line switches in many situations. And even if it's allowed it's usually harder to set and easier to miss. -- Stanislav Malyshev, Zend Products Engineer [EMAIL PROTECTED] http://www.zend.com/ -- P

Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Pierre
Hello, On 11/14/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: Hello Stanislav, why not use a command-line switch for itinstead an INI option? An ini setting is perfectly valid in this case, it can/should be set to off in 5.2.x and enabled in head. A command line options is really a bad alter

Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Marcus Boerger
Hello Stanislav, why not use a command-line switch for itinstead an INI option? best regards marcus Tuesday, November 14, 2006, 10:53:26 PM, you wrote: >> i thought we were avoiding new inisettings. And also having a new INI >> option takes some time. So is the result really faster? > Saves

Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Stanislav Malyshev
i thought we were avoiding new inisettings. And also having a new INI option takes some time. So is the result really faster? Saves FS access per request. New INI cost is minimal. Now, I think avoiding INI makes most sense for INIs that change app behavior. This INI changes almost nothing ex

Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Marcus Boerger
Hello Dmitry, i thought we were avoiding new inisettings. And also having a new INI option takes some time. So is the result really faster? best regards marcus Tuesday, November 14, 2006, 11:42:08 AM, you wrote: > Hi, > The following patch adds new INI directive for CGI SAPI. > It may enable

Re: [PHP-DEV] cgi.check_shebang_line default value

2006-11-14 Thread Ilia Alshanetsky
I think people who want the performance can disable the check, but we should not break BC, certainly not at a patch level release. On 14-Nov-06, at 5:42 AM, Dmitry Stogov wrote: Hi, The following patch adds new INI directive for CGI SAPI. It may enable/disable check for shebang line (#! /us