I think in this case it makes very much sense. It will allow 99.9% of the people who don't use shebang for Web apps to gain better performance (less system calls which is important on highly loaded servers) and allow people to keep full compatibility if they happen to be odd and use shebang in Web apps. This is absolutely what we've been using INI for in the past.
We can just keep this on by default so that we don't break BC, although I think it'd be good to have it off in php.ini-recommended. If people very much disagree we can just keep it on by default always but that's a waste in my opinion. Andi > -----Original Message----- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Tuesday, November 14, 2006 12:15 PM > To: Dmitry Stogov > Cc: internals@lists.php.net; Andi Gutmans; Stanislav Malyshev > Subject: Re: [PHP-DEV] cgi.check_shebang_line default value > > Hello Dmitry, > > i thought we were avoiding new inisettings. And also having > a new INI option takes some time. So is the result really faster? > > best regards > marcus > > Tuesday, November 14, 2006, 11:42:08 AM, you wrote: > > > Hi, > > > The following patch adds new INI directive for CGI SAPI. > > It may enable/disable check for shebang line (#! > /usr/bin/php) and as > > result improve performance of FastCGI. > > > I set the default value for this directive to 1 (that means > check file > > on each request) to not break previous behavior. > > However may be it is better to set default value to 0. That means > > break previous behavior but improve performance by default. > > > Any suggestions? > > > Thanks. Dmitry. > > >> -----Original Message----- > >> From: Dmitry Stogov [mailto:[EMAIL PROTECTED] > >> Sent: Tuesday, November 14, 2006 1:32 PM > >> To: php-cvs@lists.php.net > >> Subject: [PHP-CVS] cvs: php-src /sapi/cgi cgi_main.c > >> > >> > >> dmitry Tue Nov 14 10:32:11 2006 UTC > >> > >> Modified files: > >> /php-src/sapi/cgi cgi_main.c > >> Log: > >> cgi.* and fastcgi.* directives are moved to INI subsystem. > >> The new directive cgi.check_shebang_line can be used to ommiting > >> checnk for "#! /usr/bin/php" line. > >> > >> > >> > > > > Best regards, > Marcus > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
