Re: [PHP-DEV] Variable fetch optimization

2004-10-06 Thread Andi Gutmans
At 03:15 PM 10/6/2004 -0700, Sterling Hughes wrote: Yeah, actually Dmitry wrote a script that converted the old executor into the new executor, so the script was already there. I think its that Andi doesn't like the concept (I do like the concept btw), not the work involved. Personally, I'd pr

Re: [PHP-DEV] Variable fetch optimization

2004-10-06 Thread Sterling Hughes
Wez Furlong wrote: I'm a big fan of making the computer do the work on our behalf (that's what it's there for, right?). It shouldn't be a huge problem to write a php script to generate the different executors from a source file. If you're worried about bootstrapping, we can keep the generated file

Re: [PHP-DEV] Variable fetch optimization

2004-10-06 Thread Wez Furlong
I'm a big fan of making the computer do the work on our behalf (that's what it's there for, right?). It shouldn't be a huge problem to write a php script to generate the different executors from a source file. If you're worried about bootstrapping, we can keep the generated files in CVS and/or bu

Re: [PHP-DEV] Variable fetch optimization

2004-10-06 Thread Andrei Zmievski
On Sat, 02 Oct 2004, Thies C. Arntzen wrote: > PS: i really think that the vm should be generated by a script! looking > at what makes most of the patch i really think that we're making > hacking the engine more complex than needed. I agree.. - Andrei -- PHP Internals - PHP Runtime Developmen

Re: [PHP-DEV] Variable fetch optimization

2004-10-04 Thread Andi Gutmans
At 12:44 PM 10/2/2004 +0200, Thies C. Arntzen wrote: before: 34.430 after: 20.126 do i need to say more? (if it really works, which i haven't tested yet) Made another fix (we had to take care of global variables being messed with by extensions). PS: i really think that the vm should be generated

Re: [PHP-DEV] Variable fetch optimization

2004-10-02 Thread Thies C . Arntzen
before: 34.430 after: 20.126 do i need to say more? (if it really works, which i haven't tested yet) great andi! re, tc PS: i really think that the vm should be generated by a script! looking at what makes most of the patch i really think that we're making hacking the engine more complex than nee

Re: [PHP-DEV] Variable fetch optimization

2004-10-01 Thread Andi Gutmans
http://snaps.php.net/~andi/Zend.m4.diff.gz http://snaps.php.net/~andi/cv.diff.gz At 09:31 AM 10/1/2004 -0700, Andi Gutmans wrote: Hi, Attached is a patch to optimize variable fetches (basically it caches the fetches so that variables aren't re-fetched every time, most noticeable in loops with the