Re: [PHP-DEV] Require C11 in PHP 8.4

Hi Levi On Tue, Aug 13, 2024 at 5:00 PM Levi Morrison wrote: > > On Tue, Aug 13, 2024 at 8:17 AM Ilija Tovilo wrote: > > > > Just to state it officially: You object to switching to C11 in 8.4? In > > that case, we'll have to postpone. > > I don't object. I think it's smarter to wait, and do more

Re: [PHP-DEV] Require C11 in PHP 8.4

On Tue, Aug 13, 2024 at 8:17 AM Ilija Tovilo wrote: > > Hi Levi > > On Mon, Aug 12, 2024 at 5:56 PM Levi Morrison > wrote: > > > > Given the timetable, I wouldn't change the C std requirements for 8.4. > > Just to state it officially: You object to switching to C11 in 8.4? In > that case, we'll h

Re: [PHP-DEV] Require C11 in PHP 8.4

Hi Levi On Mon, Aug 12, 2024 at 5:56 PM Levi Morrison wrote: > > Given the timetable, I wouldn't change the C std requirements for 8.4. Just to state it officially: You object to switching to C11 in 8.4? In that case, we'll have to postpone. > I would stop relying on the typedef and forward dec

Re: [PHP-DEV] Require C11 in PHP 8.4

On Sat, Aug 10, 2024 at 6:22 AM Christoph M. Becker wrote: > > On 01.08.2024 at 23:57, Ilija Tovilo wrote: > > > Hence, it seems like it would be ok to bump our C compiler requirement > > to C11. We'd like to make this change before beta 1 if there are no > > objections. There are no immediate pla

Re: [PHP-DEV] Require C11 in PHP 8.4

On Sunday, 11 August 2024 at 17:27, Giovanni Giacobbi wrote: > On Sun, 11 Aug 2024 at 16:12, Ilija Tovilo wrote: > >> Hi Christoph >> >> On Sat, Aug 10, 2024 at 2:19 PM Christoph M. Becker >> wrote: >>> >>> On 01.08.2024 at 23:57, Ilija Tovilo wrote: >>> >>> So skimming the whole discussion[1

Re: [PHP-DEV] Require C11 in PHP 8.4

On Sun, 11 Aug 2024 at 16:12, Ilija Tovilo wrote: > Hi Christoph > > On Sat, Aug 10, 2024 at 2:19 PM Christoph M. Becker > wrote: > > > > On 01.08.2024 at 23:57, Ilija Tovilo wrote: > > > > So skimming the whole discussion[1] it seems that most are generally > > fine with bumping the requirement

Re: [PHP-DEV] Require C11 in PHP 8.4

> Giovanni's remark that this would impact many people was challenged by > Jakub [1] which didn't get a response. I believe it's safe to assume > that this isn't the case. I somehow forgot to link this reference, sorry about that. [1] https://externals.io/message/124706#124717

Re: [PHP-DEV] Require C11 in PHP 8.4

Hi Christoph On Sat, Aug 10, 2024 at 2:19 PM Christoph M. Becker wrote: > > On 01.08.2024 at 23:57, Ilija Tovilo wrote: > > So skimming the whole discussion[1] it seems that most are generally > fine with bumping the requirements to C11, except for Giovanni Giacobbi > (whose draft PR[2] had no fu

Re: [PHP-DEV] Require C11 in PHP 8.4

On 01.08.2024 at 23:57, Ilija Tovilo wrote: > Hence, it seems like it would be ok to bump our C compiler requirement > to C11. We'd like to make this change before beta 1 if there are no > objections. There are no immediate plans to make non-optional use of > other C11 features, although that is c

Re: [PHP-DEV] Require C11 in PHP 8.4

On 06.08.2024 at 22:21, Lanre wrote: > On Thu, Aug 1, 2024 at 4:01 PM Ilija Tovilo wrote: > >> Hence, it seems like it would be ok to bump our C compiler requirement >> to C11. We'd like to make this change before beta 1 if there are no >> objections. There are no immediate plans to make non-opti

Re: [PHP-DEV] Require C11 in PHP 8.4

On Thu, Aug 1, 2024 at 4:01 PM Ilija Tovilo wrote: > Hi everyone > > We've gotten a bug report about compile errors in the PHP 8.4 alpha on > old C99 compilers (and on some modern compilers when passing the > -std=c99 flag). Specifically, C99 does not support typedef > redeclarations, which is a

Re: [PHP-DEV] Require C11 in PHP 8.4

On 06.08.2024 at 15:01, Peter Kokot wrote: > On Mon, 5 Aug 2024 at 19:15, Christoph M. Becker wrote: >> But what about other compilers we support on non Windows platforms >> currently, like clang, Apple's clang, Solaris Studio and maybe some more >> we don't even know about. > > Might be worth no

Re: [PHP-DEV] Require C11 in PHP 8.4

On Tue, Aug 6, 2024 at 12:10 AM Christoph M. Becker wrote: > > On 05.08.2024 at 17:42, Pierre Joye wrote: > > > On Mon, Aug 5, 2024, 10:03 PM Derick Rethans wrote: > > > >> Instead of having to deal with tickets, wouldn't be be easier if the > >> compiler they used works with the features that we

Re: [PHP-DEV] Require C11 in PHP 8.4

On Mon, 5 Aug 2024 at 19:15, Christoph M. Becker wrote: > But what about other compilers we support on non Windows platforms > currently, like clang, Apple's clang, Solaris Studio and maybe some more > we don't even know about. Might be worth noting here that from what I've tested so far that PHP

Re: [PHP-DEV] Require C11 in PHP 8.4

> On 6 Aug 2024, at 18:26, Derick Rethans wrote: > > Normal clang supports the same flag. Apple clang potentially too, but > not currently: > https://opensource.apple.com/source/clang/clang-23/clang/tools/clang/docs/UsersManual.html > — it could be outdated information though. I don't have a

Re: [PHP-DEV] Require C11 in PHP 8.4

On 06.08.2024 at 13:26, Derick Rethans wrote: > Normal clang supports the same flag. Apple clang potentially too, but > not currently: > https://opensource.apple.com/source/clang/clang-23/clang/tools/clang/docs/UsersManual.html > — it could be outdated information though. I don't have a mac to tes

Re: [PHP-DEV] Require C11 in PHP 8.4

On Mon, 5 Aug 2024, Christoph M. Becker wrote: > On 05.08.2024 at 17:42, Pierre Joye wrote: > > > On Mon, Aug 5, 2024, 10:03 PM Derick Rethans wrote: > > > >> Instead of having to deal with tickets, wouldn't be be easier if > >> the compiler they used works with the features that we are using?

Re: [PHP-DEV] Require C11 in PHP 8.4

On 05.08.2024 at 18:42, Levi Morrison wrote: > As a person who wrote some of those atomics, I would definitely prefer > to move to standard C11/C17 atomics at some point in the future and > remove all other fallbacks. The blocker right now is Microsoft Visual > Studio. Although they added C11/C17

Re: [PHP-DEV] Require C11 in PHP 8.4

On 05.08.2024 at 17:42, Pierre Joye wrote: > On Mon, Aug 5, 2024, 10:03 PM Derick Rethans wrote: > >> Instead of having to deal with tickets, wouldn't be be easier if the >> compiler they used works with the features that we are using? That could >> instantly provide a link to the documentation s

Re: [PHP-DEV] Require C11 in PHP 8.4

On Sun, Aug 4, 2024 at 10:05 AM Gina P. Banyard wrote: > > > On Friday, 2 August 2024 at 14:33, Giovanni Giacobbi > wrote: > > On Thu, 1 Aug 2024 at 23:57, Ilija Tovilo wrote: >> >> [...] >> I started fixing these in a PR [1] which required more changes than >> expected. After a short discourse

Re: [PHP-DEV] Require C11 in PHP 8.4

On 05.08.2024 at 16:59, Derick Rethans wrote: > On Mon, 5 Aug 2024, Christoph M. Becker wrote: > >> In my opinion, there is no *need* to enforce this requirement. Just >> having documentation should be sufficient. Users with an old >> compilerr will notice issues (i.e. build failures), and even

Re: [PHP-DEV] Require C11 in PHP 8.4

On Mon, Aug 5, 2024, 10:03 PM Derick Rethans wrote: > Instead of having to deal with tickets, wouldn't be be easier if the > compiler they used works with the features that we are using? That could > instantly provide a link to the documentation saving all of us time. > it is significantly easi

Re: [PHP-DEV] Require C11 in PHP 8.4

On Mon, 5 Aug 2024, Christoph M. Becker wrote: > On 05.08.2024 at 12:49, Derick Rethans wrote: > > > On Thu, 1 Aug 2024, Ilija Tovilo wrote: > > > >> Hence, it seems like it would be ok to bump our C compiler > >> requirement to C11. We'd like to make this change before beta 1 if > >> there are

Re: [PHP-DEV] Require C11 in PHP 8.4

On 05.08.2024 at 12:49, Derick Rethans wrote: > On Thu, 1 Aug 2024, Ilija Tovilo wrote: > >> Hence, it seems like it would be ok to bump our C compiler requirement >> to C11. We'd like to make this change before beta 1 if there are no >> objections. > > How would you enforce that, through configur

Re: [PHP-DEV] Require C11 in PHP 8.4

On Thu, 1 Aug 2024, Ilija Tovilo wrote: > Hence, it seems like it would be ok to bump our C compiler requirement > to C11. We'd like to make this change before beta 1 if there are no > objections. How would you enforce that, through configure? FWIW, I have just tried compiling Xdebug with -std

Re: [PHP-DEV] Require C11 in PHP 8.4

On Friday, 2 August 2024 at 14:33, Giovanni Giacobbi wrote: > On Thu, 1 Aug 2024 at 23:57, Ilija Tovilo wrote: > >> [...] >> I started fixing these in a PR [1] which required more changes than >> expected. After a short discourse, we were wondering whether it might >> be better to switch to a n

Re: [PHP-DEV] Require C11 in PHP 8.4

Hi, On Fri, Aug 2, 2024 at 1:36 PM Giovanni Giacobbi wrote: > It feels wrong to raise such an important requirement that might affect a > lot of people, including maintainers of extensions > Why do you think that this might affect a lot of people? We are talking about minimum GCC version 4.7 an

Re: [PHP-DEV] Require C11 in PHP 8.4

On Thu, 1 Aug 2024 at 23:57, Ilija Tovilo wrote: > [...] > I started fixing these in a PR [1] which required more changes than > expected. After a short discourse, we were wondering whether it might > be better to switch to a newer C standard instead. Our coding > standards [2] currently specify

Re: [PHP-DEV] Require C11 in PHP 8.4

On 01.08.2024 at 23:57, Ilija Tovilo wrote: > […] The biggest blocker in the past was MSVC, which has finally > added C11 support in Visual Studio 2019 [8]. Technically, Visual > Studio 2015 and 2017 are still supported by Microsoft [9], but > according to Christoph they are no longer used for PHP

Re: [PHP-DEV] Require C11 in PHP 8.4

On 02.08.2024 at 07:50, Stephen Reay wrote: > According to > https://releases.llvm.org/3.1/docs/ClangReleaseNotes.html#cchanges, Clang 3.1 > added C11. > > According to https://trac.macports.org/wiki/XcodeVersionInfo, Clang 3.1 > shipped with Xcode 4.3.3, in May 2012. > > In terms of confirming

Re: [PHP-DEV] Require C11 in PHP 8.4

> On 2 Aug 2024, at 05:26, Derick Rethans wrote: > > On 1 August 2024 22:57:36 BST, Ilija Tovilo > wrote: >> Hi everyone >> >> We've gotten a bug report about compile errors in the PHP 8.4 alpha on >> old C99 compilers (and on some modern compilers when passing

Re: [PHP-DEV] Require C11 in PHP 8.4

On 1 August 2024 22:57:36 BST, Ilija Tovilo wrote: >Hi everyone > >We've gotten a bug report about compile errors in the PHP 8.4 alpha on >old C99 compilers (and on some modern compilers when passing the >-std=c99 flag). Specifically, C99 does not support typedef >redeclarations, which is a C11 fe