Hi Levi On Tue, Aug 13, 2024 at 5:00 PM Levi Morrison <levi.morri...@datadoghq.com> wrote: > > On Tue, Aug 13, 2024 at 8:17 AM Ilija Tovilo <tovilo.il...@gmail.com> wrote: > > > > Just to state it officially: You object to switching to C11 in 8.4? In > > that case, we'll have to postpone. > > I don't object. I think it's smarter to wait, and do more than just > redeclare a few typedefs. But I won't block it.
Thank you for the clarification. In that case, I'd say let's go forward with the proposal. I agree that we should be making use of more C11 features in the future, once the opportunity presents itself. > If only documentation changes, then I think the risk is lower. We > definitely should not be doing configure checks in 8.4 with how little > time there is, except maybe _one_ that attempts to redeclare a typedef > to see if it compiles, and give a nicer error message. I agree. I will create a PR to provide a ./configure time error message if the compiler doesn't support typedef redeclarations. Adopting C11 does mean we can start using other C11 features too, though that should naturally happen only on (future) master rather than 8.4, given that ABI freeze is only a little over a month away. Ilija
