Hello Felipe,
nice work. The others already talked about the implications. And given
what I can only chime in. Since so far people think it is a ok for 5.3 I
wonder if we should not continue with moving towards the new parameter
parsing API. In the end the best would be to get rid of the old one
On Wed, 2008-02-13 at 08:05 -0200, Felipe Pena wrote:
> Em Qua, 2008-02-13 às 09:47 +0100, Pierre Joye escreveu:
> > I can't test the patch right now but does it change the result or only
> > raises
> > a notice?
>
> It changes the result when a string is given, and issue notice when the
> string
On Feb 13, 2008 11:05 AM, Felipe Pena <[EMAIL PROTECTED]> wrote:
> Em Qua, 2008-02-13 às 09:47 +0100, Pierre Joye escreveu:
> > I can't test the patch right now but does it change the result or only
> > raises
> > a notice?
>
> It changes the result when a string is given, and issue notice when th
Felipe Pena wrote:
Hi all,
I made a patch for 5_3 where all functions in ext/standard/math.c use
the new parameter parsing. (As was done in HEAD)
If anyone think it good, let me know, and then i'll commit it.
Several tests break with the patch. Hence, i'll fix them also, if
agreed. :)
Felip
Em Qua, 2008-02-13 às 09:47 +0100, Pierre Joye escreveu:
> I can't test the patch right now but does it change the result or only raises
> a notice?
It changes the result when a string is given, and issue notice when the
string starts with numeric.
var_dump(acos("nonsense"));
Warning: acos() exp
On Feb 13, 2008 3:08 AM, Felipe Pena <[EMAIL PROTECTED]> wrote:
> Em Qua, 2008-02-13 às 01:31 +0100, Pierre Joye escreveu:
> > Hi!
> >
> > On Feb 13, 2008 1:04 AM, Felipe Pena <[EMAIL PROTECTED]> wrote:
> > > Hi all,
> > >
> > > I made a patch for 5_3 where all functions in ext/standard/math.c use
On 13.02.2008 05:31, David Coallier wrote:
> As long as it's in 5_3 I believe there'll be no problems. I did the
> same for a few string.c functions.
>
> As long as the behavior itself doesn't change, I'd say good work :)
Agree, it's ok in 5_3.
We need to convert all the functions to use new par
On Feb 12, 2008 9:08 PM, Felipe Pena <[EMAIL PROTECTED]> wrote:
> Em Qua, 2008-02-13 às 01:31 +0100, Pierre Joye escreveu:
> > Hi!
> >
> > On Feb 13, 2008 1:04 AM, Felipe Pena <[EMAIL PROTECTED]> wrote:
> > > Hi all,
> > >
> > > I made a patch for 5_3 where all functions in ext/standard/math.c use
Em Qua, 2008-02-13 às 01:31 +0100, Pierre Joye escreveu:
> Hi!
>
> On Feb 13, 2008 1:04 AM, Felipe Pena <[EMAIL PROTECTED]> wrote:
> > Hi all,
> >
> > I made a patch for 5_3 where all functions in ext/standard/math.c use
> > the new parameter parsing. (As was done in HEAD)
>
> I think it got lost
Hi!
On Feb 13, 2008 1:04 AM, Felipe Pena <[EMAIL PROTECTED]> wrote:
> Hi all,
>
> I made a patch for 5_3 where all functions in ext/standard/math.c use
> the new parameter parsing. (As was done in HEAD)
I think it got lost between you and the list :)
> If anyone think it good, let me know, and t
10 matches
Mail list logo
