Re: [PHP-DEV] C++ Extensions

2015-08-20 Thread Kalle Sommer Nielsen
(sorry for top posting) Hi Sara, I think such will be just fine for RC2, unless Anatol got any object, go ahead. -K On Aug 20, 2015 6:49 PM, "Sara Golemon" wrote: > On Wed, Aug 19, 2015 at 1:10 PM, Stanislav Malyshev > wrote: > >> A) Adding those defines prior to including stdint.h > >> B) Ex

Re: [PHP-DEV] C++ Extensions

2015-08-20 Thread Stanislav Malyshev
Hi! > Second question, is it too late to put it in 7.0.0? > Happy enough to put it behind #ifdef __cplusplus to limit the exposed > surface area. That doesn't look like a radical change, so unless RM (or somebody else?) disapproves my opinion is it can be in 7.0. -- Stas Malyshev smalys...@gmai

Re: [PHP-DEV] C++ Extensions

2015-08-20 Thread Sara Golemon
On Wed, Aug 19, 2015 at 1:10 PM, Stanislav Malyshev wrote: >> A) Adding those defines prior to including stdint.h >> B) Expecting C++ ext devs to define those before including php.h >> C) Modifying zend_long.h to use things like >> std::numeric_limits() when __cplusplus is defined >> >> A may (pot

Re: [PHP-DEV] C++ Extensions

2015-08-19 Thread Stanislav Malyshev
Hi! > A) Adding those defines prior to including stdint.h > B) Expecting C++ ext devs to define those before including php.h > C) Modifying zend_long.h to use things like > std::numeric_limits() when __cplusplus is defined > > A may (potentially) have unexpected side-effects > B has precedent (se