Re: [PHP-DEV] --enable-zend-multibyte

2010-11-23 Thread Dmitry Stogov
Hi Chris, I've added a note into UPGRADING, but I didn't change php.ini-* Thanks. Dmitry. Christopher Jones wrote: On 11/23/2010 01:34 AM, Dmitry Stogov wrote: hi, I've prepared the patch which completely removes compile-time --enable-zend-multibyte configuration directive. The configur

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-23 Thread Christopher Jones
On 11/23/2010 01:34 AM, Dmitry Stogov wrote: hi, I've prepared the patch which completely removes compile-time --enable-zend-multibyte configuration directive. The configuration can be changed at run-tume using zend.multibyte=0/1. The patch also fixes Unicode detection for phar archives. I

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-23 Thread Dmitry Stogov
Gustavo Lopes wrote: On Tue, 23 Nov 2010 09:34:49 -, Dmitry Stogov wrote: hi, I've prepared the patch which completely removes compile-time --enable-zend-multibyte configuration directive. The configuration can be changed at run-tume using zend.multibyte=0/1. The patch also fixes Unic

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-23 Thread Gustavo Lopes
On Tue, 23 Nov 2010 09:34:49 -, Dmitry Stogov wrote: hi, I've prepared the patch which completely removes compile-time --enable-zend-multibyte configuration directive. The configuration can be changed at run-tume using zend.multibyte=0/1. The patch also fixes Unicode detection for phar a

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-23 Thread Dmitry Stogov
Derick Rethans wrote: On Tue, 23 Nov 2010, Dmitry Stogov wrote: I've prepared the patch which completely removes compile-time --enable-zend-multibyte configuration directive. The configuration can be changed at run-tume using zend.multibyte=0/1. The patch also fixes Unicode detection for ph

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-23 Thread Derick Rethans
On Tue, 23 Nov 2010, Dmitry Stogov wrote: > I've prepared the patch which completely removes compile-time > --enable-zend-multibyte configuration directive. > > The configuration can be changed at run-tume using zend.multibyte=0/1. > > The patch also fixes Unicode detection for phar archives. >

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-23 Thread Dmitry Stogov
hi, I've prepared the patch which completely removes compile-time --enable-zend-multibyte configuration directive. The configuration can be changed at run-tume using zend.multibyte=0/1. The patch also fixes Unicode detection for phar archives. I would like to commit it on Thursday. Thanks.

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-22 Thread Dmitry Stogov
Hi Christopher, Right now, I'm working on patch to completely remove compile-time "--enable-zend-multibyte" and replacing it with run-time "zend.multibyte". I think the ZEND_MULTIBYTE constant will became useless. I hope I'll post the patch later today. Thanks. Dmitry. Christopher Jones w

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-22 Thread Gustavo Lopes
On Mon, 22 Nov 2010 22:20:50 -, Christopher Jones wrote: Actually, it doesn't have compile-time dependencies, so it's probably make sense to remove --enable-zend-multibyte completely. Another ease-of-use simplification prior to releasing 5.3.4 is to roll back the addition of ZEND_MUL

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-22 Thread Christopher Jones
On 11/19/2010 06:16 AM, Dmitry Stogov wrote: Derick Rethans wrote: On Thu, 18 Nov 2010, Christopher Jones wrote: On 11/18/2010 06:26 AM, Dmitry Stogov wrote: The proposed patch allows compiling PHP with --enable-zend-multibyte and then enable or disable multibyte support at run-time using

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-19 Thread Stas Malyshev
Hi! CG(multibyte) is defined only inside #ifdef ZEND_MULTIBYTE. If we're already getting into this, how hard it would be to make multibyte build be binary-compatible with non-multibyte build? Is it possible at all? I.e., for example, taking all extra vars into a separate structure and havin

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-19 Thread Dmitry Stogov
Derick Rethans wrote: On Thu, 18 Nov 2010, Christopher Jones wrote: On 11/18/2010 06:26 AM, Dmitry Stogov wrote: The proposed patch allows compiling PHP with --enable-zend-multibyte and then enable or disable multibyte support at run-time using zend.multibyte=0/1 in php.ini. As result the si

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-19 Thread Dmitry Stogov
CG(multibyte) is defined only inside #ifdef ZEND_MULTIBYTE. Thanks. Dmitry. Patrick ALLAERT wrote: 2010/11/18 Dmitry Stogov : Index: ext/mbstring/mbstring.c === --- ext/mbstring/mbstring.c (revision 305494) +++ ext/mbstring/mb

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-18 Thread Christopher Jones
On 11/18/2010 12:04 PM, Derick Rethans wrote: On Thu, 18 Nov 2010, Christopher Jones wrote: On 11/18/2010 06:26 AM, Dmitry Stogov wrote: The proposed patch allows compiling PHP with --enable-zend-multibyte and then enable or disable multibyte support at run-time using zend.multibyte=0/1 in

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-18 Thread Patrick ALLAERT
2010/11/18 Christopher Jones : > If the overhead of zend.multibyte=0 is negligable, then why not remove > remove the configure option altogether?  This would reduce the > complexity of the implementation and simplify building & maintenance. > Why have two interdependent ways to get the same outcome

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-18 Thread Derick Rethans
On Thu, 18 Nov 2010, Christopher Jones wrote: > On 11/18/2010 06:26 AM, Dmitry Stogov wrote: > > > > The proposed patch allows compiling PHP with --enable-zend-multibyte > > and then enable or disable multibyte support at run-time using > > zend.multibyte=0/1 in php.ini. As result the single bina

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-18 Thread Christopher Jones
On 11/18/2010 06:26 AM, Dmitry Stogov wrote: Hi, The proposed patch allows compiling PHP with --enable-zend-multibyte and then enable or disable multibyte support at run-time using zend.multibyte=0/1 in php.ini. As result the single binary will be able to support multibyte encodings and run wi

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-18 Thread Pierre Joye
hi, On Thu, Nov 18, 2010 at 4:29 PM, Patrick ALLAERT wrote: > 2010/11/18 Dmitry Stogov : >> Hi, >> >> The proposed patch allows compiling PHP with --enable-zend-multibyte and >> then enable or disable multibyte support at run-time using >> zend.multibyte=0/1 in php.ini. As result the single binar

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-18 Thread Patrick ALLAERT
2010/11/18 Dmitry Stogov : > Hi, > > The proposed patch allows compiling PHP with --enable-zend-multibyte and > then enable or disable multibyte support at run-time using > zend.multibyte=0/1 in php.ini. As result the single binary will be able to > support multibyte encodings and run without zend-

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-18 Thread Patrick ALLAERT
2010/11/18 Dmitry Stogov : > Index: ext/mbstring/mbstring.c > === > --- ext/mbstring/mbstring.c     (revision 305494) > +++ ext/mbstring/mbstring.c     (working copy) > @@ -1132,6 +1132,9 @@ >  { >        int *list, size; > > +       i

Re: [PHP-DEV] --enable-zend-multibyte

2010-07-29 Thread Ferenc Kovacs
2010/7/30 Johannes Schlüter : > Hi, > > On Fri, 2010-07-30 at 00:33 +0200, Ferenc Kovacs wrote: >> > Ignoring the BOF might cause not expected behavior: Assume people are >> > using PHP as "templating" language and want the BOM to go out to the >> > client. > >> Do you think that this is a common s

Re: [PHP-DEV] --enable-zend-multibyte

2010-07-29 Thread Johannes Schlüter
Hi, On Fri, 2010-07-30 at 00:33 +0200, Ferenc Kovacs wrote: > > Ignoring the BOF might cause not expected behavior: Assume people are > > using PHP as "templating" language and want the BOM to go out to the > > client. > Do you think that this is a common scenario? > Apart from a case, when I had

Re: [PHP-DEV] --enable-zend-multibyte

2010-07-29 Thread Ferenc Kovacs
2010/7/30 Ferenc Kovacs : > 2010/7/29 Johannes Schlüter : >> Hi, >> >> On Thu, 2010-07-29 at 21:26 +0200, Ferenc Kovacs wrote: >>> Hi. >>> >>> Could we set the --enable-zend-multibyte configure option to be >>> enabled by default for the trunk? >>> http://bugs.php.net/bug.php?id=22108 >> >> Ignorin

Re: [PHP-DEV] --enable-zend-multibyte

2010-07-29 Thread Ferenc Kovacs
2010/7/29 Johannes Schlüter : > Hi, > > On Thu, 2010-07-29 at 21:26 +0200, Ferenc Kovacs wrote: >> Hi. >> >> Could we set the --enable-zend-multibyte configure option to be >> enabled by default for the trunk? >> http://bugs.php.net/bug.php?id=22108 > > Ignoring the BOF might cause not expected beh

Re: [PHP-DEV] --enable-zend-multibyte

2010-07-29 Thread Johannes Schlüter
Hi, On Thu, 2010-07-29 at 21:26 +0200, Ferenc Kovacs wrote: > Hi. > > Could we set the --enable-zend-multibyte configure option to be > enabled by default for the trunk? > http://bugs.php.net/bug.php?id=22108 Ignoring the BOF might cause not expected behavior: Assume people are using PHP as "tem

Re: [PHP-DEV] --enable-zend-multibyte and phar support

2010-05-20 Thread Frederic Hardy
On 05/20/2010 11:28, Frederic Hardy wrote: I have a problem with php 5.3.2 under FreeBSD 7/8 with configure option --enable-zend-multibyte and phar support. Then i use this option, phar does not work correctly. No seg fault, no crash, just... nothing or cabalistic letter in output of my script.