Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-12 Thread Alice Wonder
On 05/12/2018 03:46 PM, Yasuo Ohgaki wrote: On Fri, May 11, 2018 at 9:34 PM, Alice Wonder mailto:al...@librelamp.com>> wrote: slightly better if block if($more_entropy) { sodium_increment($nonce); $x = hexdec(substr(bin2hex($nonce),0,12)); $return = $return . substr($x

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-12 Thread Yasuo Ohgaki
On Fri, May 11, 2018 at 9:34 PM, Alice Wonder wrote: > slightly better if block > > if($more_entropy) { > sodium_increment($nonce); > $x = hexdec(substr(bin2hex($nonce),0,12)); > $return = $return . substr($x, 2, 1) . '.' . substr($x, -8); > } > > Obvious patterns in the "more entropy" but

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-11 Thread Arvids Godjuks
2018-05-11 17:19 GMT+02:00 Alice Wonder : > On 05/11/2018 05:34 AM, Alice Wonder wrote: > >> On 05/11/2018 05:10 AM, Alice Wonder wrote: >> >>> On 05/11/2018 03:50 AM, Arvids Godjuks wrote: >>> 2018-05-11 12:36 GMT+02:00 Alice Wonder : On 05/11/2018 01:59 AM, Arvids Godjuks wrote: >

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-11 Thread Alice Wonder
On 05/11/2018 05:34 AM, Alice Wonder wrote: On 05/11/2018 05:10 AM, Alice Wonder wrote: On 05/11/2018 03:50 AM, Arvids Godjuks wrote: 2018-05-11 12:36 GMT+02:00 Alice Wonder : On 05/11/2018 01:59 AM, Arvids Godjuks wrote: 2018-05-10 16:33 GMT+02:00 Niklas Keller : Hey, I hereby propose t

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-11 Thread Alice Wonder
On 05/11/2018 05:34 AM, Alice Wonder wrote: On 05/11/2018 05:10 AM, Alice Wonder wrote: On 05/11/2018 03:50 AM, Arvids Godjuks wrote: 2018-05-11 12:36 GMT+02:00 Alice Wonder : On 05/11/2018 01:59 AM, Arvids Godjuks wrote: 2018-05-10 16:33 GMT+02:00 Niklas Keller : Hey, I hereby propose t

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-11 Thread Alice Wonder
On 05/11/2018 05:10 AM, Alice Wonder wrote: On 05/11/2018 03:50 AM, Arvids Godjuks wrote: 2018-05-11 12:36 GMT+02:00 Alice Wonder : On 05/11/2018 01:59 AM, Arvids Godjuks wrote: 2018-05-10 16:33 GMT+02:00 Niklas Keller : Hey, I hereby propose to deprecate uniqid(). There have been attempt

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-11 Thread Alice Wonder
On 05/11/2018 03:50 AM, Arvids Godjuks wrote: 2018-05-11 12:36 GMT+02:00 Alice Wonder : On 05/11/2018 01:59 AM, Arvids Godjuks wrote: 2018-05-10 16:33 GMT+02:00 Niklas Keller : Hey, I hereby propose to deprecate uniqid(). There have been attempts to fix it ( https://wiki.php.net/rfc/uniqid

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-11 Thread Arvids Godjuks
2018-05-11 12:36 GMT+02:00 Alice Wonder : > On 05/11/2018 01:59 AM, Arvids Godjuks wrote: > >> 2018-05-10 16:33 GMT+02:00 Niklas Keller : >> >> Hey, >>> >>> I hereby propose to deprecate uniqid(). There have been attempts to fix >>> it >>> ( >>> https://wiki.php.net/rfc/uniqid), but those were rej

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-11 Thread Alice Wonder
On 05/11/2018 01:59 AM, Arvids Godjuks wrote: 2018-05-10 16:33 GMT+02:00 Niklas Keller : Hey, I hereby propose to deprecate uniqid(). There have been attempts to fix it ( https://wiki.php.net/rfc/uniqid), but those were rejected during discussion, because there's no possible fix without breaki

Re: [PHP-DEV] [RFC] Deprecation of uniqid()

2018-05-11 Thread Arvids Godjuks
2018-05-10 16:33 GMT+02:00 Niklas Keller : > Hey, > > I hereby propose to deprecate uniqid(). There have been attempts to fix it > ( > https://wiki.php.net/rfc/uniqid), but those were rejected during > discussion, because there's no possible fix without breaking BC. Instead of > a subtle BC break,