Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-20 Thread Nikita Popov
On Tue, Feb 19, 2013 at 1:06 PM, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args > Imho this change isn't necessary (though I'm also not strongly against). I don't really buy the VCS argument, as

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-20 Thread Sara Golemon
On Wed, Feb 20, 2013 at 3:32 AM, Martin Keckeis wrote: > -1 > > For array it's okay, but for functions? I think the code is harder to read > that way... > > If I would see a call written this way: > phpinfo(,) > > There are three possible values: Defaultvalue, null or something differnt? > You wou

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-20 Thread Martin Keckeis
2013/2/19 Sara Golemon > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -1 For array it's okay, b

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-20 Thread Sara Golemon
On Wed, Feb 20, 2013 at 12:47 AM, Florin Razvan Patan wrote: > For example, I would expect that if I have: > > function A($b, $c = 'd') {} > > when I see A($b, ) to have no syntax errors but rather $c defaulted to > the value in the function signature, which is not implied nor assumed > by the RFC

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-20 Thread Sara Golemon
On Tue, Feb 19, 2013 at 6:51 PM, Sherif Ramadan wrote: > While I think it's a good idea I just have one question about the > implication of the change. Does this mean that null will be passed to the > function argument when a trailing comma remains? > No. The trailing comma is simply ignored, the

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-20 Thread Lars Strojny
Hi, Am 20.02.2013 um 06:24 schrieb Laruence : > On Tue, Feb 19, 2013 at 8:06 PM, Sara Golemon wrote: >> Opening RFC to allow trailing comma in function call argument lists >> >> https://wiki.php.net/rfc/trailing-comma-function-args -1 on this as well. If you don’t like the diffs, fix the diff

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-20 Thread Florin Razvan Patan
Hello, On Tue, Feb 19, 2013 at 2:06 PM, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args > As a person who deals with code reviews from many programmers each day, I'd have to say this would be conf

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Laruence
On Tue, Feb 19, 2013 at 8:06 PM, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args -1 on this. I really don't like this, it look very weird, and the gain is minor. thanks > > -- > PHP Internals -

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Sherif Ramadan
On Tue, Feb 19, 2013 at 7:06 AM, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Florian Anderiasch
On 19.02.2013 13:06, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args > For completeness' sake: The VCS argument is kind of moot if you format your source code like it's sometimes/often seen in Has

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Will Fitch
On Feb 19, 2013, at 8:00 AM, Sara Golemon wrote: > On Tue, Feb 19, 2013 at 4:41 AM, Kingsquare.nl - Robin Speekenbrink > wrote: >> Just a question from one of the lingering listeners: would this change also >> ease the `skipping` of default values for parameters? (as discussed for RFC >> https:

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Pierrick Charron
+1 On 19 February 2013 07:06, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread guilhermebla...@gmail.com
+1 On Feb 19, 2013 10:13 AM, "Cyberspice" wrote: > On 19 Feb 2013, at 12:06, Sara Golemon wrote: > > > Opening RFC to allow trailing comma in function call argument lists > > > > https://wiki.php.net/rfc/trailing-comma-function-args > > +1 > > Melanie > > > -- > PHP Internals - PHP Runtime Deve

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Cyberspice
On 19 Feb 2013, at 12:06, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args +1 Melanie -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.ph

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Kingsquare.nl - Robin Speekenbrink
Sara, I wasnt commenting that this RFC was different, just in agreement that this syntax is _more_ in line with the list() construct (which then might reflect the skipparams rfc)) If i wasnt clear: from a user point of view: i am all for this RFC ;) Met vriendelijke groet, Robin Speekenbrink Kin

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Sara Golemon
On Tue, Feb 19, 2013 at 4:41 AM, Kingsquare.nl - Robin Speekenbrink wrote: > Just a question from one of the lingering listeners: would this change also > ease the `skipping` of default values for parameters? (as discussed for RFC > https://wiki.php.net/rfc/skipparams) > > That way it would be con

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Kingsquare.nl - Robin Speekenbrink
Just a question from one of the lingering listeners: would this change also ease the `skipping` of default values for parameters? (as discussed for RFC https://wiki.php.net/rfc/skipparams) That way it would be consistent with this RFC and the list() construct ? With regards, Robin Speekenbrink

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Patrick ALLAERT
2013/2/19 Sara Golemon : > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php I'm all for it! Waiting for t

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Pierre Joye
On Tue, Feb 19, 2013 at 1:06 PM, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args looks good and consistent enough, you have my vote :) -- Pierre @pierrejoye -- PHP Internals - PHP Runtime Dev

Re: [PHP-DEV] [RFC] Allow trailing comma in function call argument lists

2013-02-19 Thread Derick Rethans
On Tue, 19 Feb 2013, Sara Golemon wrote: > Opening RFC to allow trailing comma in function call argument lists > > https://wiki.php.net/rfc/trailing-comma-function-args +1 cheers, Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.ph