On 07/17/2018 06:53 PM, Sara Golemon wrote:
I think devs should be able to use flexible versions of re2c (and
other tools, e.g. bison), BUT that we should declare formally what
versions of these build tools will be used on what branches so that
those working on features can predictably know wh
On Tue, Jul 17, 2018 at 1:06 PM, Zeev Suraski wrote:
> You know, you made me go back to Sara's email where she disagreed with me,
> only to find she actually was disagreeing with Remi's proposal to track the
> generated files for releases in git. That's definitely not a hill to die on
> for me :)
On Tue, Jul 17, 2018 at 7:57 PM Nikita Popov wrote:
>
> Ah yes, *of course* the generated files will be part of distribution
> tarballs, just like we do with all generated files (not just the parser,
> but also configure.) While I forgot to write this in my original mail, it
> has been mentioned
On Tue, Jul 17, 2018 at 6:41 PM, Zeev Suraski wrote:
> On Tue, Jul 17, 2018 at 6:05 PM Nikita Popov wrote:
>
>> I feel like we are all really in violent agreement that these files
>> should be dropped from git, and at this point I'm not even sure what the
>> discussion is about anymore. Let's wa
On Tue, Jul 17, 2018 at 6:05 PM Nikita Popov wrote:
> I feel like we are all really in violent agreement that these files should
> be dropped from git, and at this point I'm not even sure what the
> discussion is about anymore. Let's wait until after PHP-7.3 branching in
> two weeks and drop them
On Tue, Jul 17, 2018 at 1:51 PM, Zeev Suraski wrote:
> On Tue, Jul 17, 2018 at 2:01 PM Sara Golemon wrote:
>
> > On Tue, Jul 17, 2018 at 1:04 AM, Remi Collet
> > wrote:
> > > Le 13/07/2018 à 23:48, Zeev Suraski a écrit :
> > > Perhaps we can also add all the generated files (including configure
On Tue, Jul 17, 2018 at 2:01 PM Sara Golemon wrote:
> On Tue, Jul 17, 2018 at 1:04 AM, Remi Collet
> wrote:
> > Le 13/07/2018 à 23:48, Zeev Suraski a écrit :
> > Perhaps we can also add all the generated files (including configure) in
> > the tagged versions, so the tag will have same content th
On Tue, Jul 17, 2018 at 1:04 AM, Remi Collet wrote:
> Le 13/07/2018 à 23:48, Zeev Suraski a écrit :
> Perhaps we can also add all the generated files (including configure) in
> the tagged versions, so the tag will have same content than the official
> archive.
>
Ick, no. That's the worst outcome
Le 13/07/2018 à 23:48, Zeev Suraski a écrit :
> So why not do both - remove these files from version control, but also update
> the re2c requirements in configure and makedist..?
>
> And of course we still want to bundle these in our distros - just not track
> them in our source control.
I agr
Hi!
> re2c is not a problem for Windows either, it is bundled as part of the
> PHP SDK.
OK then, Windows is not a problem, that makes it better.
--
Stas Malyshev
smalys...@gmail.com
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Hi!
> I would offer that this is what official releases and/or snaps.php.net is for.
Do you mean releases would contain the generated files but the regular
source won't? I am not sure then why - if we say our "official" source
has generated files, why keep VCS out of sync with the source? Also,
w
> On Jul 14, 2018, at 00:02, Jan Ehrhardt wrote:
>
> Stanislav Malyshev in php.internals (Fri, 13 Jul 2018 11:40:12 -0700):
>>> re2c is widely available on Linux distros nowadays (probably
>>
>> On Linux distros on common platforms (Intel/AMD) - sure. But what if you
>> need an uncommon platfo
Stanislav Malyshev in php.internals (Fri, 13 Jul 2018 11:40:12 -0700):
>> re2c is widely available on Linux distros nowadays (probably
>
>On Linux distros on common platforms (Intel/AMD) - sure. But what if you
>need an uncommon platform, or one that does not run Linux? It's those
>platforms where
On 07/13/2018 01:27 PM, Sara Golemon wrote:
On Fri, Jul 13, 2018 at 3:08 PM, Anatol Belski wrote:
*snip*
Well, whichever version we've settled on, I've updated
sgolemon/php-release to allow using arbitrary versions of re2c.
https://github.com/sgolemon/php-release/commit/9197257bc6f2f607476f9
> -Original Message-
> From: Nikita Popov [mailto:nikita@gmail.com]
> Sent: Friday, July 13, 2018 12:26 PM
> To: Dmitry Stogov
> Cc: PHP internals list ; Stanislav Malyshev
> ; der...@derickrethans.nl; Christoph M. Becker
>
> Subject: Re: [PHP-DEV] re2c ver
On 13.07.2018 at 21:07, Sara Golemon wrote:
> **Checks snaps.php.net**
> wait, is this not a thing anymore?
IIRC, that was already gone before I got my php.net account. Nowadays
users are supposed to checkout from Git.
--
Christoph M. Becker
--
PHP Internals - PHP Runtime Development Mai
> Subject: Re: [PHP-DEV] re2c version(s)
>
> On Fri, Jul 13, 2018 at 3:08 PM, Anatol Belski wrote:
> >> I ask, because my release builder for 7.2 (and 7.1 if Joe is using
> >> Davey's builder) is using re2c 0.13.5 . I don't imagine the risk of
> >
On Fri, Jul 13, 2018 at 3:08 PM, Anatol Belski wrote:
>> I ask, because my release builder for 7.2 (and 7.1 if Joe is using
>> Davey's builder) is using re2c 0.13.5 . I don't imagine the risk of
>> updating re2c mid-relase is particularly high, but it is non-zero.
>>
> Normally RMs would define
> -Original Message-
> From: Stanislav Malyshev
> Sent: Friday, July 13, 2018 8:46 PM
> To: Nikita Popov ; Dmitry Stogov
> Cc: PHP internals list ; der...@derickrethans.nl;
> Christoph M. Becker
> Subject: Re: [PHP-DEV] re2c version(s)
>
> Hi!
>
On Fri, Jul 13, 2018 at 8:40 PM, Stanislav Malyshev
wrote:
> Hi!
>
> > re2c is widely available on Linux distros nowadays (probably
>
> On Linux distros on common platforms (Intel/AMD) - sure. But what if you
> need an uncommon platform, or one that does not run Linux? It's those
> platforms wher
Hi,
> -Original Message-
> From: p...@golemon.com On Behalf Of Sara Golemon
> Sent: Friday, July 13, 2018 8:22 PM
> To: Dmitry Stogov
> Cc: Nikita Popov ; PHP internals list
> ; Stanislav Malyshev ;
> der...@derickrethans.nl; Christoph M. Becker
> Subject: Re:
On Fri, Jul 13, 2018 at 2:40 PM, Stanislav Malyshev wrote:
>> re2c is widely available on Linux distros nowadays (probably
>
> On Linux distros on common platforms (Intel/AMD) - sure. But what if you
> need an uncommon platform, or one that does not run Linux? It's those
> platforms where you'd ha
Hi!
> On Linux distros on common platforms (Intel/AMD) - sure. But what if you
> need an uncommon platform, or one that does not run Linux? It's those
> platforms where you'd have to build PHP from source (after all, PHP is
> also widely available as a package on Linux distros anyway) and adding
>
Hi!
> the timelib files *must* be generated with 0.15.3:
> https://github.com/mongodb/mongo/blob/master/src/third_party/scripts/timelib_get_sources.sh#L10-L11
That comment says 0.16 was problematic. Is it still true for 1.0.*? Was
it reported to re2c?
--
Stas Malyshev
smalys...@gmail.com
--
Hi!
> re2c is widely available on Linux distros nowadays (probably
On Linux distros on common platforms (Intel/AMD) - sure. But what if you
need an uncommon platform, or one that does not run Linux? It's those
platforms where you'd have to build PHP from source (after all, PHP is
also widely avai
On Fri, Jul 13, 2018 at 7:00 AM, Dmitry Stogov wrote:
> OK. Dropping files and requirement for re2c 1.0.0. Right?
>
+1 to removing them from git (except timelib as Derick noted).
The minimum requirement is reasonable in terms of reproducibility, but
should that be specific to master/7.3?
I ask,
On 13.07.2018 at 11:26, Nikita Popov wrote:
> On Fri, Jul 13, 2018 at 11:13 AM, Dmitry Stogov wrote:
>
>> I propose, to change build scripts (in master and PHP-7.3) to require at
>> least re2c version 1.0.0 (it seems 1.0.0-1.0.3 produce the same result) and
>> suppress version output into the gen
: Re: [PHP-DEV] re2c version(s)
On Fri, Jul 13, 2018 at 11:13 AM, Dmitry Stogov
mailto:dmi...@zend.com>> wrote:
Hi,
I think, many core developers saw unexpected changes in
"zend_labguages_scanner.c" or "var_unserializer.c" after rebuilds.
This occurs, because we use
On Fri, 13 Jul 2018, Nikita Popov wrote:
> On Fri, Jul 13, 2018 at 11:13 AM, Dmitry Stogov wrote:
>
> > I think, many core developers saw unexpected changes in
> > "zend_labguages_scanner.c" or "var_unserializer.c" after rebuilds.
> >
> > This occurs, because we use different versions of re2c, a
On Fri, Jul 13, 2018 at 11:13 AM, Dmitry Stogov wrote:
> Hi,
>
>
> I think, many core developers saw unexpected changes in
> "zend_labguages_scanner.c" or "var_unserializer.c" after rebuilds.
>
> This occurs, because we use different versions of re2c, and some of them
> produce really different c
Hi,
I think, many core developers saw unexpected changes in
"zend_labguages_scanner.c" or "var_unserializer.c" after rebuilds.
This occurs, because we use different versions of re2c, and some of them
produce really different code.
They also embed version number into the generate source. Curre
31 matches
Mail list logo
