Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-07 Thread Arvids Godjuks
Alan Knowles You should consider the fact that some E_STRICT stuff can one day become E_WARNING or E_FATAL. For example calling a static method dynamically - I would bet that someday this thing will be moved to be a run-time fatal error and fix those if I make a mistake of doing that. Or not setti

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-07 Thread Reindl Harald
Am 07.03.2012 01:11, schrieb Alan Knowles: > Sorry - top post as I can't reply to all the mails on the thread.. > > - display errors on. > Yes, this is a business decision, 20 servers running upgraded at different > times, some have less maintenance others > have more.. Seriously, the chance of

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Alan Knowles
And the first time your network infrastructure has even a tiny hiccup you broadcast your database name/username/password to the whole world. Not an excellent business decision. I've yet to see a php notice / warning echo out a name/password etc... - anyway these are normally not public servic

RE: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread John Crenshaw
> - display errors on. > Yes, this is a business decision, 20 servers running upgraded at different > times, > some have less maintenance others have more.. > Seriously, the chance of me even bothering to check one of those log files is > pretty slim. However if the code is producing warning/noti

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Alan Knowles
Sorry - top post as I can't reply to all the mails on the thread.. - display errors on. Yes, this is a business decision, 20 servers running upgraded at different times, some have less maintenance others have more.. Seriously, the chance of me even bothering to check one of those log files is

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Ángel González
On 06/03/12 17:08, Alan Knowles wrote: > I just got caught on a production server with the 5.4 upgrade on > debian, pretty much everything works fine, except the E_ALL change. > > I have to admit I missed the discussion where it was added, and > searching for E_ALL or E_STRICT on marc is pretty dif

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Stas Malyshev
Hi! However, this change really kills code written by third parties, All our servers run with E_ALL on (eg. E_NOTICE is printed to end users) and we You run production with display_errors enabled? Please don't do that. You have logs for that. Doesn't matter if it's intranet or not, this is n

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Ferenc Kovacs
On Tue, Mar 6, 2012 at 5:08 PM, Alan Knowles wrote: > I just got caught on a production server with the 5.4 upgrade on debian, > pretty much everything works fine, except the E_ALL change. > > I have to admit I missed the discussion where it was added, and searching > for E_ALL or E_STRICT on mar

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Reindl Harald
Am 06.03.2012 17:22, schrieb Gustavo Lopes: > On Tue, 06 Mar 2012 17:08:07 +0100, Alan Knowles wrote: > >> [...] >> However with E_STRICT included we have to run around and find all the code, >> and change it to stuff like this: >> >> error_reporting(E_ALL & E_STRICT ? E_ALL ^ E_STRICT : E_ALL

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Daniel Macedo
PLEASE, don't be the kind of developer that does this all over his code: >> error_reporting(E_ALL & E_STRICT ? E_ALL ^ E_STRICT : E_ALL); Either define it once in the same place, or use the php.ini value and make sure it's proper. Here's my development/production, yours should be the same: ; Dev

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Gustavo Lopes
On Tue, 06 Mar 2012 17:08:07 +0100, Alan Knowles wrote: [...] However with E_STRICT included we have to run around and find all the code, and change it to stuff like this: error_reporting(E_ALL & E_STRICT ? E_ALL ^ E_STRICT : E_ALL); Could we please revert that, and if people want an all e

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Pierre Joye
hi Alan! On a server you are supposed to use logs, not to display errors. Also if one does not like the default, he can always set the error reporting using what he likes to, per directory or globally. I see no reason to do revert what is actually a good thing. All means all, not all but this a

Re: [PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Reindl Harald
Am 06.03.2012 17:08, schrieb Alan Knowles: > However with E_STRICT included we have to run around and find all the code, > and > change it to stuff like this: error_reporting(E_ALL & E_STRICT ? E_ALL ^ > E_STRICT : E_ALL); > > Could we please revert that, and if people want an all encompasing

[PHP-DEV] consider reverting E_ALL with E_STRICT

2012-03-06 Thread Alan Knowles
I just got caught on a production server with the 5.4 upgrade on debian, pretty much everything works fine, except the E_ALL change. I have to admit I missed the discussion where it was added, and searching for E_ALL or E_STRICT on marc is pretty difficult (it removes the E_ bit..) Anyway, t