Hi!
Ok, I've committed in 5.4 and trunk the argument parser part.
Now I need to fix some tests and try to found other places needing for
related checks.
Thanks for fixing it!
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227
--
PHP Internals
Hi,
2011/6/5 Stas Malyshev
> Hi!
>
>
> Of course, I was just checking if it's what you guys are thinking first.
>>
>
> Well, there was basically two ideas:
> 1. Add filename length to streams and check inside streams
> 2. Check inside argument parser
>
> Both have downsides: (1) does not captur
Hi!
Of course, I was just checking if it's what you guys are thinking first.
Well, there was basically two ideas:
1. Add filename length to streams and check inside streams
2. Check inside argument parser
Both have downsides: (1) does not capture cases when we don't use
streams (such as dire
On Sun, Jun 5, 2011 at 9:13 PM, Felipe Pena wrote:
> 2011/6/5 Stas Malyshev
>>
>> Hi!
>>
>>> Should http://felipe.ath.cx/diff/parse_arg_null_path.diff be enough
>>> (beyond changing others function parse args, fixing the tests,
>>> include+require part)?
>>>
>>> $ sapi/cli/php -r 'fopen("a\0b", "
2011/6/5 Stas Malyshev
> Hi!
>
>
> Should http://felipe.ath.cx/diff/parse_arg_null_path.diff be enough
>> (beyond changing others function parse args, fixing the tests,
>> include+require part)?
>>
>> $ sapi/cli/php -r 'fopen("a\0b", "r");'
>>
>> Warning: fopen() expects parameter 1 to be valid
Hi!
Should http://felipe.ath.cx/diff/parse_arg_null_path.diff be enough
(beyond changing others function parse args, fixing the tests,
include+require part)?
$ sapi/cli/php -r 'fopen("a\0b", "r");'
Warning: fopen() expects parameter 1 to be valid path, string given in
Command line code on line
Hi,
2011/6/5 Pierre Joye
> hi,
>
> Not apparently, it was not fixed in trunk.
>
> There was a discussion about using zend_arg for paths and additional
> function or macros to be used instead of duplicating the tests
> everywhere. But no consensus or agreement have been reached.
>
>
Should http:/
hi,
Not apparently, it was not fixed in trunk.
There was a discussion about using zend_arg for paths and additional
function or macros to be used instead of duplicating the tests
everywhere. But no consensus or agreement have been reached.
Cheers,
On Sun, Jun 5, 2011 at 10:25 AM, Stas Malyshev
Hi!
As far as I can see, bug 39863 was fixed in 5.3, but the fix still not
in trunk/5.4.
Should we merge the same patch into trunk/5.4 or somebody is
volunteering to fix it, e.g. like described here:
http://news.php.net/php.internals/50191?
See also the about it discussion:
http://www.serverp
