Hi,

2011/6/5 Stas Malyshev <smalys...@sugarcrm.com>

> Hi!
>
>
>  Of course, I was just checking if it's what you guys are thinking first.
>>
>
> Well, there was basically two ideas:
> 1. Add filename length to streams and check inside streams
> 2. Check inside argument parser
>
> Both have downsides: (1) does not capture cases when we don't use streams
> (such as direct stat/touch/etc functions), (2) doesn't cover the case when
> stream is manipulated through a string not coming directly from a function
> argument (e.g. include, but may be other cases with extensions). So,
> ideally, it'd be nice to have both - or something third that I didn't think
> of - but any of them is better than nothing.
> (1) seems to be easier and less disruptive, provided that we cover include
> case separately and locate all functions that deal with filenames.
>
>
Ok, I've committed in 5.4 and trunk the argument parser part.

Now I need to fix some tests and try to found other places needing for
related checks.


Thanks.

-- 
Regards,
Felipe Pena

Reply via email to