Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-26 Thread Michael Vergoz
CTED]>; "'Wez Furlong'" <[EMAIL PROTECTED]>; "'PHPdev'" Sent: Sunday, February 26, 2006 9:18 PM Subject: Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP) Using recursive functions without any constraint is a bad programming practice,

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-26 Thread Michael Vergoz
CTED]>; "'Wez Furlong'" <[EMAIL PROTECTED]>; "'PHPdev'" Sent: Sunday, February 26, 2006 9:18 PM Subject: Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP) Using recursive functions without any constraint is a bad programming practice,

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-26 Thread Nuno Lopes
Using recursive functions without any constraint is a bad programming practice, period. You should always implement a pop/push stack in those situations to avoid getting into infinite or near infinite recursion. Ilia OK, but the good compilers/interpreters don't segfault.. This time its my t

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-26 Thread Ilia Alshanetsky
Using recursive functions without any constraint is a bad programming practice, period. You should always implement a pop/push stack in those situations to avoid getting into infinite or near infinite recursion. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-26 Thread Michael Vergoz
sky'" <[EMAIL PROTECTED]>; "'PHPdev'" Sent: Saturday, February 25, 2006 5:53 PM Subject: Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP) Basicly your patch does just try to automatically detect the maximum execution depth limit, that can be manu

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-25 Thread Jeff Moore
On Feb 25, 2006, at 4:47 AM, Michael Vergoz wrote: You see function what need a prevention ? contact me [EMAIL PROTECTED] Hello, How about one that needs less prevention? Would this patch (or another like it) allow for the elimination of the current recursion guard for __get, etc? ht

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-25 Thread Ilia Alshanetsky
Nuno Lopes wrote: Basicly your patch does just try to automatically detect the maximum execution depth limit, that can be manually set with xdebug or hardened-php patch for quite a while now... which is not bad for the average user. I personally like the patch (although it needs some tweaking

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-25 Thread Nuno Lopes
Basicly your patch does just try to automatically detect the maximum execution depth limit, that can be manually set with xdebug or hardened-php patch for quite a while now... which is not bad for the average user. I personally like the patch (although it needs some tweaking), but the idea is t

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-25 Thread Stefan Esser
beside the fact that I think the correct way to stop the script is zend_bailout() and not php_handle_aborted_connection() and that your code will fail on systems where the stack is growing into the opposite direction. Stefan Esser -- PHP Internals - PHP Runtime Development Mailing List To unsubs

Re: [PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-25 Thread Stefan Esser
Basicly your patch does just try to automatically detect the maximum execution depth limit, that can be manually set with xdebug or hardened-php patch for quite a while now... This kind of protection was rejected before to get into core and most probably will be rejected again... Stefan Esser --

[PHP-DEV] Vote for Zend Deep Stack Prevention (ZDSP)

2006-02-25 Thread Michael Vergoz
Hello, ZDSP is a module to allow the Zend engine to know when it will go too much far within the stack. In fact this module to allow to prevent a possible segfault from the script. If you type (php 5.1) : php -r 'function foo() { foo(); } foo();' You will get a segfault because foo() will go