Re: [PHP-DEV] Using do_alloca() instead of emalloc()

2003-11-23 Thread Marcus Boerger
Hello Andi, Sunday, November 23, 2003, 1:56:20 PM, you wrote: > Commited thanks. > Marcus, what we meant was that you shouldn't use do_alloca() in the engine > except for in the cases I mentioned, and possibly cases where the > allocations would be quite large. In the case of reflection API the

Re: [PHP-DEV] Using do_alloca() instead of emalloc()

2003-11-23 Thread Andi Gutmans
Commited thanks. Marcus, what we meant was that you shouldn't use do_alloca() in the engine except for in the cases I mentioned, and possibly cases where the allocations would be quite large. In the case of reflection API the allocations are small *and* the function returns right away, thus not

Re: [PHP-DEV] Using do_alloca() instead of emalloc()

2003-11-22 Thread Marcus Boerger
Hello Andi, Thursday, November 20, 2003, 10:48:57 AM, you wrote: > Hey, > I've been taking a look at the __autoload problem. During that time I saw > that lots of places in the code (especially reflection API) use > zend_str_tolower_dup(). > In most of these cases it would be much more efficie

Re: [PHP-DEV] Using do_alloca() instead of emalloc()

2003-11-20 Thread Timm Friebe
On Thu, 2003-11-20 at 10:48, Andi Gutmans wrote: > Hey, > > I've been taking a look at the __autoload problem. During that time I saw > that lots of places in the code (especially reflection API) use > zend_str_tolower_dup(). [...] Here's a patch for zend_reflection_api.c which uses do_alloca /

[PHP-DEV] Using do_alloca() instead of emalloc()

2003-11-20 Thread Andi Gutmans
Hey, I've been taking a look at the __autoload problem. During that time I saw that lots of places in the code (especially reflection API) use zend_str_tolower_dup(). In most of these cases it would be much more efficient to use do_alloca()/free_alloca() because that usually uses alloca() which