Commited thanks.
Marcus, what we meant was that you shouldn't use do_alloca() in the engine except for in the cases I mentioned, and possibly cases where the allocations would be quite large. In the case of reflection API the allocations are small *and* the function returns right away, thus not keeping stuff on the stack for too long.


Andi

At 11:09 PM 11/20/2003 +0100, Timm Friebe wrote:
On Thu, 2003-11-20 at 10:48, Andi Gutmans wrote:
> Hey,
>
> I've been taking a look at the __autoload problem. During that time I saw
> that lots of places in the code (especially reflection API) use
> zend_str_tolower_dup().
[...]

Here's a patch for zend_reflection_api.c which uses do_alloca /
free_alloca in all relevant places.

- Timm

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to