Re: [PHP-DEV] Throwable patch(es) and finalizing the story

2015-05-16 Thread Aaron Piotrowski
I tried to keep the implementation simpler in the first PR, but I think the second I submitted is much better and should be closer to what you had in mind. The second PR does not prevent user space code from instigating Error, but I do have another branch that does prevent it (same behavior as t

Re: [PHP-DEV] Throwable patch(es) and finalizing the story

2015-05-16 Thread Sebastian Bergmann
On 05/17/2015 12:15 AM, Stanislav Malyshev wrote: > Where is it? I'd like to see it. https://github.com/php/php-src/pull/1284 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Throwable patch(es) and finalizing the story

2015-05-16 Thread Sebastian Bergmann
On 05/16/2015 10:57 PM, Stanislav Malyshev wrote: > I am assuming we have broad consensus about the move from BaseException > to Throwable. I've looked at the patch at > https://github.com/php/php-src/pull/1282 and it seems pretty close to > what we want to me. The only difference is that > https:/

Re: [PHP-DEV] Throwable patch(es) and finalizing the story

2015-05-16 Thread Stanislav Malyshev
Hi! > Sorry for going a bit off-topic here, but why does this need to be > resolved for the first alpha? If I'm not mistaken, we do feature freeze Because it's a pretty deep language change and we don't want to release stuff that has such deep change pending. However, I don't really want to spend

Re: [PHP-DEV] Throwable patch(es) and finalizing the story

2015-05-16 Thread Nikita Popov
On Sat, May 16, 2015 at 10:57 PM, Stanislav Malyshev wrote: > Hi! > > I am assuming we have broad consensus about the move from BaseException > to Throwable. I've looked at the patch at > https://github.com/php/php-src/pull/1282 and it seems pretty close to > what we want to me. The only differen

Re: [PHP-DEV] Throwable patch(es) and finalizing the story

2015-05-16 Thread Yasuo Ohgaki
Hi All, On Sun, May 17, 2015 at 5:57 AM, Stanislav Malyshev wrote: > I am assuming we have broad consensus about the move from BaseException > to Throwable. I've looked at the patch at > I would like to add note that the name "BaseException" breaks too many apps. Someone researched this in prev

[PHP-DEV] Throwable patch(es) and finalizing the story

2015-05-16 Thread Stanislav Malyshev
Hi! I am assuming we have broad consensus about the move from BaseException to Throwable. I've looked at the patch at https://github.com/php/php-src/pull/1282 and it seems pretty close to what we want to me. The only difference is that https://wiki.php.net/rfc/throwable says Throwable is an interf