On Sat, May 16, 2015 at 10:57 PM, Stanislav Malyshev <smalys...@gmail.com> wrote:
> Hi! > > I am assuming we have broad consensus about the move from BaseException > to Throwable. I've looked at the patch at > https://github.com/php/php-src/pull/1282 and it seems pretty close to > what we want to me. The only difference is that > https://wiki.php.net/rfc/throwable says Throwable is an interface and > this patch makes it abstract class - which I guess makes some sense as > both Exception and engine errors need the same properties - but I'm not > sure if it doesn't mess something up. Sebastian, could you comment on > this? Of course, other comments are welcome too. > > There's a question left about the naming - particularly, renaming > EngineException to Error. I'm not sure I am a fan of this. I think it's > better to leave it as EngineException, but I'm open to arguments here. > > One thing seems to be clear though - a) there's a broad support for > introducing Throwable and b) we need to do this before we release PHP 7 > alpha. So I think we need to start converging on something really soon. > I'd like to take https://github.com/php/php-src/pull/1282 as a baseline, > and once we close open questions about interface/abstract class and the > name of the Error class, merge it - targeting sometime within the > timeframe of the next week. If someone thinks it's impossible or should > not be done, please tell. > Sorry for going a bit off-topic here, but why does this need to be resolved for the first alpha? If I'm not mistaken, we do feature freeze on first beta, not first alpha, right? I'd like to see an alpha release ASAP without waiting for the last few features to trickle in. Btw, the author of PR #1282 also has an implementation that makes Throwable an interface (with semantics similar to Traversable, so cannot be directly implemented). Nikita
