Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-31 Thread Andrei Zmievski
After some off-list discussion with Pierre and Rasmus, I think we should move forward with the approach of JITting the whole array at once (similar to how it's done now, except at runtime). It seems to be the least of all evils and allows the flexibility of choosing encoding at runtime. What co

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-30 Thread Andrei Zmievski
Your proposal was to have a couple of separate functions that people would use to access GPC data and retrieve it in Unicode form, no? -Andrei On Jan 30, 2007, at 8:39 AM, Pierre wrote: On 1/30/07, Andrei Zmievski <[EMAIL PROTECTED]> wrote: Of course we won't drop it, but it would contain ra

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-30 Thread Pierre
On 1/30/07, Andrei Zmievski <[EMAIL PROTECTED]> wrote: Of course we won't drop it, but it would contain raw binary data (as opposed to the rest of the PHP environment in unicode semantics mode). IMO, it is inconsistent and confusing to the end user. I do not follow you. Why would it contain raw

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-30 Thread Andrei Zmievski
Of course we won't drop it, but it would contain raw binary data (as opposed to the rest of the PHP environment in unicode semantics mode). IMO, it is inconsistent and confusing to the end user. -A On Jan 29, 2007, at 3:20 PM, Pierre wrote: Please, who said we will *drop* the GPC array? That

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-29 Thread Pierre
On 1/29/07, Richard Lynch <[EMAIL PROTECTED]> wrote: On Sat, January 27, 2007 5:16 am, Pierre wrote: > On 1/27/07, Andrei Zmievski <[EMAIL PROTECTED]> wrote: >> Good luck trying to retrain millions of programmers to use a CGI >> object or a function to retrieve GPC values. > > You will be surpris

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-29 Thread Richard Lynch
On Sat, January 27, 2007 5:16 am, Pierre wrote: > On 1/27/07, Andrei Zmievski <[EMAIL PROTECTED]> wrote: >> Good luck trying to retrain millions of programmers to use a CGI >> object or a function to retrieve GPC values. > > You will be surprised, really :) I doubt it. We haven't even gotten ever

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-29 Thread Pierre
On 1/29/07, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > Oh! It was not a +1 from me for this patch, I still prefer my simpler > solution (which has to be written ;). However, as a temporary/test > code Sara's patch can do it for now no? What's the reason to commit "temporary test code" to CV

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-29 Thread Stanislav Malyshev
Oh! It was not a +1 from me for this patch, I still prefer my simpler solution (which has to be written ;). However, as a temporary/test code Sara's patch can do it for now no? What's the reason to commit "temporary test code" to CVS? If one wants to play with it, one can always apply a patch.

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-27 Thread Pierre
Hi Andi, On 1/27/07, Andi Gutmans <[EMAIL PROTECTED]> wrote: s during PHP 5 where I warned that they might introduce bugs in other areas but it's hard to forsee. No one believed me because I couldn't give a concrete enough example and we had quite a few of those bugs afterwards. Given the stat

RE: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-27 Thread Andi Gutmans
ndrei Zmievski' > Cc: 'Sara Golemon'; internals@lists.php.net; 'Andi Gutmans'; > 'Zeev Suraski'; 'Stanislav Malyshev' > Subject: RE: [PHP-DEV] Runtime-JIT, the whole enchilada > > > -Original Message- > > From: Pierre

RE: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-27 Thread Andi Gutmans
> Subject: Re: [PHP-DEV] Runtime-JIT, the whole enchilada > > Hello Andrei, > > On 1/27/07, Andrei Zmievski <[EMAIL PROTECTED]> wrote: > > Good luck trying to retrain millions of programmers to use a CGI > > object or a function to retrieve GPC values. > >

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-27 Thread Pierre
aski; Stanislav Malyshev > Subject: Re: [PHP-DEV] Runtime-JIT, the whole enchilada > > > Hello Andrei, > > On 1/27/07, Andrei Zmievski <[EMAIL PROTECTED]> wrote: > > Good luck trying to retrain millions of programmers to use a CGI > > object or a functi

RE: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-27 Thread Dmitry Stogov
> -Original Message- > From: Pierre [mailto:[EMAIL PROTECTED] > Sent: Saturday, January 27, 2007 2:16 PM > To: Andrei Zmievski > Cc: Dmitry Stogov; Sara Golemon; internals@lists.php.net; > Andi Gutmans; Zeev Suraski; Stanislav Malyshev > Subject: Re: [PHP-DEV] R

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-27 Thread Pierre
Hello Andrei, On 1/27/07, Andrei Zmievski <[EMAIL PROTECTED]> wrote: Good luck trying to retrain millions of programmers to use a CGI object or a function to retrieve GPC values. You will be surprised, really :) Really, how much of a performance hit is Sara's patch going to be, compared to o

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-26 Thread Andrei Zmievski
Good luck trying to retrain millions of programmers to use a CGI object or a function to retrieve GPC values. Really, how much of a performance hit is Sara's patch going to be, compared to other things in PHP 6? -Andrei On Jan 26, 2007, at 3:38 PM, Pierre wrote: That's somehow my thought

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-26 Thread Pierre
> Zmievski'; Zeev Suraski; Stanislav Malyshev > Subject: Re: [PHP-DEV] Runtime-JIT, the whole enchilada > > > > I fixed one error in your patch, so now it passes all tests. > > > Which error? I notice some changes related to minimizing performance > impact, but I&#x

RE: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-26 Thread Dmitry Stogov
Hi Sara, > -Original Message- > From: Sara Golemon [mailto:[EMAIL PROTECTED] > Sent: Friday, January 26, 2007 8:11 PM > To: Dmitry Stogov > Cc: internals@lists.php.net; 'Andi Gutmans'; 'Andrei > Zmievski'; Zeev Suraski; Stanislav Malyshev > Subj

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-26 Thread Sara Golemon
I fixed one error in your patch, so now it passes all tests. Which error? I notice some changes related to minimizing performance impact, but I'm not seeing what I did wrong. Just curious for my own benefit on that one. BTW I am against this patch. Fair enough. 1) It adds sloppily built

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-26 Thread Sara Golemon
I fixed one error in your patch, so now it passes all tests. Which error? I notice some changes related to minimizing performance impact, but I'm not seeing what I did wrong. Just curious for my own benefit on that one. BTW I am against this patch. Fair enough. 1) It adds sloppily built

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-26 Thread Pierre
Hi Dmitry, On 1/26/07, Dmitry Stogov <[EMAIL PROTECTED]> wrote: Hi Sara, I fixed one error in your patch, so now it passes all tests. BTW I am against this patch. 1) It adds sloppily built functionality into the core and slowdowns EACH dimension or property fetch both at run-time and compilat

RE: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-26 Thread Dmitry Stogov
uary 24, 2007 10:58 PM > To: internals@lists.php.net; Dmitry Stogov; Andi Gutmans; > Andrei Zmievski > Subject: [PHP-DEV] Runtime-JIT, the whole enchilada > > > Dmitry- > >You asked for it, you get it :) Hopefully it'll be > self-explanatory, >

Re: [PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-24 Thread Ilia Alshanetsky
What are the numbers before the patch? On 24-Jan-07, at 2:58 PM, Sara Golemon wrote: Dmitry- You asked for it, you get it :) Hopefully it'll be self- explanatory, the one part I hope you don't notice is that I put the auto_global check back into fetch_simple_variable_ex in order to for

[PHP-DEV] Runtime-JIT, the whole enchilada

2007-01-24 Thread Sara Golemon
Dmitry- You asked for it, you get it :) Hopefully it'll be self-explanatory, the one part I hope you don't notice is that I put the auto_global check back into fetch_simple_variable_ex in order to force direct access to autoglobals ($foo = $_GET;foreach($_POST as ...) etc...) as non-a