Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-13 Thread Stanislav Malyshev
Hi! As for the error handling, Pierre mentioned that Jani did some tweaks there too. Could someone explain to me what kind of error handling is out into place? If we throw a nice error message for all cases where someone is using \t, \n etc incorrectly inside a php.ini, I think it I have ch

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-13 Thread Lukas Kahwe Smith
On 06.09.2008, at 11:42, Jordi Boggiano wrote: On Sat, Sep 6, 2008 at 2:15 AM, Scott MacVicar <[EMAIL PROTECTED]> wrote: Stanislav Malyshev wrote: No, the main argument is that it would break people's configs, and for no good reason at all (nobody really needs \n's in their paths). This

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-06 Thread Jordi Boggiano
On Sat, Sep 6, 2008 at 2:15 AM, Scott MacVicar <[EMAIL PROTECTED]> wrote: > Stanislav Malyshev wrote: >> No, the main argument is that it would break people's configs, and for >> no good reason at all (nobody really needs \n's in their paths). > > This code is used in parse_ini_file() where it is p

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Andras
Scott MacVicar wrote: Stanislav Malyshev wrote: Hi! That's exactly why I am reluctant to change what Jani did. It is easier to deal with this minor breakage in 5.3.0 and then have a consistent and clean configuration system. Continuing to add some exceptions while hoping that "no weird things

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Scott MacVicar
Stanislav Malyshev wrote: > Hi! > >> That's exactly why I am reluctant to change what Jani did. It is >> easier to deal with this minor breakage in 5.3.0 and then have a >> consistent and clean configuration system. Continuing to add some >> exceptions while hoping that "no weird things" are used

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Stanislav Malyshev
Hi! That's exactly why I am reluctant to change what Jani did. It is easier to deal with this minor breakage in 5.3.0 and then have a consistent and clean configuration system. Continuing to add some exceptions while hoping that "no weird things" are used is a bad idea Do you see any problem w

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Pierre Joye
hi, On Fri, Sep 5, 2008 at 11:31 PM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > Hi! > > Attached is the patch that does the following for php.ini parser: > 1. \{LETTER} is literal inside "" now, whatever the letter is > 2. \" is " inside "", with exception of: > 3. foo="bar\"{NEWLINE} is pars

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Stanislav Malyshev
Hi! Attached is the patch that does the following for php.ini parser: 1. \{LETTER} is literal inside "" now, whatever the letter is 2. \" is " inside "", with exception of: 3. foo="bar\"{NEWLINE} is parsed as bar\ - i.e. \ is allowed before closing " but only if the line ends there (otherwise it

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Jani Taskinen
Stanislav Malyshev wrote: Hi! Anyway, the fix is quite easy: Only allow \" and no other escapes. And doing "foo\" should cause a syntax error. Why? It's not like we don't know what the string "c:\foo\bar\" is supposed to mean - why shouldn't it just work? Feel free to fix it. I'm not goin

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Stanislav Malyshev
Hi! Anyway, the fix is quite easy: Only allow \" and no other escapes. And doing "foo\" should cause a syntax error. Why? It's not like we don't know what the string "c:\foo\bar\" is supposed to mean - why shouldn't it just work? -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTE

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Jochem Maas
Jani Taskinen schreef: Hannes Magnusson wrote: On Thu, Sep 4, 2008 at 22:43, Jani Taskinen <[EMAIL PROTECTED]> wrote: Johannes Schlüter kirjoitti: ... php.ini-recommended, 5.3: ; ; Paths and Directories ; ; ; UNIX: "/path1:/path2" ;include_p

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Jani Taskinen
Hannes Magnusson wrote: On Thu, Sep 4, 2008 at 22:43, Jani Taskinen <[EMAIL PROTECTED]> wrote: Johannes Schlüter kirjoitti: Hi, now that we have a publicly available alpha on Windows we get the first feedback from Windows users. Within quite short time we got two bug reports (#45992 #45994) ab

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-05 Thread Hannes Magnusson
On Thu, Sep 4, 2008 at 22:43, Jani Taskinen <[EMAIL PROTECTED]> wrote: > Johannes Schlüter kirjoitti: >> >> Hi, >> >> now that we have a publicly available alpha on Windows we get the first >> feedback from Windows users. Within quite short time we got two bug >> reports (#45992 #45994) about a cha

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-04 Thread Scott MacVicar
I agree, users will notice quickly enough and the previous behaviour doesn't match that of PHP. If we provide an uprade information popup at the end of the Windows installer it might help. Scott On 4 Sep 2008, at 22:24, "Pierre Joye" <[EMAIL PROTECTED]> wrote: hi, On Thu, Sep 4, 2008 at

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-04 Thread Stanislav Malyshev
Hi! Or simply remove the double quotes. include_path=C:\Users\pierre\Documents\Digsby Logs works just fine. I was under impression it doesn't always work, looking at the parser space is not in VALUE_CHARS, also single quote and () (which can be used by Windows in directory names) isn't. I'

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-04 Thread Pierre Joye
hi, On Thu, Sep 4, 2008 at 11:08 PM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote: > Hi! > > I don't think something allowed and documented can be just remove without > considering the consequences. It worked and did what it was intended to do, > why we need to drop it? > If people actually have c

Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-04 Thread Stanislav Malyshev
Hi! I don't think something allowed and documented can be just remove without considering the consequences. It worked and did what it was intended to do, why we need to drop it? If people actually have configs that would stop working in 5.3 and it wouldn't be good for anybody. In windows, beca

[PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3

2008-09-04 Thread Jani Taskinen
Johannes Schlüter kirjoitti: Hi, now that we have a publicly available alpha on Windows we get the first feedback from Windows users. Within quite short time we got two bug reports (#45992 #45994) about a change in the ini-parsing: With <=5.2 we allow include_path = "c:\foo\bar\" That SHOU