On 06.09.2008, at 11:42, Jordi Boggiano wrote:
On Sat, Sep 6, 2008 at 2:15 AM, Scott MacVicar <[EMAIL PROTECTED]>
wrote:
Stanislav Malyshev wrote:
No, the main argument is that it would break people's configs, and
for
no good reason at all (nobody really needs \n's in their paths).
This code is used in parse_ini_file() where it is possible that
escapes
would be used legitimately, it's not all about paths.
This means that not only php.ini will fail - although that is indeed
easy to notice - but also any application using ini files might break
in a much less obvious manner, right ? It's something that might need
to be taken into account.
Seems to me like we should consider delaying this fix to 6.0. I agree
with Pierre that its probably not a good idea to introduce special
handling here and there.
As for the error handling, Pierre mentioned that Jani did some tweaks
there too. Could someone explain to me what kind of error handling is
out into place? If we throw a nice error message for all cases where
someone is using \t, \n etc incorrectly inside a php.ini, I think it
will not be such a big deal at upgrade time. But still it seems like
something we might want to hold off until 6.0, considering that the
bug that was fixed did not affect that many users (just a guess).
regards,
Lukas Kahwe Smith
[EMAIL PROTECTED]
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
