[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Dmitry Stogov
These opcodes hardly ever would throw exceptions their selves. This real problem should be fixed in HANDLE_EXCEPTION handler. There we will need to get the list of "active" temporary variables. I don't have a good solution for this yet. Thanks. Dmitry. On Tue, Mar 24, 2015 at 10:45 PM, Nikita Po

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Nikita Popov
On Tue, Mar 24, 2015 at 1:08 PM, Dmitry Stogov wrote: > > > On Tue, Mar 24, 2015 at 2:51 PM, Nikita Popov > wrote: > >> On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov wrote: >> >>> I thought about something like this :) >>> In my opinion UString is really not a proper way to implement Unicoide

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Dmitry Stogov
On Tue, Mar 24, 2015 at 2:51 PM, Nikita Popov wrote: > On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov wrote: > >> I thought about something like this :) >> In my opinion UString is really not a proper way to implement Unicoide, >> but I agree not break anything in current stage. >> Anyway, plea

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
Hey: On Tue, Mar 24, 2015 at 7:51 PM, Nikita Popov wrote: > On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov wrote: >> >> I thought about something like this :) >> In my opinion UString is really not a proper way to implement Unicoide, >> but I agree not break anything in current stage. >> Anyway

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Nikita Popov
On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov wrote: > I thought about something like this :) > In my opinion UString is really not a proper way to implement Unicoide, > but I agree not break anything in current stage. > Anyway, please review the first PR (in my opinion it is safe to commit), >

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
Hey: On Tue, Mar 24, 2015 at 5:28 PM, Xinchen Hui wrote: > Hey > > Sent from my iPhone > > On Mar 24, 2015, at 5:11 PM, Nikita Popov wrote: > > On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: >> >> Hi, >> >> Recently, Xinchen and me worked on optimization that eliminates useless >> reall

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Xinchen Hui
Hey Sent from my iPhone > On Mar 24, 2015, at 5:11 PM, Nikita Popov wrote: > >> On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: >> Hi, >> >> Recently, Xinchen and me worked on optimization that eliminates useless >> reallocations and copying during string concatenation (ZEND_ADD_STRIN

Re: [PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Pierre Joye
On Mar 24, 2015 4:11 PM, "Nikita Popov" wrote: > > On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: > > > Hi, > > > > Recently, Xinchen and me worked on optimization that eliminates useless > > reallocations and copying during string concatenation (ZEND_ADD_STRING and > > family + ZEND_CONC

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Dmitry Stogov
I thought about something like this :) In my opinion UString is really not a proper way to implement Unicoide, but I agree not break anything in current stage. Anyway, please review the first PR (in my opinion it is safe to commit), but you may find some other issues. Thanks. Dmitry. On Tue, Ma

[PHP-DEV] Re: Use "ropes" for string concatenation

2015-03-24 Thread Nikita Popov
On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov wrote: > Hi, > > Recently, Xinchen and me worked on optimization that eliminates useless > reallocations and copying during string concatenation (ZEND_ADD_STRING and > family + ZEND_CONCAT). > > The idea comes from ropes, but adopted especially for