The i variable inside insertionsort() is used by the swap() macro and is
actually needed. The other two issues are indeed valid and patches to
fix them have just been applied to CVS, thanks for pointing them out.
Ilia
Ron Korving wrote:
Nice to see RC2 :)
I noticed that few of my earlier obse
Hello Ron,
if only these two spots were all problems we had. :-)
marcus
Saturday, April 1, 2006, 10:18:09 PM, you wrote:
> Nice to see RC2 :)
> I noticed that few of my earlier observations have not been addressed
> though, and these are minor cleanups, but they are cleanups:
> 1) An unused
Nice to see RC2 :)
I noticed that few of my earlier observations have not been addressed
though, and these are minor cleanups, but they are cleanups:
1) An unused variable 'i' in insertionsort() in main/mergesort.c
2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type:
image/gif" w
Nice to see RC2 :)
I noticed that few of my earlier observations have not been addressed
though, and these are minor cleanups, but they are cleanups:
1) An unused variable 'i' in insertionsort() in main/mergesort.c
2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type:
image/gif" w
