Nice to see RC2 :)
I noticed that few of my earlier observations have not been addressed
though, and these are minor cleanups, but they are cleanups:

1) An unused variable 'i' in insertionsort() in main/mergesort.c
2) CONTEXT_TYPE_IMAGE_GIF in main/logos.h is defined as "Content-Type:
image/gif" with 2 spaces between "Content-Type" and "image/gif"
3) In sapi/apache/mod_php5.c in the function php_apache_log_message() there
are 2 fprintf() calls which could just as easily be  done with 1:
    fprintf(stderr, "%s\n", message);
  instead of:
    fprintf(stderr, "%s", message);
    fprintf(stderr, "\n");

I can't 100% guarantee that this is all safe, but it all seems(!) perfectly
safe to me.

Regards,

Ron


"Ilia Alshanetsky" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> PHP 5.1.3RC2 has just been released, about a week late, but better late
> then never ;-). Please test this RC as much as possible, if it proves to
> be stable, this release will be published as final next week Thursday.
>
> The source packages can be found here:
>
> http://downloads.php.net/ilia/php-5.1.3RC2.tar.bz2
> MD5: 8ad7bddc9a3b4dbcd2ecb1d6f5446970
>
> http://downloads.php.net/ilia/php-5.1.3RC2.tar.gz
> MD5: 1e66780413580bc4a0742fa302735c99
>
> Win32 binaries will be available for download shortly.
>
> Ilia
> 5.1 Release Master

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to