Re: [PHP-DEV] RE: MFHing zend_fcall_info_*() to 5.2

2006-06-05 Thread Marcus Boerger
Hello Dmitry, just as you i was asonished by the fact that we don't have anything to convert an array to parameters. And for the fact of not blowing up zend api i decided to reduce the number of additional functions to a minumum. That way i came to the three ones i added. Now since i am using th

[PHP-DEV] RE: MFHing zend_fcall_info_*() to 5.2

2006-06-05 Thread Dmitry Stogov
Hi Marcus, SPL code with this patch looks great, but ZE overloaded with helpers those are useful only for iterators. I wondered that ZE hasn't any helper for IS_ARRAY to arguments array conversion (may be I missed it). I suggest reimplement zend_fcall_info_args() into zval *** zend_create_param

[PHP-DEV] Re: MFHing zend_fcall_info_*() to 5.2

2006-06-04 Thread Marcus Boerger
Hello Dmitry, the 'f' requires at least the first helper, so it makes sense to have all three of them in the engine. Attached you will find the patch for the helpers and the 'f' thingie for 5.2 and an additional patch for SPL to introduce iterator_apply() which uses the stuff. marcus Wednesday

Re: [PHP-DEV] Re: MFHing zend_fcall_info_*() to 5.2

2006-05-31 Thread Marcus Boerger
Hello Stanislav, yep exactly right. Maybe we should add documentations for it right now. And also mark the places like set_error_handler() where it won't work directly, so noone will change that in upcoming versions while thinking he was doing a clever optimization. best regards marcus Wednesd

[PHP-DEV] RE: MFHing zend_fcall_info_*() to 5.2

2006-05-31 Thread Dmitry Stogov
Hmm, Seems 'f' really make sense for simplification. I am not sure about other helpers. I'll need to review patch once again. Could you include some use-cases (SPL patch that uses this one)? Thanks. Dmitry. > -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: We

[PHP-DEV] Re: MFHing zend_fcall_info_*() to 5.2

2006-05-31 Thread Stanislav Malyshev
MB>> my patch doesn't change anything. If just adds stuff that deals with MB>>defined functions only. If now you want to support all functions that MB>>can be defined later it wouldn't work this way (1). Actually it would If I understand it right and this patch adds an option for PHP API functio

[PHP-DEV] Re: MFHing zend_fcall_info_*() to 5.2

2006-05-31 Thread Marcus Boerger
Hello Dmitry, my patch doesn't change anything. If just adds stuff that deals with defined functions only. If now you want to support all functions that can be defined later it wouldn't work this way (1). Actually it would require parsing the zval and checking whether it might get callable in so