Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP

2009-07-15 Thread David Soria Parra
On 2009-07-15, Alexey Zakhlestin wrote: > The problem is, that if we update Zend/zend_dtrace.d, this header file > will need to be regenerated. > So, there is a need for a corresponding procedure. I'll change the patch as soon as possible to generate the header file during configure. -- PHP Int

Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP

2009-07-15 Thread Alexey Zakhlestin
On Wed, Jul 15, 2009 at 11:16 AM, David Soria Parra wrote: > On 2009-07-15, Alexey Zakhlestin wrote: >> The patch is simple and clean. Just 2 notices.. >> 1) Zend/zend_dtrace.h file is generated. Are you sure it should be the >> part of patch? > > The generated dtrace header on Solaris and MacOS a

Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP

2009-07-15 Thread David Soria Parra
On 2009-07-15, Alexey Zakhlestin wrote: > The patch is simple and clean. Just 2 notices.. > 1) Zend/zend_dtrace.h file is generated. Are you sure it should be the > part of patch? The generated dtrace header on Solaris and MacOS are different. Therefore people have to generate them during configu

Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP

2009-07-14 Thread Alexey Zakhlestin
On Wed, Jul 15, 2009 at 1:31 AM, David Soria Parra wrote: > Hi List, > > in the last months I worked on adding DTrace probes to PHP and would > like to start a discussion about the RFC and patch against trunk > that can be found at: > >  http://wiki.php.net/rfc/dtrace > > DTrace is a dynamic tracin

Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP

2009-07-14 Thread Sriram Natarajan
David I have been talking with some Drupal users and some of them showed lot of interest to be able to print out the function arguments as well as part of DTrace function-entry probes. - Sriram David Soria Parra wrote: Hi List, in the last months I worked on adding DTrace probes to PHP and

Re: [PHP-DEV] Patch and RFC for adding DTrace probes to PHP

2009-07-14 Thread Andrei Zmievski
On Tue, Jul 14, 2009 at 2:31 PM, David Soria Parra wrote: > In the current state the patch introduces a wrapper for the current > executor to fire function-entry probes. It was mentioned that it might > be useful to not use an own funciton for that. As I want to make things > cleaner for the curr

[PHP-DEV] Patch and RFC for adding DTrace probes to PHP

2009-07-14 Thread David Soria Parra
Hi List, in the last months I worked on adding DTrace probes to PHP and would like to start a discussion about the RFC and patch against trunk that can be found at: http://wiki.php.net/rfc/dtrace DTrace is a dynamic tracing framework for Solaris, OpenSolaris, Mac OSX and FreeBSD that can be use