On Wed, Jul 15, 2009 at 11:16 AM, David Soria Parra<david.soriapa...@sun.com> wrote: > On 2009-07-15, Alexey Zakhlestin <indey...@gmail.com> wrote: >> The patch is simple and clean. Just 2 notices.. >> 1) Zend/zend_dtrace.h file is generated. Are you sure it should be the >> part of patch? > > The generated dtrace header on Solaris and MacOS are different. > Therefore people have to generate them during configure and then cannot > copy&paste sources to another machine and build, that's why the provided > zend_dtrace.h includes both variants of the header file and is included > in the patch.
The problem is, that if we update Zend/zend_dtrace.d, this header file will need to be regenerated. So, there is a need for a corresponding procedure. -- Alexey Zakhlestin http://www.milkfarmsoft.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
