Re: [PHP-DEV] PHP6 broken

2006-06-13 Thread Hannes Magnusson
9, 2006 7:06 PM > To: Dmitry Stogov > Cc: Marcus Boerger; Andi Gutmans; internals@lists.php.net > Subject: Re: [PHP-DEV] PHP6 broken > > > On 6/9/06, Dmitry Stogov <[EMAIL PROTECTED]> wrote: > > Hi Marcus, > > > > Could you please fix PHP6 build. > > You b

RE: [PHP-DEV] PHP6 broken

2006-06-12 Thread Dmitry Stogov
I think Marcus is the best person to review your patch. Dmitry. > -Original Message- > From: Hannes Magnusson [mailto:[EMAIL PROTECTED] > Sent: Friday, June 09, 2006 7:06 PM > To: Dmitry Stogov > Cc: Marcus Boerger; Andi Gutmans; internals@lists.php.net > Subject:

Re: [PHP-DEV] PHP6 broken

2006-06-09 Thread Marcus Boerger
Hello Hannes, the patch looks good and solves the issues as far as i can tell. We might want to make the abstract part an interface but we'll see. Just commit for now. best regards marcus Friday, June 9, 2006, 5:06:02 PM, you wrote: > On 6/9/06, Dmitry Stogov <[EMAIL PROTECTED]> wrote: >> Hi

Re: [PHP-DEV] PHP6 broken

2006-06-09 Thread Hannes Magnusson
On 6/9/06, Dmitry Stogov <[EMAIL PROTECTED]> wrote: Hi Marcus, Could you please fix PHP6 build. You broke it day or two ago :( Yeah, sorry about that, was my fault (it broke 5_2 to). Actually, this bug has been there for a while, but the engine didn't catch it since it had no idea which parame

[PHP-DEV] PHP6 broken

2006-06-09 Thread Dmitry Stogov
Hi Marcus, Could you please fix PHP6 build. You broke it day or two ago :( After your modifications of ext/reflection PHP always emits error messages about method incompatibilities. I am not sure if static methods must be checked for compatibility (I mean ReflectionMethod::export()), but Reflect