He has, and I've committed it already -Hannes
On 6/13/06, Dmitry Stogov <[EMAIL PROTECTED]> wrote:
I think Marcus is the best person to review your patch. Dmitry. > -----Original Message----- > From: Hannes Magnusson [mailto:[EMAIL PROTECTED] > Sent: Friday, June 09, 2006 7:06 PM > To: Dmitry Stogov > Cc: Marcus Boerger; Andi Gutmans; internals@lists.php.net > Subject: Re: [PHP-DEV] PHP6 broken > > > On 6/9/06, Dmitry Stogov <[EMAIL PROTECTED]> wrote: > > Hi Marcus, > > > > Could you please fix PHP6 build. > > You broke it day or two ago :( > Yeah, sorry about that, was my fault (it broke 5_2 to). > > Actually, this bug has been there for a while, but the engine > didn't catch it since it had no idea which parameters the methods had. > > I have a patch ready, which moves all methods from > ReflectionFunction into ReflectionFunctionAbstract (except > from export, invoke & invokeArgs), > http://php.is/bugs/reflection/reflections.patch.txt, just > need someone to review it before I commit it. > > -Hannes > > > > > After your modifications of ext/reflection PHP always emits error > > messages about method incompatibilities. > > > > I am not sure if static methods must be checked for > compatibility (I > > mean ReflectionMethod::export()), but ReflectionMethod::invoke() is > > not static. > > > > Thanks. Dmitry. > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > >
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
